Context Navigation

← Previous Ticket
Next Ticket →

#64638 new enhancement

Register emoji reactions comment meta for Notes

Reported by:	adamsilverstein	Owned by:
Priority:	normal	Milestone:	7.1
Component:	Editor	Version:
Severity:	normal	Keywords:	has-patch has-unit-tests gutenberg-merge
Cc:		Focuses:

Description (last modified by desrosj)

Summary

Register the _wp_note_reactions comment meta in wp_create_initial_comment_meta(), alongside the existing _wp_note_status meta. This meta stores emoji reaction data for the block editor's collaborative Notes feature.

Data Model

Each emoji key (e.g., "", "") maps to an array of reaction objects:

{
  "": [
    { "userId": 1, "date": "2025-01-15T10:30:00" },
    { "userId": 2, "date": "2025-01-15T11:00:00" }
  ],
  "": [
    { "userId": 1, "date": "2025-01-15T10:35:00" }
  ]
}

REST Schema

Type: object
Single: true
Default: [] (empty array)
additionalProperties: Each property is an array of objects with:
- userId (integer) — The reacting user's ID
- date (string|null, date-time format) — When the reaction was added

Auth

Uses the same edit_comment capability check as _wp_note_status.

Changes

Updated wp_create_initial_comment_meta() in src/wp-includes/comment.php to register _wp_note_reactions meta.
Updated docblock with @since 7.0.0 tag.
Regenerated tests/qunit/fixtures/wp-api-generated.js.

References

Gutenberg PR: #75148
wordpress-develop PR: #10930

Change History (10)

This ticket was mentioned in PR #10930 on WordPress/wordpress-develop by @adamsilverstein.

5 months ago #1

Keywords has-unit-tests added

## Summary

### Data Model

Each emoji key (e.g., "👍", "❤️") maps to an array of reaction objects:

{
  "👍": [
    { "userId": 1, "date": "2025-01-15T10:30:00" },
    { "userId": 2, "date": "2025-01-15T11:00:00" }
  ],
  "❤️": [
    { "userId": 1, "date": "2025-01-15T10:35:00" }
  ]
}

### REST Schema

Type: object
Single: true
Default: [] (empty array)
additionalProperties: Each property is an array of objects with:
- userId (integer) — The reacting user's ID
- date (string|null, date-time format) — When the reaction was added

### Auth

Uses the same edit_comment capability check as _wp_note_status.

## References

Gutenberg PR: https://github.com/WordPress/gutenberg/pull/75148
Trac ticket: (to be created)

---

#2 @swissspidy
5 months ago

Why store reactions like this and not as a separate comment type? Makes it more flexible and potentially useful for regular comments as well. See also https://wordpress.org/plugins/react/

#3 @wildworks
5 months ago

Keywords gutenberg-merge added

@adamsilverstein commented on PR #10930:

5 months ago #4

I have updated this backport PR to apply the custom comment type approach for storage used in https://github.com/WordPress/gutenberg/pull/75549 which replaces the meta based approach in https://github.com/WordPress/gutenberg/issues/75144.

#5 @audrasjb
5 months ago

Milestone 7.0 → 7.1

WP 7.0 pre-beta1 Triage:
Unfortunately this enhancement didn't make it before beta 1 code freeze. Thus, let's move it to milestone 7.1.

@adamsilverstein commented on PR #10930:

8 weeks ago #6

Thanks for the review @t-hamano! I've pushed f3b5af251b addressing the feedback:

@since bumps: Updated all PR-introduced @since 7.0.0 to @since 7.1.0 (in comment.php, link-template.php, and class-wp-rest-comments-controller.php).
WP_Comment_Query: Updated the existing exclusion block to iterate over wp_get_internal_comment_types() so both note and reaction are excluded by default unless explicitly requested.
get_lastcommentmodified(): Added a comment_type NOT IN (…) clause built from wp_get_internal_comment_types() to all three timezone branches so internal comment types no longer affect the last modified date.
Reaction icon list: Moved wp_get_note_reaction_emojis() into WP_REST_Comments_Controller::get_note_reaction_emojis() as a protected static method, per your suggestion to avoid a public global while the icon-library plans are still being worked out.
wp_internal_comment_types filter: Removed — agreed it's not needed for an internal helper.
wp_list_pluck simplification at line 360: Applied. The 'note' === $comment->comment_type check inside the loop was redundant since $request['type'] is already gated to 'note' above and WP_Comment_Query constrains the result set, so it's gone too.

Locally, the relevant test suites (Tests_Comment_*, Tests_REST_Comments, Tests_Avatar) all pass: OK (165 tests, 476 assertions).

#7 @audrasjb
7 weeks ago

Removing trunk version as this is not going to be shipped with WP 7.0 but in the next releases.

#8 @desrosj
7 weeks ago

Description modified (diff)
Summary Editor: Register emoji reactions comment meta for Notes → Register emoji reactions comment meta for Notes
Version trunk

Since this is an enhancement, there's no first version of WordPress this can be reproduced in. Removing trunk version.

This ticket was mentioned in Slack in #core by adrianduffell. View the logs.

16 hours ago

#10 @adrianduffell
13 hours ago

With the 7.1 beta approaching, this has a chance to be included if the PR can be reviewed in the coming days.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#64638 new enhancement

Register emoji reactions comment meta for Notes

Description (last modified by desrosj)

Summary

Data Model

REST Schema

Auth

Changes

References

Change History (10)

This ticket was mentioned in ​PR #10930 on ​WordPress/wordpress-develop by ​@adamsilverstein. 5 months ago #1

#2 @swissspidy 5 months ago

#3 @wildworks 5 months ago

​@adamsilverstein commented on ​PR #10930: 5 months ago #4

#5 @audrasjb 5 months ago

​@adamsilverstein commented on ​PR #10930: 8 weeks ago #6

#7 @audrasjb 7 weeks ago

#8 @desrosj 7 weeks ago

This ticket was mentioned in ​Slack in #core by adrianduffell. ​View the logs. 16 hours ago

#10 @adrianduffell 13 hours ago