#64647 closed enhancement (fixed)
Interactivity API: Update loading bar to use private router store
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 7.0 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Interactivity API | Keywords: | has-patch |
| Focuses: | Cc: |
Description
The Interactivity Router store contains internal properties (state.navigation.hasStarted, state.navigation.hasFinished) that are not part of the public API. Gutenberg PR #70882 moves these properties to a new private core/router/private store and adds deprecation warnings when they are accessed through the public core/router store.
The loading bar markup in WordPress Core (WP_Interactivity_API::print_router_markup()) currently uses data-wp-interactive="core/router" to bind to these internal navigation properties. This needs to be updated to data-wp-interactive="core/router/private" so it accesses the private store directly, avoiding the deprecation warnings.
Change History (3)
This ticket was mentioned in PR #10942 on WordPress/wordpress-develop by @luisherranz.
4 weeks ago
#1
- Keywords has-patch added
#2
@
4 weeks ago
- Owner set to luisherranz
- Resolution set to fixed
- Status changed from new to closed
In 61653:
@luisherranz commented on PR #10942:
4 weeks ago
#3
Thanks, Weston! 🙏❤️
The Interactivity Router store contains internal properties (
state.navigation.hasStarted,state.navigation.hasFinished) that are not part of the public API. Gutenberg PR #70882 moves these properties to a new privatecore/router/privatestore and adds deprecation warnings when they are accessed through the publiccore/routerstore.This PR updates the loading bar markup in
WP_Interactivity_API::print_router_markup()to usedata-wp-interactive="core/router/private"instead ofdata-wp-interactive="core/router", so it accesses the private store directly and avoids triggering the deprecation warnings.Trac ticket: https://core.trac.wordpress.org/ticket/64647
Related Gutenberg PR: https://github.com/WordPress/gutenberg/pull/70882