Make WordPress Core

Opened 3 months ago

Closed 2 months ago

Last modified 2 months ago

#64684 closed defect (bug) (fixed)

Bulk Edit selected items remove icon is oversized and misaligned

Reported by: mohitbsf's profile mohitbsf Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: admin-reskin has-patch commit
Focuses: css Cc:

Description

WordPress version: 7.0
Environment: Clean install, default theme (Twenty Twenty-Five), no active plugins

Steps to Reproduce

Go to Pages → All Pages

Select multiple pages using the checkboxes

Choose “Bulk edit” from the dropdown

Click “Apply”

Observe the selected pages list shown under the Bulk Edit panel

Expected Result

The remove (X) icon next to each selected page should:

Be visually aligned with the page title text

Match the size and alignment of similar remove icons used elsewhere in the admin

Appear proportionate within the row

Actual Result

The remove (X) icon:

Appears larger than expected

Is slightly misaligned vertically relative to the page title

Feels visually inconsistent with other admin UI elements

Additional Notes

Reproducible on a clean install

Occurs with all plugins deactivated

Appears to be a CSS sizing and alignment issue in the Bulk Edit component

Attachments (3)

Screen Shot on 2026-02-21 at 00-45-24.png (96.7 KB) - added by mohitbsf 3 months ago.
before-patch.png (61.8 KB) - added by shailu25 3 months ago.
Before Patch
after-patch.png (30.0 KB) - added by shailu25 3 months ago.
After Patch

Download all attachments as: .zip

Change History (19)

#1 @joedolson
3 months ago

  • Keywords admin-reskin added
  • Milestone changed from Awaiting Review to 7.0

Noting that the button also still has the old :focus color.

#2 @mohitbsf
3 months ago

Indeed, but the alignment of the X icon should be managed,

I do agree for the :focus color, good catch @joedolson

This ticket was mentioned in PR #10991 on WordPress/wordpress-develop by @opurockey.


3 months ago
#3

  • Keywords has-patch added

Ticket: https://core.trac.wordpress.org/ticket/64684

## Summary

This patch corrects the color inconsistency for the remove (X) icon in the Bulk Edit selected items list to match the current admin UI focus color standards.

## Description

The Bulk Edit panel was using an outdated focus color on the selected items “remove” icon, leading to visual inconsistency with other admin UI elements. This update aligns the icon’s focus color with the rest of the admin interface, improving visual cohesion and accessibility.

## Changes Included

  • Updated CSS variable for the remove (X) icon focus color in the Bulk Edit selected items list to use the current admin color token.
  • No changes have been made to the icon size or alignment — the existing size remains as in the current admin UI. The icon size visually appears consistent with surrounding UI, and no regression was observed.

## Rationale

  • Ensures the Bulk Edit UI matches the design system in terms of color usage.
  • Avoids unnecessary changes to icon size/alignment since the existing appearance is within acceptable design parameters.

## Testing

  • Verified on a clean install of WordPress trunk (7.0), default theme (Twenty Twenty-Five), no plugins activated.
  • Confirmed updated focus color matches other admin icons.
  • Confirmed no visual regressions in related UI elements.

## Screenshot

https://github.com/user-attachments/assets/2b45091e-cd28-4214-8aca-d55ccb7eb968
https://github.com/user-attachments/assets/2139087e-a8ba-4bfa-bc95-f17fbe7c1620

#4 @huzaifaalmesbah
3 months ago

This PR fixed the misalignment and i think new admin reskin increasing their icons size.

Before Apply Patch After Apply Patch ✅
https://i.ibb.co/R8hwhCf/Huzaifa-20260221213813.png https://i.ibb.co/4RrsPghs/Huzaifa-20260221214129.png

#5 @madhavishah01
3 months ago

Tested locally on WordPress 7.0 Beta 1.
The patch works as expected — icon alignment is corrected and the focus styling properly uses the admin CSS variables.
Looks good to me.

Before applying the patch:-
https://prnt.sc/bzOBjYiOkwZG

After applying the patch:-
https://prnt.sc/dcFvhUNfuYTS

#6 @sabernhardt
3 months ago

PR 10998 probably belongs on this ticket instead of #64685. It fixes the icon alignment in multiple places with relative line-height and other dimensions. The padding would not change. However, my PR does not adjust the focus styles (yet).

This ticket was mentioned in Slack in #core-test by ozgur_sar. View the logs.


3 months ago

#8 @r1k0
3 months ago

I tested PR 10998. The patch fixes the alignment issue and changes the size of the icons without changing the padding.

Noting that the button also still has the old :focus color.

Also, this PR 10991 changes the box-shadow color for the button while in :focus state. My confusion is whether the change should be for the button's color or the button's box-shadow in :focus state.

I'll submit a report once the adjustments to the :focus state are made.

Below are the before-and-after screenshots of the misalignment fixed. The black and red outlines are there to provide a visual aid on the alignment.

Before:
https://i.ibb.co/67Jv9v5D/bulk-edit-remove-btn-before.png

After:
https://i.ibb.co/9mDjqSXd/bulk-edit-remove-btn-after.png

Last edited 3 months ago by r1k0 (previous) (diff)

This ticket was mentioned in PR #10998 on WordPress/wordpress-develop by @sabernhardt.


3 months ago
#9

  • Assigns relative values for line-height, width and height of the icon in buttons that remove, dismiss or close. All three computed values match the font size.
  • Edits the :focus width and color for Bulk Edit remove buttons.

Props: opurockey

Trac 64684

Use of AI Tools: none

#10 @ozgursar
3 months ago

Patch Testing Report

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/10998

Environment

  • WordPress: 7.0-beta2-61752-src
  • PHP: 8.2.29
  • Server: nginx/1.29.4
  • Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
  • Browser: Chrome 145.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1

Steps taken

  1. In Dashboard All Pages > Pages
  2. Select All
  3. Choose Bulk adit from Bulk actions dropdown and click Apply
  4. Verify that remove icons are slightly misaligned with Page names
  5. Verify that focus state color of remove icons is #d63638
  6. Apply the patch
  7. Repeat 1-3
  8. Verify that icons are correctly aligned
  9. ✅ Patch is solving the problem

Expected result

  • Icons are properly sized and vertically centered with the titles

Additional Notes

  • Also mentioned by @r1k0, I'm not sure whether the icons' focus state color should be #d63638. common.css is overriding the focus color var(--wp-admin-theme-color)

Screenshots/Screencast with results

Before
https://i.imgur.com/1ff4Tz9.png

After
https://i.imgur.com/aZvZ0WV.png

#11 @noruzzaman
3 months ago

Test Report

Patch tested: https://github.com/WordPress/wordpress-develop/pull/10998

Environment

  • WordPress: 7.0-beta2-20260226.234351
  • PHP: 7.4.33
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
  • Browser: Chrome 145.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1

Actual Results

  1. ✅ Issue resolved with patch.
Before After
https://i.ibb.co.com/fdKdFhvg/before.png https://i.ibb.co.com/KpdDt25P/after.png

#12 @shailu25
3 months ago

Test Report

This Report Validates that the indicated patch address the issue.✅

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/10998

Environment:

WordPress - 7.0-beta2-20260228.025235
OS - Windows
Browser - Chrome
Theme: Twenty Twenty Five
PHP - 8.2.27
Plugin - None

Actual Results:

  • Issue Resolved with Patch ✅

Supplemental Artifacts

  • Attached

@shailu25
3 months ago

Before Patch

@shailu25
3 months ago

After Patch

#13 @joedolson
2 months ago

  • Owner set to joedolson
  • Status changed from new to accepted

#14 @joedolson
2 months ago

  • Keywords commit added

#15 @joedolson
2 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 61784:

Admin: Reskin - update dismiss icons sizing.

Update the sizing of icons in the welcome panel, bulk edit, quick edit, and admin notifications to use relative sizing, fixing alignment issues.

Update focus state for bulk edit remove buttons.

Props mohitbsf, opurockey, sabernhardt, huzaifaalmesbah, madhavishah01, r1k0, ozgursar, noruzzaman, shailu25, joedolson, mukesh27.
Fixes #64684.

Note: See TracTickets for help on using tickets.