Make WordPress Core

Opened 4 months ago

Closed 6 weeks ago

#64685 closed defect (bug) (fixed)

Bulk Edit dropdown height increased compared to previous version

Reported by: mohitbsf's profile mohitbsf Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: minor Version: 7.0
Component: Quick/Bulk Edit Keywords: admin-reskin has-patch dev-reviewed fixed-major
Focuses: css Cc:

Description

WordPress versions compared:

6.9.1

7.0

Environment: Clean install, default theme, no active plugins

Steps to Reproduce

Go to Pages → All Pages

Select multiple pages

Choose “Bulk edit” and click “Apply”

Observe the dropdown fields in the Bulk Edit panel

Compare the dropdown height between WordPress 6.9.1 and 7.0

Expected Result

Dropdown height should remain visually consistent across versions unless intentionally updated as part of a UI refresh.

Actual Result

The dropdown fields in 7.0 appear slightly taller than in 6.9.1. This changes the vertical rhythm of the Bulk Edit panel.

Additional Notes

The change may be intentional as part of UI adjustments

Reporting for confirmation in case this was unintended

No plugins active during testing

Attachments (2)

Screen Shot 2026-02-21 at 00.49.47.png (490.7 KB) - added by mohitbsf 4 months ago.
Huzaifa-20260221212622.png (84.8 KB) - added by huzaifaalmesbah 4 months ago.
There’s no issue with the increased height of the Bulk Edit dropdown. However, the selected input fields (Author, Parent, Template, Comments, Status) have inconsistent spacing between them. This should be fixed for a cleaner look.

Download all attachments as: .zip

Change History (37)

#1 @joedolson
4 months ago

  • Keywords admin-reskin added
  • Milestone changed from Awaiting Review to 7.0
  • Type changed from enhancement to defect (bug)

This is an intentional design change, although it may be that this specific case should be adjusted. Overall, the bulk edit interface looks like it could use a bit more attention in the admin reskin.

#2 @mohitbsf
4 months ago

Yes, ofcourse, it do look a little odd, the spacing is something which make it looks unfinished IMO.

@huzaifaalmesbah
4 months ago

There’s no issue with the increased height of the Bulk Edit dropdown. However, the selected input fields (Author, Parent, Template, Comments, Status) have inconsistent spacing between them. This should be fixed for a cleaner look.

This ticket was mentioned in PR #10998 on WordPress/wordpress-develop by @sabernhardt.


4 months ago
#3

  • Keywords has-patch added
  • Assigns relative values for line-height, width and height of the icon in buttons that remove, dismiss or close. All three computed values match the font size.
  • Reduces top value for dashboard welcome panel dismiss button.

Trac 64685

Use of AI Tools: none

#4 @sabernhardt
4 months ago

The icon is larger, and the 24px line-height pushes the icon down. PR 10998 keeps the larger font size but adjusts other dimensions for vertical alignment.

In the Bulk Edit settings for pages, the Author, Parent, and Template input fields already were closer together than Comments and Status in WordPress 6.9. Switching the labels' .2em 0 margin to padding theoretically could make it more consistent, but then the Tags textarea in Quick Edit for posts would be noticeably lower.

I also tried increasing the line-height for labels from 2.5 to 3, but that causes new alignment issues (with fields such as "or" and the Private checkbox next to the post password). The large line-height is already unfriendly when the label text is wider than 6em and needs to wrap to the next line (for example, in French).

#5 @mukesh27
4 months ago

  • Version set to trunk

Per [61645], the commit message clearly states that the select height was intentionally increased and is part of the new design system. Given that, could you clarify what issue we’re trying to resolve here? Is this a regression, an unintended side effect, or are we aiming to override the new design for a specific context?

This ticket was mentioned in Slack in #core-test by ozgur_sar. View the logs.


4 months ago

#7 @juanmaguitar
4 months ago

Per [61645], the commit message clearly states that the select height was intentionally increased and is part of the new design system.

@fabiankaegy could you confirm if this new look for selects is expected with the new design applied on #64547 ?

#8 @fabiankaegy
4 months ago

The change of increasing the height of select controls across the admin was intentional. However we have added overrides for places where the new height didn't feel appropriate. I can see how Quick Edit makes sense for this treatment.

#9 @sabernhardt
4 months ago

  • Keywords has-patch removed

I connected PR 10998 to #64684, so this ticket can consider possible changes to label alignment and spacing, apart from the icon changes.

#10 @joedolson
4 months ago

  • Owner set to joedolson
  • Status changed from new to accepted

This ticket was mentioned in PR #11117 on WordPress/wordpress-develop by @joedolson.


4 months ago
#11

  • Keywords has-patch added

Uses compact input sizes for all text & select inputs in inline editing.

Effects both quick edit and bulk edit.

Trac ticket: https://core.trac.wordpress.org/ticket/64685

## Use of AI Tools

@joedolson commented on PR #11117:


4 months ago
#12

After patch:

https://github.com/user-attachments/assets/b09be12d-edb1-42fc-985c-933c9ffd11de

https://github.com/user-attachments/assets/45754d74-9677-404b-b8cb-36d432188a77

@joedolson commented on PR #11117:


4 months ago
#13

Before patch:
https://github.com/user-attachments/assets/05e52dc2-f32f-4cd4-bda2-dcdf981803ee

https://github.com/user-attachments/assets/09bfe076-1b6a-4784-bc78-e6b23fdb3cae

@joedolson commented on PR #11117:


4 months ago
#14

Noting there's still work to do on the date and password fields

@joedolson commented on PR #11117:


4 months ago
#15

Reverted the switches to flex layout. Would be nice, but there's actually a lot of work to get that working with some of the existing styles. Better to leave that for some future structural design changes, if they happen.

@joedolson commented on PR #11117:


4 months ago
#17

After patch, following revert:

https://github.com/user-attachments/assets/9c623fc8-9b6f-4500-a3b8-25dd9c3927fa

https://github.com/user-attachments/assets/fb08f774-0d83-45c5-a28b-79858ad2d9a2

@joedolson commented on PR #11117:


4 months ago
#18

I didn't quite match the screenshot sizes; the alignment differences in the password and date fields in the new after are just artifacts of slightly different screen width.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


4 months ago

@shailu25 commented on PR #11117:


4 months ago
#20

Bulk Edit:

BeforeAfter
https://github.com/user-attachments/assets/7897493d-3a7d-4cde-8c29-58b13bd17895https://github.com/user-attachments/assets/a106fb5c-c931-4ecb-a993-cac5db078ce8

@shailu25 commented on PR #11117:


4 months ago
#21

Quick Edit:

BeforeAfter
https://github.com/user-attachments/assets/44ec013e-3d60-4068-88e9-8d2cc363699bhttps://github.com/user-attachments/assets/6b666527-4548-4f99-998b-6074f5c1ce70

#22 @joedolson
4 months ago

  • Keywords commit added

#23 @joedolson
4 months ago

  • Component changed from Administration to Quick/Bulk Edit

#24 @joedolson
4 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 61827:

Quick/Bulk Edit: Use compact sizing on inputs after admin reskin.

Change inputs in the bulk and quick edit to use compact sizing.

Props mohitbsf, sabernhardt, mukesh27, juanmaguitar, fabiankaegy, shailu25, joedolson.
Fixes #64685.

This ticket was mentioned in PR #11631 on WordPress/wordpress-develop by @wildworks.


8 weeks ago
#25

Trac ticket: https://core.trac.wordpress.org/ticket/64685

The height of elements in the Quick Edit UI was unified to 32px by r61827. However, subsequent changes in r62171 unintentionally removed the line-height not only from input elements but also from select elements. As a result, the following styles were applied to select elements, causing their height to unintentionally revert to 40px.

.wp-core-ui select {
        line-height: 2.71428571; /* 38px for 40px min-height */
}

This PR restores the appropriate line-height value to achieve the 32px height.

## Screenshots

### Before

https://github.com/user-attachments/assets/ea6740ea-8e25-4edd-b8ef-1a9a4c150166

### After

https://github.com/user-attachments/assets/feece088-86e7-480f-a688-ba16537805e0

## Use of AI Tools

None

#26 @wildworks
8 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry, I found that [62171] reintroduced the issue that had been fixed in [61827]. This happened because [62171] removed the line-height not only from input elements, but also from select elements.

PR 11631 should fix this regression.

#27 @wildworks
8 weeks ago

  • Keywords commit removed

@wildworks commented on PR #11631:


8 weeks ago
#28

Do we need to add a note for future reference so this doesn’t get removed again?

Nice idea, addressed in #92bc76698d8c45eaf2d9eae60fceefb5d64152d2

P.S. I also propose removing hardcoded line-height values from all select elements in the future, as it can sometimes be difficult to predict the final element height.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


7 weeks ago

#30 @audrasjb
7 weeks ago

  • Keywords commit added

As per today's bug scrub:
This was committed but @wildworks mentioned that the patch introduces a regression, and added a new PR to fix the issue. It looks good on my side. Pinging @joedolson as ticket owner :)

#31 @SergeyBiryukov
6 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 62296:

Quick/Bulk Edit: Restore compact size of inline edit select.

Follow-up to [61827], [62171].

Props wildworks, mukesh27, audrasjb, SergeyBiryukov.
Fixes #64685.

#32 @SergeyBiryukov
6 weeks ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 7.0 consideration.

#33 @wildworks
6 weeks ago

  • Keywords dev-reviewed added; commit dev-feedback removed

[62296] seems to be good to backport to 7.0

#34 @jorbin
6 weeks ago

  • Keywords fixed-major added

#35 @jorbin
6 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 62307:

Quick/Bulk Edit: Restore compact size of inline edit select.

Follow-up to [61827], [62171].

Reviewed-by wildworks, jorbin.
Merges [62296] to the 7.0 branch.

Props wildworks, mukesh27, audrasjb, SergeyBiryukov.
Fixes #64685.

Note: See TracTickets for help on using tickets.