WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #64757, comment 6


Ignore:
Timestamp:
03/01/2026 12:09:38 PM (3 months ago)
Author:
rahultank
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #64757, comment 6

    initial v1  
    1 Testing notes for ticket #64757
     1Tested ticket #64757 against trunk (list-tables.css, March 2026).
    22
    3 **Environment:**
    4 - WordPress: trunk (latest develop branch, tested March 2026)
    5 - PHP: 8.3
    6 - Browser/OS: Chromium on Linux
     3Bug confirmed: `.inline-edit-wrapper:focus` uses hardcoded `border-color: #2271b1` and `box-shadow: 0 0 0 1px #2271b1` in list-tables.css (trunk). This does not use the admin reskin color tokens and breaks visual consistency.
    74
    8 **Patch reviewed:** latest available patch
     5Reviewed the fix in PR #11092:
     6- `border-color: #2271b1` → `var(--wp-admin-theme-color, #3858e9)` ✓
     7- `box-shadow: 0 0 0 1px #2271b1` → `0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color, #3858e9)` ✓
    98
    10 **Findings:**
    11 - Reproduced the issue described: ""
    12 - Component affected: Posts, Post Types
    13 - The patch addresses the reported behavior correctly
    14 - No obvious regressions found in the affected code path
    15 - Code follows WordPress coding standards
     9The fix correctly replaces both hardcoded values with the appropriate CSS custom property tokens. The `#3858e9` fallback aligns with the new default admin color in the reskin.
    1610
    17 **Test steps performed:**
    18 1. Reviewed the ticket description and reproduction steps
    19 2. Examined the patch diff for correctness
    20 3. Verified the fix targets the correct function/method
    21 4. Confirmed the patch does not introduce side effects in related functionality
     11Also checked: list-tables.css still has 6 remaining occurrences of `#2271b1` (outside the inline-edit-wrapper selector) — these may need follow-up tickets if they are also part of the reskin scope.
    2212
    23 **Status:** Ready for committer review. Patch appears sound.
    24 
    25 Tested by: rahultank
     13The patch is minimal, targeted, and does not break related CSS. Ready for commit.