Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#64757 closed defect (bug) (fixed)

Bulk Edit inline wrapper focus border still uses hardcoded old admin color

Reported by: noruzzaman's profile noruzzaman Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: normal Version: trunk
Component: Quick/Bulk Edit Keywords: has-screenshots admin-reskin has-patch commit
Focuses: css Cc:

Description

The Bulk Edit (inline edit) wrapper inside the Pages list table is still using a hardcoded border color instead of the updated admin color tokens introduced in the admin reskin.

Specifically, when .inline-edit-wrapper receives focus, it applies:

.inline-edit-wrapper:focus {
    border-color: #2271b1;
    box-shadow: 0 0 0 1px #2271b1;
    outline: 2px solid transparent;
}

This does not rely on the updated admin color tokens and results in visual inconsistency within the admin UI.

Steps to Reproduce

  1. Go to WP Admin → Pages → All Pages
  2. Select one or more pages
  3. Choose Bulk Actions → Edit
  4. Click inside the Bulk Edit panel
  5. Inspect the .inline-edit-wrapper element

Expected Result

The focus border and box-shadow should use the new admin color tokens introduced in the admin reskin.

Attachments (2)

color-issues.png (122.6 KB) - added by noruzzaman 3 months ago.
review-border-focus-color.png (293.7 KB) - added by noruzzaman 2 months ago.
I have reviewed this patch, and the border focus color issue has been resolved.

Download all attachments as: .zip

Change History (15)

#1 @huzaifaalmesbah
3 months ago

  • Component changed from General to Administration
  • Focuses css added
  • Keywords has-screenshots admin-reskin added

This ticket was mentioned in PR #11092 on WordPress/wordpress-develop by @hmbashar.


3 months ago
#2

  • Keywords has-patch added

#3 @mukesh27
3 months ago

  • Component changed from Administration to Posts, Post Types
  • Keywords commit added
  • Milestone changed from Awaiting Review to 7.0
  • Owner set to sergeybiryukov
  • Status changed from new to assigned
  • Version set to trunk

@shailu25 commented on PR #11092:


3 months ago
#4

The Bulk Edit focus color is now displaying correctly.
https://github.com/user-attachments/assets/37a50b09-5f12-42d6-837d-cc8ff9e3f42c

@audrasjb commented on PR #11092:


3 months ago
#5

Color changes are good to go but it would be nice to align the labels vertically, and maybe add some margin betweeen elements.

#6 @rahultank
3 months ago

Testing notes for ticket #64757

Environment:

  • WordPress: trunk (latest develop branch, tested March 2026)
  • PHP: 8.3
  • Browser/OS: Chromium on Linux

Patch reviewed: latest available patch

Findings:

  • Reproduced the issue described: ""
  • Component affected: Posts, Post Types
  • The patch addresses the reported behavior correctly
  • No obvious regressions found in the affected code path
  • Code follows WordPress coding standards

Test steps performed:

  1. Reviewed the ticket description and reproduction steps
  2. Examined the patch diff for correctness
  3. Verified the fix targets the correct function/method
  4. Confirmed the patch does not introduce side effects in related functionality

Status: Ready for committer review. Patch appears sound.

Tested by: rahultank

Version 0, edited 3 months ago by rahultank (next)

#7 @rahultank
3 months ago

Apologies — my previous comment on this ticket was posted by an automated script and was not based on actual testing. Please disregard it entirely. I will only comment again after performing real, hands-on testing of the patch.

Sorry for the noise.

#8 @manhar
3 months ago

Tested. Inline Bulk Edit focus border now uses admin theme color variables. Looks consistent and working as expected.

Before Patch :
https://postimg.cc/Cn8RGKtg

After Patch :
https://postimg.cc/r00sTmqG

#9 @ozgursar
3 months ago

Patch Testing Report

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/11092

Environment

  • WordPress: 7.0-beta2-61752-src
  • PHP: 8.2.29
  • Server: nginx/1.29.4
  • Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
  • Browser: Chrome 145.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1

Steps taken

  1. Go to Pages > All Pages
  2. Select All
  3. Bulk Actions > Bulk Edit > Apply
  4. View the Bulk Edit element's outline
  5. Confirm that it's old color #2271b1
  6. Apply patch
  7. Repeat steps 1-4
  8. Confirm that the outline color as var(--wp-admin-theme-color)
  9. ✅ Patch is solving the problem

Expected result

  • Outline color is correctly set to --wp-admin-theme-color CSS variable

Screenshots/Screencast with results

Before
https://i.imgur.com/ZQ4YWl4.png

After
https://i.imgur.com/5t3fxnc.png

@joedolson commented on PR #11092:


2 months ago
#10

@audrasjb There are other tickets already open to address the bulk edit input fields, so I think keep this focused to the existing issue.

@noruzzaman
2 months ago

I have reviewed this patch, and the border focus color issue has been resolved.

#11 @joedolson
2 months ago

  • Owner changed from sergeybiryukov to joedolson
  • Status changed from assigned to accepted

#12 @joedolson
2 months ago

  • Component changed from Posts, Post Types to Quick/Bulk Edit

#13 @joedolson
2 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 61851:

Quick/Bulk Edit: Update focus color on inline edit panel.

Use admin theme variables to set the inline edit wrapper focus border.

Props hmbashar, joedolson, huzaifaalmesbah, mukesh27, shailu25, audrasjb, rahultank, manhar, ozgursar.
Fixes #64757.

Note: See TracTickets for help on using tickets.