Make WordPress Core

Opened 7 weeks ago

Closed 13 days ago

#64761 closed defect (bug) (fixed)

Admin Reskin: Change color picker height to 40px

Reported by: wildworks's profile wildworks Owned by: audrasjb's profile audrasjb
Milestone: 7.0 Priority: normal
Severity: normal Version: trunk
Component: Administration Keywords: admin-reskin has-patch has-screenshots dev-reviewed
Focuses: Cc:

Description

As part of the Admin reskin effort, the height of input elements, select elements, buttons, etc. has been changed from 30px to 40px. I think the height of the color picker should also be changed to 40px, otherwise the UI will be inconsistent.

In the plugin I am developing, RichText Extension, the input element and color picker are displayed side by side, which makes the difference in height even more noticeable.

Attachments (2)

RichText Extension Setting page.png (124.7 KB) - added by wildworks 7 weeks ago.
RichText Extension plugin setting page
wp-picker-container-button.png (137.5 KB) - added by noruzzaman 6 weeks ago.
I tested this patch and the 40px height change makes the color picker perfectly consistent with the WordPress admin reskin.

Download all attachments as: .zip

Change History (36)

@wildworks
7 weeks ago

RichText Extension plugin setting page

This ticket was mentioned in PR #11093 on WordPress/wordpress-develop by @hmbashar.


7 weeks ago
#1

  • Keywords has-patch added

@huzaifaalmesbah commented on PR #11093:


7 weeks ago
#2

Should we also update .wp-picker-container input[type="text"].wp-color-picker min-height (currently 30px) to keep alignment consistent?
https://github.com/user-attachments/assets/bdf18ec9-0a03-44ef-8680-695b91d587a1

#3 @audrasjb
7 weeks ago

  • Version set to trunk

@noruzzaman
6 weeks ago

I tested this patch and the 40px height change makes the color picker perfectly consistent with the WordPress admin reskin.

#4 @rahultank
6 weeks ago

Reviewed ticket #64761 against trunk source (color-picker.css, March 2026).

Bug confirmed: The admin reskin updated all input elements, select elements, and buttons from 30px to 40px height. The color picker component is still using the old 30px height, creating a visual inconsistency when used alongside other form elements.

Trunk CSS height values found:

  • 30px occurrences: 4 (old size)
  • 40px occurrences: 3 (new reskin size)

Height-related lines in color-picker.css:

min-height: 30px;
line-height: 2.54545455; /* 28px */
line-height: 2.54545455; /* 28px */
min-height: 30px;
line-height: 2.33333333; /* 28px */
min-height: 30px;

line-height: 1.875; /* 30px */
min-height: 32px;
line-height: 2.14285714; /* 30px */
min-height: 32px;

PR https://github.com/WordPress/wordpress-develop/pull/11093 changes:
Removed: - min-height: 30px;
Added: + min-height: 40px;
Fix looks correct — aligns color picker height with other 40px form elements.

This is especially visible when a plugin places a color picker next to a text input (as noted in the ticket description). The fix is straightforward and low-risk.

Last edited 6 weeks ago by rahultank (previous) (diff)

#5 @tusharaddweb
6 weeks ago

I can confirm this bug exists in WordPress 7.0 beta-2.

I tested the behavior with and without the patch, and the patch fixes the issue as described. Without the patch the problem is visible, and with the patch applied the behavior is correct.

Before applying the patch:-
https://prnt.sc/FKP9VkyFeTys

After applying the patch:-
https://prnt.sc/5u-eo8XjNu-2

#6 @audrasjb
6 weeks ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

@wildworks commented on PR #11093:


6 weeks ago
#7

Apologies for raising an alternative suggestion at this stage, but moving from 30px to 40px feels like a fairly significant visual change. What do you think about using 32px instead of 40px? As far as I understand, 32px is an allowed value in the new dashboard design system.

https://github.com/user-attachments/assets/8b2f8256-c9fb-40f9-983a-b67a0e420618

#8 @audrasjb
6 weeks ago

  • Keywords changes-requested added

@ozgursar commented on PR #11093:


4 weeks ago
#9

Would using flexbox in .wp-picker-container container be a better decision here rather than trying to adjust their individual heights via line-height, min-height, or paddings?

This ticket was mentioned in Slack in #core by juanmaguitar. View the logs.


3 weeks ago

@juanmaguitar commented on PR #11093:


3 weeks ago
#11

Hi @hmbashar! Thanks for working on this issue.
There's some feedback on this PR pending on response (or to be addressed).
Do you think you'll be able to work on this and get it ready in time for the final release of WP 7.0 (in a few weeks)

@audrasjb commented on PR #11093:


3 weeks ago
#12

Well, currently with 7.0 RC2, I don't see any issue with the actual implementation anymore.
Steps to reproduce:

  1. Install TT1 theme
  2. Go to Customizer > Colors and Dark mode
  3. It looks aligned on my side:

https://github.com/user-attachments/assets/235ad6ae-bc1d-49ff-aab3-df8ff632d227

#13 @audrasjb
3 weeks ago

  • Keywords close 2nd-opinion added

Well now I'm unsure we should change anything at all. The current implementation looks consistent with the compact styles used by the text input and the button associated with the colorpicker. See the screenshot above shared in the PR.

Any thought on this @wildworks @joedolson or @sabernardt?
Adding close and 2nd-opinion keywords for now.

#14 @wildworks
3 weeks ago

Sorry for the confusion.

The fundamental issue this ticket addresses is that the color picker is using a 30px height, which does not align with the new design system. Initially, I proposed the new 40px default size, but I now feel that perhaps a 32px size would be more appropriate.

This ticket could potentially be deferred to 7.1, but I still believe it remains valid.

#15 @audrasjb
3 weeks ago

  • Keywords close 2nd-opinion removed

Ah ok, but then we would also update the height of the hex input and the button, right?

#16 @wildworks
3 weeks ago

we would also update the height of the hex input and the button, right?

I think so.

This ticket was mentioned in PR #11385 on WordPress/wordpress-develop by @shailu25.


3 weeks ago
#17

Refreshed PR #11093 and added feedback changes.

Trac ticket: #64761

## Use of AI Tools

None

#19 @rcorrales
2 weeks ago

Tested https://github.com/WordPress/wordpress-develop/pull/11385 on trunk, macOS/Chrome.

Confirmed on trunk: color picker elements are still at 30px while the admin reskin updated other inputs/buttons to 40px.

With the patch, all color picker elements (Select Color button, hex input, Default/Clear button) update to 32px consistently. Tested in:

  1. Twenty Fifteen Customizer (Colors section, Background Color + Header/Sidebar Text Color + Header/Sidebar Background Color). All three pickers render at 32px, internally aligned.
  2. Twenty Twenty-One Customizer (Colors & Dark Mode). Same, Select Color + hex input + Default all at 32px.
  3. Custom plugin settings page with wp_color_picker placed side by side with a regular text input. The color picker (32px) is closer to the text input (40px) than before (was 30px vs 40px). The 8px remaining gap is expected per the design discussion.

No regressions or overflow/scrollbar issues, text is vertically centered in buttons, color picker widget renders correctly.

#20 @vgnavada
2 weeks ago

  • Keywords has-screenshots added

Test Report

Description

This report validates the CSS values applied to color picker elements with the patch.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/11385

Environment

  • WordPress: 7.1-alpha-20260330.074838
  • PHP: 8.3.30
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
  • Browser: Chrome 146.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins: None activated
  • Plugins:
    • RichText Extension 3.0.0
    • Test Reports 1.2.1

Actual Results

  1. .wp-color-result and .wp-picker-clear resolve to 32px.
  2. Base button rule (40px) is overridden.
  3. Patch updates color picker elements from 30px to 32px.

Supplemental Artifacts

Screenshot: https://prnt.sc/WWztSjRnJFGs

This ticket was mentioned in Slack in #core-test by nikunj8866. View the logs.


2 weeks ago

#22 @sajib1223
2 weeks ago

Patch Testing Report

Patch tested: https://github.com/WordPress/wordpress-develop/pull/11093
Playground: https://playground.wordpress.net/?core-pr=11385&wp=trunk

Environment

  • OS: Windows 10/11
  • Web Server: PHP.wasm
  • PHP: 8.3.30
  • WordPress: 7.1-alpha-20260328.140010
  • Browser: Firefox 149.0
  • Theme: Twenty Twenty-One 2.7
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
  • Active Plugins:
    • RichText Extension 3.0.0
    • Test Reports 1.2.1

Steps to Test

  1. Install and activate the Twenty Twenty-One theme.
  2. Navigate to Appearance > Customize > Colors.
  3. Observe the color picker button height and its alignment with the adjacent hex input field.

Expected Results

  • ✅ The color picker button height is increased from 30px to 32px, consistent with the new dashboard design system.
  • ✅ The color picker button and the hex input field are visually aligned.
  • ✅ No layout regression is observed in the Customizer color panel.

Additional Notes

  • The PR went through several iterations. The final implementation settles on 32px (not the originally proposed 40px), which aligns with the allowed values in the new WP dashboard design system as noted by @t-hamano.
  • Reviewer @audrasjb confirmed correct visual alignment on WP 7.0 RC2 via the same TT1 Customizer > Colors path (March 28, 2026).
  • comment:19 by @rcorrales (macOS/Chrome, trunk) independently confirmed the same results across Twenty Fifteen and Twenty Twenty-One Customizer, and a custom plugin settings page using wp_color_picker.

Screenshots

https://files.catbox.moe/el96cf.png

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 weeks ago

#24 @audrasjb
2 weeks ago

  • Keywords commit added; changes-requested removed

Let's roll.

#26 @audrasjb
2 weeks ago

@wildworks yes, 11385

#28 @wildworks
2 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 62191:

Admin Reskin: Change color picker height to match new design system.

Update min-height from 30px to 32px for the color picker button and related elements to match new design system.

Props audrasjb, hmbashar, huzaifaalmesbah, joedolson, juanmaguitar, mukesh27, noruzzaman, ozgursar, rahultank, rcorrales, sajib1223, tusharaddweb, vgnavada, wildworks.

Fixes #64761.

#29 @wildworks
2 weeks ago

  • Keywords dev-feedback added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening #64761 to request backporting [62191] to 7.0 branch

#30 @shailu25
2 weeks ago

@wildworks I think you forgot to add me in the prop list.

#31 @wildworks
2 weeks ago

@shailu25 Sorry!

@audrasjb, I believe I was able to update props on a certain website. Do you know about that?

#32 @joedolson
13 days ago

  • Keywords dev-reviewed added; dev-feedback removed

@wildworks You can update props in the admin at make.wordpress.org/core, using the 'Core Props' tool.

Reviewed and approved for 7.0.

#33 @wildworks
13 days ago

You can update props in the admin at make.wordpress.org/core, using the 'Core Props' tool.

Thanks you, updated.

Last edited 13 days ago by wildworks (previous) (diff)

#34 @wildworks
13 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 62202:

Admin Reskin: Change color picker height to match new design system.

Update min-height from 30px to 32px for the color picker button and related elements to match new design system.

Reviewed by joedolson, wildworks.
Merges [62191] to the 7.0 branch.

Props audrasjb, hmbashar, huzaifaalmesbah, joedolson, juanmaguitar, mukesh27, noruzzaman, ozgursar, rahultank, rcorrales, sajib1223, shailu25, tusharaddweb, vgnavada, wildworks.

Fixes #64761.

Note: See TracTickets for help on using tickets.