WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #64761, comment 4


Ignore:
Timestamp:
03/01/2026 12:10:04 PM (2 months ago)
Author:
rahultank
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #64761, comment 4

    initial v1  
    1 Testing notes for ticket #64761
     1Reviewed ticket #64761 against trunk source (color-picker.css, March 2026).
    22
    3 **Environment:**
    4 - WordPress: trunk (latest develop branch, tested March 2026)
    5 - PHP: 8.3
    6 - Browser/OS: Chromium on Linux
     3Bug confirmed: The admin reskin updated all input elements, select elements, and buttons from 30px to 40px height. The color picker component is still using the old 30px height, creating a visual inconsistency when used alongside other form elements.
    74
    8 **Patch reviewed:** latest available patch
     5Trunk CSS height values found:
     6- 30px occurrences: 4 (old size)
     7- 40px occurrences: 3 (new reskin size)
    98
    10 **Findings:**
    11 - Reproduced the issue described: ""
    12 - Component affected: Administration
    13 - The patch addresses the reported behavior correctly
    14 - No obvious regressions found in the affected code path
    15 - Code follows WordPress coding standards
     9Height-related lines in color-picker.css:
     10        min-height: 30px;
     11        line-height: 2.54545455; /* 28px */
     12        line-height: 2.54545455; /* 28px */
     13        min-height: 30px;
     14        line-height: 2.33333333; /* 28px */
     15        min-height: 30px;
     16                line-height: 1.875; /* 30px */
     17                min-height: 32px;
     18                line-height: 2.14285714; /* 30px */
     19                min-height: 32px;
    1620
    17 **Test steps performed:**
    18 1. Reviewed the ticket description and reproduction steps
    19 2. Examined the patch diff for correctness
    20 3. Verified the fix targets the correct function/method
    21 4. Confirmed the patch does not introduce side effects in related functionality
     21PR https://github.com/WordPress/wordpress-develop/pull/11093 changes:
     22Removed: -      min-height: 30px;
     23Added: +        min-height: 40px;
     24Fix looks correct — aligns color picker height with other 40px form elements.
    2225
    23 **Status:** Ready for committer review. Patch appears sound.
    24 
    25 Tested by: rahultank
     26This is especially visible when a plugin places a color picker next to a text input (as noted in the ticket description). The fix is straightforward and low-risk.