Make WordPress Core

Opened 2 months ago

Closed 2 months ago

#64788 closed defect (bug) (fixed)

Plugins/Themes: Filter component doesn't use new colors

Reported by: ocean90's profile ocean90 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots good-first-bug admin-reskin has-patch
Focuses: ui, css Cc:

Description

See attached screenshots for the old colors used in the .wp-filter component. The filter is used on the screen for adding new plugins/themes.

Attachments (4)

themes-filter.png (19.9 KB) - added by ocean90 2 months ago.
plugins-filter.png (22.3 KB) - added by ocean90 2 months ago.
plugins-filter-focus.png (22.0 KB) - added by ocean90 2 months ago.
feature-filter.png (343.2 KB) - added by noruzzaman 2 months ago.
This patch updates the background color of the feature filter button in the Themes screen. The current border color does not match the updated background, so it should also be adjusted to maintain visual consistency.

Download all attachments as: .zip

Change History (12)

#1 @ocean90
2 months ago

  • Keywords admin-reskin added

This ticket was mentioned in PR #11153 on WordPress/wordpress-develop by @niravsherasiya7707.


2 months ago
#2

  • Keywords has-patch added; needs-patch removed

Trac ticket:

## Use of AI Tools

@noruzzaman
2 months ago

This patch updates the background color of the feature filter button in the Themes screen. The current border color does not match the updated background, so it should also be adjusted to maintain visual consistency.

This ticket was mentioned in PR #11155 on WordPress/wordpress-develop by @manishxdp.


2 months ago
#3

Trac ticket: https://core.trac.wordpress.org/ticket/64788

## Summary

The .wp-filter component used on the Add Plugins and Add Themes screens
is still using legacy hardcoded color values instead of the new admin
color variables introduced as part of the admin reskin.

This causes visual inconsistencies with the updated admin color system.

## Changes

  • Replaced hardcoded color values with the appropriate CSS custom properties:
    • --wp-admin-theme-color
    • --wp-admin-theme-color-darker-10
    • --wp-admin-border-color
  • Ensured hover, focus, and active states use the new design tokens.
  • No visual changes outside of the filter component.

@huzaifaalmesbah commented on PR #11155:


2 months ago
#4

Thanks for the PR.
I noticed only var(--wp-admin-theme-color) is used, while the description mentions other variables as well. Could you clarify why?

Also, a similar fix already exists in PR https://github.com/WordPress/wordpress-develop/pull/11153
Is there a reason for opening another PR?

@manishxdp commented on PR #11155:


2 months ago
#5

@huzaifaalmesbah You’re right — the patch only uses var(--wp-admin-theme-color). The PR description was incorrect in mentioning --wp-admin-theme-color-darker-10 and --wp-admin-border-color. I’ll update the description.

@manishxdp commented on PR #11155:


2 months ago
#6

I wasn’t aware of PR #11153 when I opened this.

#7 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#8 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 61832:

Admin Reskin: Correct color scheme for plugin and theme filters.

Props ocean90, niravsherasiya7707, noruzzaman, manishxdp, huzaifaalmesbah, SergeyBiryukov.
Fixes #64788.

Note: See TracTickets for help on using tickets.