![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 5 months ago
Closed 2 months ago
#64792 closed enhancement (fixed)
Consider changing code tags to regular text for dimension values in "Site Icon" help text
| Reported by: | juanfra | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.1 |
| Component: | Administration | Version: | 6.5 |
| Severity: | normal | Keywords: | good-first-bug has-patch commit has-screenshots |
| Cc: | Focuses: |
Description
The Site Icon help text uses <code> tags around dimension values, which is probably not needed given the context.
This shows up in two places (one and two). The dimensions are just regular measurements in help text, so they don't need the monospace treatment.
I'd propose to wrap them in <strong> if the objective is to add prominence. Or avoid any markup at all if we don't want to be really highlighting these values.
Change History (10)
#1
@
5 months ago
- Component Text Changes → Administration
- Keywords 2nd-opinion added
- Type defect (bug) → enhancement
- Version → 6.5
#2
@
5 months ago
- Keywords needs-patch good-first-bug added; 2nd-opinion removed
- Milestone Awaiting Review → 7.1
Thanks for the ticket! I think these can be changed back to <strong> now that × has been replaced with 'by' (as noted above).
This ticket was mentioned in PR #11166 on WordPress/wordpress-develop by @niravsherasiya7707.
5 months ago
#3
- Keywords has-patch added; needs-patch removed
Core trac : https://core.trac.wordpress.org/ticket/64792
#5
@
5 months ago
Tested.
In Appearance → Customize → Site Identity, the Site Icon help text displays the dimension values as regular text ("512 by 512 pixels") instead of using <code> styling. The change appears to be applied and the help text looks consistent.
Before Patch:
https://postimg.cc/ctSjJpv0
After Patch:
https://postimg.cc/G8YVdLhF
#6
@
4 months ago
- Keywords commit added
Thanks for ticket and PR!
After few releases we are back to use <strong>.
#7
@
4 months ago
- Keywords has-screenshots added
Test Report
Description
I've tested using WordPress Playground.
Test 1: Before
WordPress: 6.5
Observation: 512x512 Exists
Test 2: After
WordPress 7.0-beta2-20260305.063752
Observation: It's now updated as 512x512
I can confirm that the issue is resolved in the patch.
Screenshots added at the end.
Patch tested: https://github.com/WordPress/wordpress-develop/pull/11166
Environment
- WordPress: 7.0-beta2-20260305.063752
- PHP: 8.3.30
- Server: PHP.wasm
- Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
- Browser: Chrome 146.0.0.0
- OS: macOS
- Theme: Twenty Twenty-One 2.7
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.1
Actual Results
- ✅ Issue resolved with the patch.
Supplemental Artifacts
BEFORE
- PLACE ONE: https://prnt.sc/9bYJmSlsgPBA
- PLACE TWO: https://prnt.sc/7V5a1XUtz3ni
AFTER
- PLACE ONE: https://prnt.sc/VLaOi4cKykf5
- PLACE TWO: https://prnt.sc/imAl56RsBs2G
#8
@
3 months ago
Testing using WordPress Playground with PR #11166.
Environment:
- Tested via: WordPress Playground (https://playground.wordpress.net/?core-pr=11166)
- WordPress: trunk (7.0)
- PHP: 7.4.33
- Browser: Chrome
Test: Settings → General (options-general.php)
- Navigate to Settings > General
- Observe the Site Icon help text
Result: ✓ PASS
The dimension values 512 by 512 are now correctly rendered as bold (<strong>) instead of monospace code font (<code>). The help text reads cleanly: "It should be square and at least 512 by 512 pixels."
Note: WordPress 7.0 default block theme does not expose the classic Customizer, so class-wp-customize-manager.php change was verified via code review — the pattern is identical to the confirmed working change in options-general.php.
Overall: ✓ Issue resolved with the patch.
#9
@
3 months ago
Tested on Windows 11 using WordPress Studio with WordPress 6.9.4.
Reviewed the Site Icon help text under Settings > General.
The dimension values are displayed as regular text ("512 by 512 pixels"), which is clear and readable. The issue described in the ticket appears resolved.
No additional issues found during testing.
[57713] replaced
strongtags withcode, though that was before [58927] replaced×with 'by'.