Make WordPress Core

Opened 7 weeks ago

Last modified 3 days ago

#64792 new enhancement

Consider changing code tags to regular text for dimension values in "Site Icon" help text

Reported by: juanfra's profile juanfra Owned by:
Milestone: 7.1 Priority: normal
Severity: normal Version: 6.5
Component: Administration Keywords: good-first-bug has-patch commit has-screenshots
Focuses: Cc:

Description

The Site Icon help text uses <code> tags around dimension values, which is probably not needed given the context.

This shows up in two places (one and two). The dimensions are just regular measurements in help text, so they don't need the monospace treatment.

I'd propose to wrap them in <strong> if the objective is to add prominence. Or avoid any markup at all if we don't want to be really highlighting these values.

Change History (9)

#1 @sabernhardt
7 weeks ago

  • Component changed from Text Changes to Administration
  • Keywords 2nd-opinion added
  • Type changed from defect (bug) to enhancement
  • Version set to 6.5

[57713] replaced strong tags with code, though that was before [58927] replaced &times; with 'by'.

#2 @SergeyBiryukov
7 weeks ago

  • Keywords needs-patch good-first-bug added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 7.1

Thanks for the ticket! I think these can be changed back to <strong> now that &times; has been replaced with 'by' (as noted above).

This ticket was mentioned in PR #11166 on WordPress/wordpress-develop by @niravsherasiya7707.


7 weeks ago
#3

  • Keywords has-patch added; needs-patch removed

#4 @juanfra
7 weeks ago

Thank you, sounds good to me.

#5 @manhar
7 weeks ago

Tested.

In Appearance → Customize → Site Identity, the Site Icon help text displays the dimension values as regular text ("512 by 512 pixels") instead of using <code> styling. The change appears to be applied and the help text looks consistent.

Before Patch:
https://postimg.cc/ctSjJpv0

After Patch:
https://postimg.cc/G8YVdLhF

#6 @mukesh27
7 weeks ago

  • Keywords commit added

Thanks for ticket and PR!

After few releases we are back to use <strong>.

#7 @vgnavada
3 weeks ago

  • Keywords has-screenshots added

Test Report

Description

I've tested using WordPress Playground.

Test 1: Before
WordPress: 6.5
Observation: 512x512 Exists

Test 2: After
WordPress 7.0-beta2-20260305.063752
Observation: It's now updated as 512x512

I can confirm that the issue is resolved in the patch.

Screenshots added at the end.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/11166

Environment

  • WordPress: 7.0-beta2-20260305.063752
  • PHP: 8.3.30
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
  • Browser: Chrome 146.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-One 2.7
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1

Actual Results

  1. ✅ Issue resolved with the patch.

Supplemental Artifacts

BEFORE

AFTER

#8 @wpdevsxyz
6 days ago

Testing using WordPress Playground with PR #11166.

Environment:

Test: Settings → General (options-general.php)

  1. Navigate to Settings > General
  2. Observe the Site Icon help text

Result: ✓ PASS
The dimension values 512 by 512 are now correctly rendered as bold (<strong>) instead of monospace code font (<code>). The help text reads cleanly: "It should be square and at least 512 by 512 pixels."

Note: WordPress 7.0 default block theme does not expose the classic Customizer, so class-wp-customize-manager.php change was verified via code review — the pattern is identical to the confirmed working change in options-general.php.

Overall: ✓ Issue resolved with the patch.

#9 @kevinrobles
3 days ago

Tested on Windows 11 using WordPress Studio with WordPress 6.9.4.

Reviewed the Site Icon help text under Settings > General.

The dimension values are displayed as regular text ("512 by 512 pixels"), which is clear and readable. The issue described in the ticket appears resolved.

No additional issues found during testing.

Note: See TracTickets for help on using tickets.