WordPress.org
Get WordPress

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#64805 closed defect (bug) (fixed)

Admin Reskin: Dismissible notices should use different Dashicon close icon

Reported by: TobiasBg Owned by: audrasjb
Priority: normal Milestone: 7.0
Component: Administration Version: 7.0
Severity: normal Keywords: admin-reskin has-patch commit
Cc: Focuses:

Description (last modified by TobiasBg)

In #64548, admin notices were restyled to match the Gutenberg components more closely.

​@wordpress/components notices use an SVG icon looking like an x or cross, for dismissible notices.

The old notices (WP < 7.0) use an x in a circle, ​Dashicon dismiss/153.

The restyled notices should instead use ​Dashicon no-alt/335 which is closer to the @wordpress/components notices.

Screenshots attached.

Attachments (4)

1-wp-pre-70-notice.png​ (10.6 KB ) - added by TobiasBg 5 months ago.
Old dismissible notice.
2-wp-70-notice-current.png​ (10.6 KB ) - added by TobiasBg 5 months ago.
Current WP 7.0 notice.
3-wordpress-components-notice.png​ (8.8 KB ) - added by TobiasBg 5 months ago.
@wordpress/components notice.
4-wp-70-notice-suggested.png​ (9.9 KB ) - added by TobiasBg 5 months ago.
Suggested WP 7.0 notice icon.

Download all attachments as: .zip

Change History (16)

@TobiasBg
5 months ago

Old dismissible notice.

@TobiasBg
5 months ago

Current WP 7.0 notice.

@TobiasBg
5 months ago

@wordpress/components notice.

@TobiasBg
5 months ago

Suggested WP 7.0 notice icon.

#1 @TobiasBg
5 months ago

  • Description modified (diff)

#2 @mukesh27
5 months ago

  • Keywords needs-patch added
  • Version → trunk

Nice catch!

This ticket was mentioned in ​PR #11173 on ​WordPress/wordpress-develop by ​@niravsherasiya7707.
5 months ago #3

  • Keywords has-patch added; needs-patch removed

Core trac: https://core.trac.wordpress.org/ticket/64805

​@niravsherasiya7707 commented on ​PR #11173:
5 months ago #4

https://github.com/user-attachments/assets/7b4858dd-4a7c-4ca2-b196-7bed0f5828e7
Updated notice dismissal button icon.

​mathias7am commented on ​PR #11173:
5 months ago #5

Tested 'add user' functionality: correct dashicon is visible.

# Context

OS : Win11
Browser : Firefox
WP: 7.0-beta2-20260305.033903

https://github.com/user-attachments/assets/b19ff9f8-dd74-488d-a4e0-86b795df600b

#6 @noruzzaman
5 months ago

Test Report

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/11173

Environment

  • WordPress: 7.0-beta2-61809
  • PHP: 8.3.30
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
  • Browser: Chrome 145.0.0.0
  • OS: macOS
  • Theme: Twenty Fourteen 4.4
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1

Actual Results

  1. ✅ Issue resolved with patch.
Before After
https://i.ibb.co/SwLwwB2s/before.png https://i.ibb.co/ZpxGgRVP/after.png

​@shailu25 commented on ​PR #11173:
5 months ago #7

@mathias7am Could you Please Connect you WordPress.org account with github account?

​@shailu25 commented on ​PR #11173:
5 months ago #8

  • Dismiss icon is showing correct with this PR.
BeforeAfter
https://github.com/user-attachments/assets/0b299cc9-e33f-433f-bd65-fbd6110a0d30https://github.com/user-attachments/assets/d8cb14b1-8482-442b-b559-32674a9f887e

#9 @mukesh27
5 months ago

  • Keywords commit added

Thanks everyone for the contribution.

Marking this as ready for commit.

​@huzaifaalmesbah commented on ​PR #11173:
5 months ago #10

Before:
https://github.com/user-attachments/assets/8132b2a1-6c3d-4dea-b774-1681dca54a35

After:
https://github.com/user-attachments/assets/887495f0-de70-4144-9fad-252bd3a3b45d

#11 @audrasjb
5 months ago

  • Owner set to audrasjb
  • Status new → reviewing

Self assigning for final review and commit.

#12 @audrasjb
5 months ago

  • Resolution → fixed
  • Status reviewing → closed

In 61876:

Administration: Update Close icon for dismissible notices.

In #64548, admin notices were restyled to match Gutenberg components more closely. @wordpress/components notices use an SVG icon looking like an x, for dismissible notices. The old notices use an x in a circle, ​Dashicon dismiss/153.

With this changeset, the restyled notices now instead use ​Dashicon no-alt/335 which is closer to the @wordpress/components notices.

Follow-up to [61647], [61681].

Props TobiasBg, niravsherasiya7707, mathiaspeguet, noruzzaman, shailu25, mukesh27, huzaifaalmesbah.
Fixes #64805.
See #64548.

Note: See TracTickets for help on using tickets.