WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #6481, comment 53


Ignore:
Timestamp:
12/29/2014 03:54:29 PM (6 years ago)
Author:
ericlewis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6481, comment 53

    initial v1  
    22> My patch iterates on 6481.3.diff and removes the unnecessary `wp_install_verify_permalink_structure()` function and generally cleans things up a bit.
    33
    4 Hi valendesigns, thanks for your work here. However, cramming more lines into an already quite long function increases our code's complexity. Creating single responsibility functions keeps our code legible and less complex. We should probably have developer documentation for practices like these, we probably should.
     4Hi valendesigns, thanks for your work here. However, cramming more lines into an already quite long function increases our code's complexity. Creating single responsibility functions keeps our code legible and less complex. We should probably have developer documentation for practices like these.