Make WordPress Core

Opened 2 months ago

Closed 2 months ago

#64829 closed defect (bug) (fixed)

[Admin Reskin] Comment bubbles' background color still uses the old colors in hover state

Reported by: r1k0's profile r1k0 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-screenshots has-test-info admin-reskin has-patch
Focuses: ui, css Cc:

Description

When you inspect the comment bubbles' background color while in the hover/focus state, you can observe that they are still using the old colors.

Steps to Reproduce

  1. Head over to the Comments page.
  2. Hover the comment bubble and observe the background color (or inspect the bubble in hover state)

Screenshot

https://i.ibb.co/HpKHFzVY/comment-box-before.png

Change History (7)

This ticket was mentioned in PR #11207 on WordPress/wordpress-develop by @r1k0.


2 months ago
#1

  • Keywords has-patch added

I used #3858e9 to set the colors instead of var(--wp-admin-theme-color). This acts as <a> in that they don't change color, no matter the chosen admin color scheme.
If it needs to use the variable instead, let me know, and I will update accordingly.

Trac ticket: https://core.trac.wordpress.org/ticket/64829#ticket

## Use of AI Tools
None

This ticket was mentioned in PR #11210 on WordPress/wordpress-develop by @manishxdp.


2 months ago
#2

Use #3858e9 instead of #2271b1 for comment count bubble hover and focus

states so they match the Admin Reskin. Aligns with link color behavior.

Ticket track - https://core.trac.wordpress.org/ticket/64829

@mukesh27 commented on PR #11210:


2 months ago
#3

Duplicate of #11207

#4 @mukesh27
2 months ago

  • Keywords reporter-feedback added

Hi there!

Thanks for the ticket and PR!

What is reason behind choosing this color? Have you go though any design mock?

#5 @r1k0
2 months ago

  • Keywords reporter-feedback removed

I chose the color because it aligns with the existing WordPress admin default (Modern) color palette and it maintains consistency with other UI elements (see screenshot below).

This change was broadly based on WordPress design system and reflects the current WordPress admin design patterns as a whole.

https://i.ibb.co/WvMrknDS/different-colors.png

Version 0, edited 2 months ago by r1k0 (next)

#6 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 7.0

#7 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 61869:

Admin Reskin: Correct background color for comment count bubbles.

Props r1k0, mukesh27, manishxdp.
Fixes #64829.

Note: See TracTickets for help on using tickets.