WordPress.org
Get WordPress

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

#64851 closed defect (bug) (fixed)

Cleanup: remove unused variable $network_exists in populate_network() function

Reported by: soean's profile Soean Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 7.0 Priority: normal
Severity: normal Version: 4.9
Component: Networks and Sites Keywords: has-patch commit
Focuses: multisite Cc:

Description

The variable $network_exists in populate_network() was introduced in [41348], but never used. So we should remove it.

Change History (4)

This ticket was mentioned in ​PR #11238 on ​WordPress/wordpress-develop by ​@Soean.
2 months ago #1

  • Keywords has-patch added

This pull request makes a minor change to the populate_network function in src/wp-admin/includes/schema.php. The unused $network_exists variable has been removed to clean up the code.

Trac ticket: https://core.trac.wordpress.org/ticket/64851

#2 @mukesh27
2 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 7.0
  • Version set to 4.9

Nice catch!

Mark ready for commit.

#3 @johnjamesjacoby
2 months ago

  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

#4 @johnjamesjacoby
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 61992:

Networks and Sites: Remove unused variable in populate_networks().

This commit simply removes a $network_exists variable (introduced in r41384) that was never used.

Props mukesh27, Soean.

Fixes #64851.

Note: See TracTickets for help on using tickets.