Make WordPress Core

Opened 5 months ago

Closed 2 months ago

Last modified 2 months ago

#64877 closed defect (bug) (fixed)

Default site icon fallback still uses blue logo

Reported by: huzaifaalmesbah Owned by: sabernhardt
Priority: normal Milestone: 7.1
Component: General Version: 7.0
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Following 61989, which updated the login logo from blue to gray to match the refreshed design, the default site icon fallback still uses the old blue logo.

When no custom site icon is set, WordPress falls back to the blue logo in embeds and feeds. Updating this fallback to the gray logo would help maintain visual consistency with the updated WordPress design.

Change History (16)

This ticket was mentioned in PR #11283 on WordPress/wordpress-develop by @niravsherasiya7707.


5 months ago
#1

  • Keywords has-patch added

#2 @SergeyBiryukov
5 months ago

  • Milestone Awaiting Review7.0
  • Versiontrunk

@niravsherasiya7707 commented on PR #11283:


5 months ago
#3

@huzaifaalmesbah Umm, but it should match the new primary color right?

@nikunj8866 commented on PR #11283:


5 months ago
#4

@nirav7707 I agree with @huzaifaalmesbah. We should follow the existing WordPress core implementation and use the grey color, as seen on the login screen, to maintain consistency.

This ticket was mentioned in PR #11293 on WordPress/wordpress-develop by @sabernhardt.


5 months ago
#5

  • Adds a new gray logo in wp-includes/images. (I started with wp-admin/images/wordpress-logo-gray.svg, added a white background, and used Adobe Illustrator to save as PNG.)
  • Calls the new image in embed site title link and do_favicon() function.
  • Removes custom properties from embed CSS because the variables would not be defined.

Current blue logo
https://github.com/user-attachments/assets/fffb7b26-567e-4fbd-a625-f34e11412044

Gray logo
https://github.com/user-attachments/assets/315dd9b2-a61f-4602-abf3-03f235ffb148

Trac 64877

Use of AI Tools: none

#6 @sabernhardt
5 months ago

This is outside the scope of the admin redesign, but the fallback logo probably could be changed to gray anyway.

@niravsherasiya7707 commented on PR #11283:


5 months ago
#7

@huzaifaalmesbah @nikunj8866 The grey logo isn’t very visible. While it doesn’t directly impact accessibility, it requires extra effort to notice and could be improved for better visibility. What's your thought on this?
https://github.com/user-attachments/assets/6783e6b6-d0be-4b64-b126-59b06cef614e

@sabernhardt commented on PR #11283:


5 months ago
#8

The logo image needs a white background. See #11293.

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


5 months ago

#10 @joedolson
5 months ago

  • Milestone 7.07.1

#11 @audrasjb
3 months ago

Removing trunk version as this is not going to be shipped with WP 7.0 but in the next releases.

#12 @westonruter
2 months ago

  • Keywords needs-testing added
  • Owner set to sabernhardt
  • Status newassigned

#13 @jamesbregenzer
2 months ago

  • Keywords needs-testing removed

Tested locally using the wordpress-develop environment.

Before applying the patch, requests to /favicon.ico redirected to w-logo-blue-white-bg.png and the browser displayed the blue WordPress logo as the fallback site icon.

After applying the patch from PR 11293, requests to /favicon.ico redirected to w-logo-gray-white-bg.png and the browser displayed the updated gray logo.

Verified using Firefox Network Inspector and browser UI.

The patch appears to resolve the issue as described.

@westonruter commented on PR #11293:


2 months ago
#14

Before | After

--

https://github.com/user-attachments/assets/b6604d1a-690f-49b6-b387-2d4926c56510 | https://github.com/user-attachments/assets/204addd4-5cd0-4b28-8896-f08876bdc479
https://github.com/user-attachments/assets/b4822bde-62d5-40f7-a973-224c27df7671 | https://github.com/user-attachments/assets/46093181-f2f3-4048-920f-6dff8e76942a

#15 @westonruter
2 months ago

  • Resolutionfixed
  • Status assignedclosed

In 62521:

Embeds: Replace the blue site icon fallback with the gray WordPress logo.

Adds gray WordPress logo image files (w-logo-gray-white-bg.png and w-logo-gray-white-bg.svg) to wp-includes/images/, and updates the_embed_site_title() and do_favicon() to use the new images as the fallback site icon, maintaining visual consistency with the login screen logo updated in r61989.

Replaces CSS custom property references for focus styles in the embed template (--wp-admin-theme-color and --wp-admin-border-width-focus) with their literal values, as these admin-theme variables are not defined in the oEmbed template context.

Developed in https://github.com/WordPress/wordpress-develop/pull/11293.
Follow-up to r61652, r61989, r62502.

Props sabernhardt, huzaifaalmesbah, westonruter, jamesbregenzer.
See #64708.
Fixes #64877.

@westonruter commented on PR #11293:


2 months ago
#16

Committed in r62521 (c710ca6)

Note: See TracTickets for help on using tickets.