#6489 closed defect (bug) (fixed)
Revisions do not respect time zone offset
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 2.7.1 | Priority: | high |
Severity: | major | Version: | 2.5 |
Component: | Revisions | Keywords: | autosave revision timezone offset has-patch dev-feedback needs-testing |
Focuses: | Cc: |
Description
The timestamp on the autosave message doesn't include the time zone offset. The reported time is therefore confusing.
Attachments (3)
Change History (24)
#1
@
17 years ago
- Milestone 2.5.1 deleted
- Summary changed from Autosave does not respect time zone offset to sorry, forgot not to set that milestone!
#2
@
17 years ago
- Summary changed from sorry, forgot not to set that milestone! to Autosave does not respect time zone offset
#6
@
16 years ago
- Keywords revision timezone offset added
- Milestone changed from 2.9 to 2.7
- Priority changed from low to high
- Severity changed from minor to major
- Summary changed from Autosave does not respect time zone offset to Revisions do not respect time zone if offset differs between settings and server
It's not only autosave, the whole revision system uses server time zone for display.
I think that the severity is rather high, because it leads to using wrong versions or total confusion.
Basically it's borked at the point when the datetime of a revision is retrieved via GMT since it's then converted via date_i18n to TZ of the server. Additionally any TZ info of the original revision is lost (imagine you change TZ for daylight savings and then the math via GMT fails to show the original time the revision was saved.) There's AFAIK no reason not to use the actual date with offset info from the DB for displaying it.
Attaching patch, please review.
#9
@
16 years ago
- Keywords dev-feedback added
- Summary changed from Revisions do not respect time zone if offset differs between settings and server to Revisions do not respect time zone offset
#12
@
16 years ago
- Milestone 2.7 deleted
- Resolution set to worksforme
- Status changed from new to closed
Works for me... I'm seeing my offset correctly reflected. Reopen if still an issue in WP 2.7 final
#13
@
16 years ago
- Milestone set to 2.7
- Resolution worksforme deleted
- Status changed from closed to reopened
The bug is still present as of 2.7-RC1-10151 and 2.7-RC2.
Please make sure when tagging as worksforme that you have the same conditions/setup. This bug only occurs when user's local and server time zones differ, see comment:6 ...
I'm attaching a new combined patch which is quite self–explanatory and tested with various time zone combinations, I'd just appreciate some dev-feedback, otherwise it could be checked in.
#15
follow-up:
↓ 16
@
16 years ago
If I make the changes in the patches above, does this fix this bug?
#16
in reply to:
↑ 15
@
16 years ago
Replying to murky:
If I make the changes in the patches above, does this fix this bug?
Yes. Use the last patch: 6489-admin-ajax.php-post-template.php.diff
#17
follow-up:
↓ 18
@
16 years ago
Thanks, I asked as it wasn't marked as 'resolved' - and wondered if there was a little more to fix.
#18
in reply to:
↑ 17
@
16 years ago
Replying to murky:
as it wasn't marked as 'resolved'
It's just not marked as fixed since it's not checked in the trunk yet.
Yeah, I had this occur to me the other day and confused the hell outta me.