Revisions do not respect time zone offset

[sillybean]

The timestamp on the autosave message doesn't include the time zone offset. The reported time is therefore confusing.

[Viper007Bond]

Yeah, I had this occur to me the other day and confused the hell outta me.

[Viper007Bond]

Also see this dupe: #6563

[janbrasna]

It's not only autosave, the whole revision system uses server time zone for display.

I think that the severity is rather high, because it leads to using wrong versions or total confusion.

Basically it's borked at the point when the datetime of a revision is retrieved via GMT since it's then converted via date_i18n to TZ of the server. Additionally any TZ info of the original revision is lost (imagine you change TZ for daylight savings and then the math via GMT fails to show the original time the revision was saved.) There's AFAIK no reason not to use the actual date with offset info from the DB for displaying it.

Attaching patch, please review.

[janbrasna]

The same TZ issue is in the inline flash, see another patch.

[janbrasna]

Also see this dupe: #8307

[markjaquith]

Works for me... I'm seeing my offset correctly reflected. Reopen if still an issue in WP 2.7 final

[janbrasna]

The bug is still present as of 2.7-RC1-10151 and 2.7-RC2.

Please make sure when tagging as worksforme that you have the same conditions/setup. This bug only occurs when user's local and server time zones differ, see comment:6 ...

I'm attaching a new combined patch which is quite self–explanatory and tested with various time zone combinations, I'd just appreciate some dev-feedback, otherwise it could be checked in.

[janbrasna]

Fixes #6489, obsoletes previous patches.

[DD32]

Bumping to 2.7.1

[murky]

If I make the changes in the patches above, does this fix this bug?

[janbrasna]

Replying to murky:

If I make the changes in the patches above, does this fix this bug?

Yes. Use the last patch: 6489-admin-ajax.php-post-template.php.diff​

[murky]

Thanks, I asked as it wasn't marked as 'resolved' - and wondered if there was a little more to fix.

[janbrasna]

Replying to murky:

as it wasn't marked as 'resolved'

It's just not marked as fixed since it's not checked in the trunk yet.

[ryan]

(In [10490]) Respect time zone when displaying autosave and revision time. Props janbrasna, designsimply. fixes #8750 #6489 for trunk

[ryan]

(In [10491]) Respect time zone when displaying autosave and revision time. Props janbrasna, designsimply. fixes #8750 #6489 for 2.7