WordPress.org
Get WordPress

Make WordPress Core

Opened 8 weeks ago

Last modified 8 weeks ago

#64892 new enhancement

get_submit_button() should support "compact" button shorthand

Reported by: wildworks's profile wildworks Owned by:
Milestone: 7.1 Priority: normal
Severity: normal Version:
Component: General Keywords: admin-reskin has-patch
Focuses: Cc:

Description

[61645] introduced a new "compact" button size variation.

​https://github.com/WordPress/wordpress-develop/commit/7c9a0d6f3d37556711f2ed381ab00de6e7a4fc7f#diff-6ec764754195836e03cd6d3f98815ae0af68bc4dc01df0368a754f5ec877b348R74

However, this variation is not recognized as a shorthand in the get_submit_button() function.

I believe the compact shorthand should be supported, just like primary, small, and large.

​https://github.com/WordPress/wordpress-develop/blob/85cc3de8fafbe2b6ccd50dbbb628c6013bdc92f6/src/wp-admin/includes/template.php#L2607

Change History (2)

#1 @audrasjb
8 weeks ago

  • Milestone changed from Awaiting Review to 7.1

This ticket was mentioned in ​PR #11305 on ​WordPress/wordpress-develop by ​@niravsherasiya7707.
8 weeks ago #2

  • Keywords has-patch added

Core trac: https://core.trac.wordpress.org/ticket/64892

Test:
Large
https://github.com/user-attachments/assets/5690c7a2-62c1-49a6-9900-51951c45ce6a

Compact
https://github.com/user-attachments/assets/5f74296a-d6a1-4df7-af35-40775bda92f5

Small
https://github.com/user-attachments/assets/b2fc1017-a8f7-4342-bf30-c9ccd8f15b99

Note: See TracTickets for help on using tickets.