I18N string improvements for 7.1

[desrosj]

This ticket is for any string improvements that do not directly relate to specific tickets.

Previously:

• #64244 (7.0)
• #63629 (6.9)

This PR adds missing translator comments for translatable strings that include a trailing space after the colon, as part of the WordPress 7.1 I18N string improvements.

### Changes

• Added translator comment for the_tags() default prefix (Tags: ) in category-template.php.
• Added translator comments for trackback/pingback moderation email labels (Trackback excerpt: and Pingback excerpt: ) in wp_notify_moderator() within pluggable.php.

These follow the established pattern used in WP_PHPMailer (/* translators: There is a space after the colon. */) so translation tooling (WP-CLI i18n make-pot, Poedit) correctly preserves the trailing space for translators.

Thanks for the PR! In these instances, I think we can just move the space out of the translatable string.

Thanks for the PR! In these instances, I think we can just move the space out of the translatable string.

Thanks for the review, @SergeyBiryukov ! Updated the PR to move the trailing spaces out of the translatable strings in the_tags() and wp_notify_moderator() instead of adding translator comments.

This implementation works, but I would personally rather do this with a placeholder:
sprintf( __( 'The string: %s' ), $the_variable )

[adrianduffell]

It looks like this work is close. Can we get it over the line before RC 1 next week?

On the placeholder suggestion, for the two wp_notify_moderator() strings it does look like the better fit. The default case of the same switch, and all three cases in wp_notify_postauthor(), already use sprintf( __( 'Comment: %s' ), "\r\n" . $comment_content ), so sprintf( __( 'Trackback excerpt: %s' ), "\r\n" . $comment_content ) would match what's already there.

For the_tags() I'm not sure it applies, since $before is just a default passed to get_the_tag_list(), so there's no variable to interpolate. Moving the space out seems consistent with r44797 and with the guideline against trailing whitespace in translatable strings.

On translations, Tags: already exists as a translated admin string, and the excerpt strings change msgid under any of the approaches proposed here, so landing before the 7.1 string freeze seems like the right timing either way.

[SergeyBiryukov]

In 63030:

I18N: Move trailing spaces out of translatable strings.

Follow-up to [6873], [10888], [31059].

Props khokansardar, jorbin, audrasjb, rcorrales, SergeyBiryukov.
See #64899.

[obenland]

@SergeyBiryukov Do the $notify_message placeholders need translator comments?

@itzmekhokan could you check the open Copilot Feedback and the ones from @rbcorrales / @audrasjb ?
Will be reconsidered for 7.2 as we're too close to the 7.1 RC deadline / string freeze

[masteradhoc]

We'll have to punt this ticket to 7.2 as the RC1 for 7.1 is happening now.

[sabernhardt]

Either this needs a follow-up commit for the translator comments or it can be closed as fixed.

[joedolson]

String changes are closed for 7.1, so closing this ticket and creating the follow up.

[SergeyBiryukov]

Replying to obenland:

Do the $notify_message placeholders need translator comments?

Ah yes, thanks!

Reopening, as adding translator comments does not affect the string freeze.

Trac ticket: https://core.trac.wordpress.org/ticket/64899

Thanks for the PR! Merged in r63030.

[wildworks]

In 63204:

I18N: Add translator comments in wp_notify_moderator().

The trackback and pingback excerpt lines in the comment moderation notification email now document their placeholder for translators.

Follow-up to [63030].

Props obenland, SergeyBiryukov, wildworks.
See #64899.

[wildworks]

Reopening #64899 to request backporting [63204] to 7.1 branch.

We should be able to close this ticket once the backport is complete.

[joedolson]

Approved for backport to 7.1

[joedolson]

In 63232:

I18N: Add translator comments in wp_notify_moderator().

The trackback and pingback excerpt lines in the comment moderation notification email now document their placeholder for translators.

Follow-up to [63030].

Reviewed by joedolson.
Merges [63204] to the 7.1 branch.

Props obenland, SergeyBiryukov, wildworks.
See #64899.

[wildworks]

Can we close this ticket now?

[desrosj]

It looks like all remaining issues on this PR have been resolved. Going to close out.

#65859 has been opened for the 7.2 release cycle.

Committed in r63204.