Make WordPress Core

Opened 8 weeks ago

Last modified 2 weeks ago

#64927 new defect (bug)

.media-upload-form .media-item min-height is causing a visual glitch

Reported by: presskopp's profile Presskopp Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Media Keywords: has-screenshots has-patch
Focuses: ui Cc:

Description

uploading a file that exceeds the maximum upload size an error will be shown, but it's height is too large.

The minimum height of 70px has been introduced with
https://github.com/WordPress/wordpress-develop/commit/ba7684417ae86fafde7907fdb78ddb49e89309da

It might serve it's purpose, but not when showing the error message.

Attachments (2)

maximum-before.png (75.9 KB) - added by Presskopp 8 weeks ago.
maximum-after.png (73.2 KB) - added by Presskopp 8 weeks ago.

Download all attachments as: .zip

Change History (6)

#1 @shreyasikhar26
2 weeks ago

I am not able to reproduce this issue, can you please check once again.

If you are still able to reproduce it, can you please mention the exact steps. Also, please make sure to use default theme and no plugins active while reproducing the issue.

#2 @Presskopp
2 weeks ago

Hi @shreyasikhar26 , I'm using 7.0-RC2-62242, PHP 8.5.1 and it's easy to reproduce there

Last edited 2 weeks ago by Presskopp (previous) (diff)

This ticket was mentioned in PR #11683 on WordPress/wordpress-develop by @hbhalodia.


2 weeks ago
#3

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/64927

## Screenshots or screencast

BeforeAfter
https://github.com/user-attachments/assets/098ec9e0-d822-4054-82d5-38e2d6bc431e https://github.com/user-attachments/assets/3d336565-e3aa-468b-9b17-dfe220289319

## Use of AI Tools

  • None

#4 @hbhalodia
2 weeks ago

Hi @Presskopp @shreyasikhar26, I am able to reproduce the issue. There is a min-height added to the .media-upload-form .media-item class and seems to be redundant. The message will take the height as expected instead of setting it a fix value.

I have raised the PR to fix the same remove the extra spacing.

Note: See TracTickets for help on using tickets.