Real Tine Collaboration: related editor settings are still rendered when RTC is disabled

[afercia]

I couldn't find an existing ticket about this. I'm not sure whether this is a known issue and there's already a plan to fix it. I'd think it's important enough to be considered for the 7.0 release.

Real Time Collaboration (RTC) is now opt-in and disabled by default.

As such, I would expect any settings, preferences, etc. that are related to RTC to not show up in the UI, as they don't do anything. They are misleading.

A good UI should not show settings that don't do anything.

To reproduce:

• Go to WP Admin > Settings > Writing
• Make sure 'Enable early access to real-time collaboration...' is unchecked.
• Edit a post.
• Go to Options > Preferences, to open the Preferences modal dialog.
• In the default 'General' tabpanel, observe the two RTC related settings are still rendered:
  • Show avatar in blocks
  • Show collaboration notifications

To my understanding, showCollaborationCursor and showCollaborationNotifications controls are rendered unconditionally. They should be rendered depending on whether RTC is enabled or not.

I haven't been following the 7.0 development closely so I may be missing something but I would suggest to double check whether there are more setting, preferences and the like that depends on whether RTC is enabled or not.

Settiny against the 7.0 milestone for consideration.

[afercia]

Note: I took the second screenshot when RTC was enabled, but that's not relevant, the settings are still shown when it is disabled.

[afercia]

The preferences modal dialog with RTC disabled.

[wildworks]

Thanks for the report. I think your suggestion makes sense.

I submitted ​https://github.com/WordPress/gutenberg/pull/76819 to conditionally render the RTC-related setting based on the setting.

[wildworks]

Fixed on upstream and cherry-picked into wp/7.0.

​https://github.com/WordPress/gutenberg/pull/76819#issuecomment-4131534561

[afercia]

Thanks Aki, super quick fix.