Make WordPress Core

Opened 5 months ago

Closed 12 days ago

#64953 closed defect (bug) (fixed)

The login page still shows the old color for the “← Go to [Website Name]” link.

Reported by: sumitsingh Owned by: wildworks
Priority: normal Milestone: 7.1
Component: Login and Registration Version: 7.0
Severity: normal Keywords: has-screenshots has-patch has-test-info
Cc: Focuses: ui, css, administration

Description

Issue: The “← Go to [site name]” link on the login page is still using the old color and does not match the updated styling.

Attachments (15)

f736c2a1-212f-4e24-ac85-152975bae7b6.png (29.4 KB ) - added by sumitsingh 5 months ago.
screenshot 1 with focus link
4698007a-fdb1-443e-b50c-76150d956364.png (29.3 KB ) - added by sumitsingh 5 months ago.
screenshot 1 with old color link
image-03-26-2026_11_18_AM.png (59.5 KB ) - added by sumitsingh 5 months ago.
Here also old color for "Get support for resetting your password." link on focus
image-03-26-2026_11_37_AM.png (71.1 KB ) - added by sumitsingh 5 months ago.
Hover on still old color for Upload files and Media Library tabs
image-03-26-2026_11_38_AM.png (63.1 KB ) - added by sumitsingh 5 months ago.
Drop to upload file overlay color aslo old one
image-03-26-2026_12_02_PM.png (258.6 KB ) - added by sumitsingh 5 months ago.
hover in old color on login and registration
Screenshot from 2026-03-26 13-43-29.png (306.6 KB ) - added by nimeshatxecurify 5 months ago.
WordPress Playground test with trunk
Before apply.webp (8.6 KB ) - added by softglaze 2 weeks ago.
Befroe apply.webp (9.3 KB ) - added by softglaze 2 weeks ago.
Before apply.2.webp (8.6 KB ) - added by softglaze 2 weeks ago.
before apply 3.webp (40.5 KB ) - added by softglaze 2 weeks ago.
After Apply.webp (43.5 KB ) - added by softglaze 2 weeks ago.
After apply(2).webp (46.4 KB ) - added by softglaze 2 weeks ago.
before-patch.png (49.5 KB ) - added by shailu25 2 weeks ago.
Before Patch
after-patch.png (54.7 KB ) - added by shailu25 2 weeks ago.
After Patch

Download all attachments as: .zip

Change History (45)

@sumitsingh
5 months ago

screenshot 1 with focus link

@sumitsingh
5 months ago

screenshot 1 with old color link

@sumitsingh
5 months ago

Here also old color for "Get support for resetting your password." link on focus

#1 @gautammkgarg
5 months ago

Facing same issue

PHP: 8.5
WordPress Version: 7.0-RC1

@sumitsingh
5 months ago

Hover on still old color for Upload files and Media Library tabs

@sumitsingh
5 months ago

Drop to upload file overlay color aslo old one

#2 @huzaifaalmesbah
5 months ago

Have you tested login page hover issue on RC1 or trunk?

This issue was fixed after RC1: changeset:62113 could you check on trunk and confirm if it still occurs?

#3 @sumitsingh
5 months ago

Hey @huzaifaalmesbah, I have checked before this ticket but still I can see with the latest "Currently your site is set to update to version 7.0-RC1-62113. " and it seems it still has the old color in some class. For more information you can see the last screenhsot

It's an issue still in focus mode.

.login #backtoblog a:focus, .login #nav a:focus, .login h1 a:focus {
    color: #043959; // old color code on focus
}
Last edited 5 months ago by sumitsingh (previous) (diff)

@sumitsingh
5 months ago

hover in old color on login and registration

@nimeshatxecurify
5 months ago

WordPress Playground test with trunk

#4 follow-up: @wildworks
5 months ago

We have only updated the hover state color. I believe the focus color also needs to be addressed in this ticket.

This ticket was mentioned in Slack in #core by sumitsingh. View the logs.


5 months ago

This ticket was mentioned in PR #11375 on WordPress/wordpress-develop by @opurockey.


4 months ago
#6

  • Keywords has-patch added

Ticket: https://core.trac.wordpress.org/ticket/64953

## Description:

This PR updates the color usage in media-view.css to align with the modern WordPress admin color system by replacing hardcoded/legacy color values with standardized admin color variables.

As part of ongoing efforts in WordPress core to reduce color inconsistencies and adopt a unified color palette using CSS custom properties, admin styles are being refactored to use semantic color tokens instead of fixed values.

## Changes Made:

  • Replaced legacy color values used in: :hover :focus
  • interactive states and UI elements
  • Updated styles to use: WP admin color variables (e.g. --wp-admin-theme-color, --wp-admin-theme-color-darker-*, etc.)
  • Removed outdated or hardcoded hex values to ensure consistency with the admin color system

## Why This Change:

  • Ensures visual consistency across WordPress admin UI
  • Improves maintainability by centralizing color definitions
  • Aligns with WordPress core direction of using CSS custom properties for theming and extensibility
  • Improves compatibility with different admin color schemes and future design updates

## Impact:

  • No functional changes
  • Purely visual/style refactor
  • Affects only media-view components in admin
  • Better integration with admin color schemes-

## Testing Instructions:

  • Open Media Library (Grid and List view)
  • Hover and focus on: Media items Buttons and controls
  • Verify: Colors match WP admin theme, No regressions in hover/focus states
  • Test across different admin color schemes

## Screenshot:

https://github.com/user-attachments/assets/1dc6b763-2b83-4e38-bfd2-4f1f32d951e3

@wildworks commented on PR #11375:


4 months ago
#7

@OpuRockey Thanks for the PR! However, This PR appears to modify components that are completely unrelated to ticket 64953. Could you clarify which ticket this PR is intended to resolve?

@opurockey commented on PR #11375:


4 months ago
#8

@t-hamano , This PR is actually related to comments mentioned is this ticket.

https://github.com/user-attachments/assets/53192b20-77ef-4155-a14b-dfc2ae47799e
https://github.com/user-attachments/assets/dfcf7ce1-77eb-40ed-b779-03ba8d0ac182

Would you like me to create seperate ticket or this?

@wildworks commented on PR #11375:


4 months ago
#9

Would you like me to create seperate ticket or this?

I think so. I don't think unrelated components should be handled in a single ticket.

@opurockey commented on PR #11375:


4 months ago
#10

@t-hamano , Created a seperate ticket for this.

@wildworks commented on PR #11375:


4 months ago
#11

Closing this PR in favor of #11409

#12 @audrasjb
3 months ago

Removing trunk version as this is not going to be shipped with WP 7.0 but in the next releases.

#13 @audrasjb
3 months ago

  • Version trunk

#14 in reply to: ↑ 4 @nimeshatxecurify
4 weeks ago

Replying to wildworks:

We have only updated the hover state color. I believe the focus color also needs to be addressed in this ticket.

This is actually valid. Can we mark this for 7.1?

#15 @nimeshatxecurify
4 weeks ago

  • Keywords needs-patch added; has-patch removed

#16 @nimeshatxecurify
4 weeks ago

  • Milestone Awaiting Review7.1
  • Version7.0

This ticket was mentioned in PR #12593 on WordPress/wordpress-develop by hasnain-poxito.


3 weeks ago
#17

  • Keywords has-patch added; needs-patch removed

## Summary

Fixes the focus color on login page links (← Go to [Site Name], Lost your password?, and the WP logo link) which were still using the old hardcoded color #043959 instead of the updated admin theme color variable.

  • Replaces #043959 with var(--wp-admin-theme-color-darker-20) in the a:focus rule
  • Replaces #043959 with var(--wp-admin-theme-color-darker-20) in the .login #nav a:focus, .login #backtoblog a:focus, .login h1 a:focus rule

The hover state for these same selectors already correctly uses var(--wp-admin-theme-color-darker-20) — this change makes focus consistent with hover.

## Trac Ticket

https://core.trac.wordpress.org/ticket/64953

## Test Plan

  • [ ] Go to /wp-login.php
  • [ ] Tab through the links: Lost your password? and ← Go to [Site Name]
  • [ ] Confirm the focused link color matches the hover color (blue, matching the admin theme)
  • [ ] Test with different admin color schemes (Modern, Light, etc.) — color should adapt via CSS variable
  • [ ] Confirm no regressions on other login page states

hasnain-poxito commented on PR #12593:


3 weeks ago
#18

Closing to reopen from the correct GitHub account.

This ticket was mentioned in PR #12594 on WordPress/wordpress-develop by @hasnainashfaq.


3 weeks ago
#19

## Summary

Fixes the focus color on login page links (← Go to [Site Name], Lost your password?, and the WP logo link) which were still using the old hardcoded color #043959 instead of the updated admin theme color variable.

  • Replaces #043959 with var(--wp-admin-theme-color-darker-20) in the a:focus rule
  • Replaces #043959 with var(--wp-admin-theme-color-darker-20) in the .login #nav a:focus, .login #backtoblog a:focus, .login h1 a:focus rule

The hover state for these same selectors already correctly uses var(--wp-admin-theme-color-darker-20) — this change makes focus consistent with hover.

## Trac Ticket

https://core.trac.wordpress.org/ticket/64953

## Test Plan

  • [ ] Go to /wp-login.php
  • [ ] Tab through the links: Lost your password? and ← Go to [Site Name]
  • [ ] Confirm the focused link color matches the hover color (blue, matching the admin theme)
  • [ ] Test with different admin color schemes (Modern, Light, etc.) — color should adapt via CSS variable
  • [ ] Confirm no regressions on other login page states

@nimeshatxecurify commented on PR #12594:


3 weeks ago
#21

Thanks for the PR @HasnainAshfaq!

Could you also attach some screenshots in the PR, including before and after pics?

@hasnainashfaq commented on PR #12594:


3 weeks ago
#22

Thanks for the PR @HasnainAshfaq!

Could you also attach some screenshots in the PR, including before and after pics?

Thanks for the review @nimesh-xecurify! Here are the before and after screenshots:

Before (unfixed - focus color is hardcoded #043959, dark teal):

https://github.com/user-attachments/assets/c0cfb45f-c318-4e4b-aa76-ee15691e116e

 

After (fixed - focus color uses var(--wp-admin-theme-color-darker-20), consistent with hover):
 

https://github.com/user-attachments/assets/ab61da92-70eb-45ee-b715-2694c83c5e13
 

The change ensures the focus state matches the hover state and adapts correctly to all admin color schemes.

#23 @nimeshatxecurify
3 weeks ago

  • Keywords needs-testing added

#24 @softglaze
2 weeks ago

Tested PR 12594 and can confirm it fixes the focus color.

Environment: Windows host, wordpress-develop Docker environment, Chrome (cache disabled via DevTools), 7.1-alpha trunk, npm run build:dev run before each test.

Before (trunk): tabbing to "Lost your password?" and "← Go to [Site Name]" applies color: #043959 from the .login #nav a:focus, .login #backtoblog a:focus, .login h1 a:focus rule in login.css — see the "Before apply" attachments, including DevTools showing the rule.


After (PR 12594 applied + rebuild): the same rule now applies var(--wp-admin-theme-color-darker-20), making the focus state consistent with hover — see the "After Apply" attachments.


Hover state unchanged; no other visual changes observed on the login screen. Tests well — ready for review.

This ticket was mentioned in Slack in #core-test by softglaze. View the logs.


2 weeks ago

#26 @vedantere
2 weeks ago

Patch tested: PR #12594 (Login: Replace hardcoded focus color with CSS variable), open, not yet merged.

Environment: macOS, Local by Flywheel, WordPress 7.0.2, PHP 8.5.6, SCRIPT_DEBUG off (so the minified CSS is what's actually served)
Before (unpatched):

a:focus computed color: rgb(4, 57, 89) (#043959, the old hardcoded color)
.login #backtoblog a:focus / #nav a:focus / h1 a:focus: same rgb(4, 57, 89)
Hover color for comparison: rgb(24, 58, 214) (the theme color)
Confirms the bug: focus and hover colors don't match.
After (patch applied):

All three focus rules now compute to rgb(24, 58, 214) — matching hover exactly.
Verified visually too (screenshots of both "← Go to [Site]" and "Lost your password?" focus states) and via the browser's computed style, not just eyeballing it.

#27 @nimeshatxecurify
2 weeks ago

  • Keywords has-test-info added; needs-testing removed

#28 @shailu25
2 weeks ago

Test Report

This Report Validates that the indicated patch address the issue.✅

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/12594

Environment:

WordPress - 7.1-alpha-20260714.050628
OS - Windows
Browser - Chrome
Theme: Twenty Twenty Five
PHP - 7.4.33
Plugin - None

Actual Results:

  • Issue Resolved with Patch ✅

Supplemental Artifacts

  • Attached

@shailu25
2 weeks ago

Before Patch

@shailu25
2 weeks ago

After Patch

#29 @wildworks
12 days ago

PR 12594 looks ready to be merged. I plan to review and commit it later.

#30 @wildworks
12 days ago

  • Owner set to wildworks
  • Resolutionfixed
  • Status newclosed

In 62865:

Login and Registration: Correct focus color for links.

The hover color for links on the login screen was updated to use the admin color scheme CSS variables, but the focus color was left hardcoded. Update the focus color to use the same variable, so it matches hover and follows the selected admin color scheme.

Follow-up to [61681], [62113].

Props dhruvang21, hasnainashfaq, nimeshatxecurify, shailu25, softglaze, sumitsingh, vedantere, wildworks.
Fixes #64953.

Note: See TracTickets for help on using tickets.