#64968 closed task (blessed) (fixed)
Update/Audit NPM Dependencies for 7.1
| Reported by: | desrosj | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.1 |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
Previously:
- #64230 (7.0)
- #63171 (6.9)
- #62220 (6.8)
- #62137 (6.7)
- #61498 (6.6)
- #59658 (6.5)
- #58863 (6.4)
- #57657 (6.3)
- #57535 (6.2)
- #56641 (6.1)
- #54727 (6.0)
- #53361 (5.9)
- #52624 (5.8)
- #51801 (5.7)
- #50769 (5.6)
- #49768 (5.5)
- #49547 (5.4)
- #48203 (5.3)
- #46039 (5.1)
- #45064 (5.0)
- #38199 (4.7)
- #36520 (4.6)
- #35104 (4.5)
- #34177 (4.4)
- #31700 (4.3)
- #31489 (4.2)
- #30141 (4.1)
- #27340 (4.0)
- #26073 (3.9)
Change History (19)
This ticket was mentioned in PR #11954 on WordPress/wordpress-develop by @khokansardar.
6 months ago
#1
- Keywords has-patch added
#3
@
4 months ago
Theme packages:
| Package | Version in themes | Latest version | Themes |
|---|---|---|---|
@wordpress/browserslist-config | ^6.34.0 | 6.51.0 | T19, T20, T21, T22, T25 |
@wordpress/eslint-plugin | ^22.20.0 | 25.7.0 | T21 |
@wordpress/scripts | ^30.27.0 | 33.0.0 | T20 |
@wordpress/stylelint-config | ^21.30.0 | 24.0.0 | T21 |
autoprefixer | ^10.4.22 | 10.5.3 | T19, T20, T21 |
chokidar-cli | ^3.0.0 | no change | T19, T21 |
concurrently | ^9.2.1 | 10.0.3 | T20 |
cssnano | ^7.1.2 | 7.1.9 | T22, T25 |
eslint | ^8.57.1 | 10.7.0 | T21 |
minimist | ^1.2.8 | no change | T21 |
node-sass | ^9.0.0 | deprecated | T19 |
npm-run-all | ^4.1.5 | no change | T19, T21 |
postcss | ^8.5.6 | 8.5.19 | T19, T20, T21, T22, T25 |
postcss-calc | ^10.1.1 | no change | T21 |
postcss-cli | ^11.0.1 | no change | T19, T20, T21, T22, T25 |
postcss-css-variables | ^0.19.0 | no change | T21 |
postcss-custom-media | ^11.0.6 | 12.0.1 | T21 |
postcss-discard-duplicates | ^7.0.2 | 8.0.1 | T21 |
postcss-discard-empty | ^7.0.1 | 8.0.1 | T21 |
postcss-focus-within | ^9.0.1 | 10.0.0 | T19, T21 |
postcss-merge-rules | ^7.0.7 | 8.0.1 | T21 |
postcss-nested | ^7.0.2 | no change | T21 |
rtlcss | ^4.3.0 | no change | T19, T20, T21 |
sass | ^1.83.0 | 1.101.0 | T21 |
stylelint | ^14.16.1 | 17.14.0 | T21 |
stylelint-a11y | ^1.2.3 | no change | T20 |
stylelint-config-recommended-scss | ^16.0.2 | 17.0.1 | T21 |
Twenty Twenty-Five and Twenty Twenty-Two have 3 updates available, and I think those two themes should be updated.
"devDependencies": { - "@wordpress/browserslist-config": "^6.34.0", - "postcss": "^8.5.6", + "@wordpress/browserslist-config": "^6.51.0", + "postcss": "^8.5.19", "postcss-cli": "^11.0.1", - "cssnano": "^7.1.2" + "cssnano": "^7.1.9" },
Twenty Twenty-One has 14 updates available.
"devDependencies": { - "@wordpress/browserslist-config": "^6.34.0", - "@wordpress/eslint-plugin": "^22.20.0", - "@wordpress/stylelint-config": "^21.30.0", - "autoprefixer": "^10.4.22", + "@wordpress/browserslist-config": "^6.51.0", + "@wordpress/eslint-plugin": "^25.7.0", + "@wordpress/stylelint-config": "^24.0.0", + "autoprefixer": "^10.5.3", "chokidar-cli": "^3.0.0", - "eslint": "^8.57.1", + "eslint": "^10.7.0", "minimist": "^1.2.8", "npm-run-all": "^4.1.5", - "postcss": "^8.5.6", + "postcss": "^8.5.19", "postcss-calc": "^10.1.1", "postcss-cli": "^11.0.1", "postcss-css-variables": "^0.19.0", - "postcss-custom-media": "^11.0.6", - "postcss-discard-duplicates": "^7.0.2", - "postcss-discard-empty": "^7.0.1", - "postcss-focus-within": "^9.0.1", - "postcss-merge-rules": "^7.0.7", + "postcss-custom-media": "^12.0.1", + "postcss-discard-duplicates": "^8.0.1", + "postcss-discard-empty": "^8.0.1", + "postcss-focus-within": "^10.0.0", + "postcss-merge-rules": "^8.0.1", "postcss-nested": "^7.0.2", "rtlcss": "^4.3.0", - "sass": "^1.83.0", - "stylelint": "^14.16.1", - "stylelint-config-recommended-scss": "^16.0.2" + "sass": "^1.101.0", + "stylelint": "^17.14.0", + "stylelint-config-recommended-scss": "^17.0.1" },
Twenty Twenty has 5 updates available.
"devDependencies": { - "@wordpress/browserslist-config": "^6.34.0", - "@wordpress/scripts": "^30.27.0", - "autoprefixer": "^10.4.22", - "concurrently": "^9.2.1", - "postcss": "^8.5.6", + "@wordpress/browserslist-config": "^6.51.0", + "@wordpress/scripts": "^33.0.0", + "autoprefixer": "^10.5.3", + "concurrently": "^10.0.3", + "postcss": "^8.5.19", "postcss-cli": "^11.0.1",
Twenty Nineteen has 4 updates available. However, I'm not sure it would be worth updating three or four of the packages when the theme still has node-sass (#63013) and might remove postcss-focus-within (#46976).
| Package | Version in theme | Latest version |
|---|---|---|
@wordpress/browserslist-config | ^6.34.0 | 6.51.0
|
autoprefixer | ^10.4.22 | 10.5.3
|
postcss | ^8.5.6 | 8.5.19
|
postcss-focus-within | ^9.0.1 | 10.0.0
|
This ticket was mentioned in PR #12826 on WordPress/wordpress-develop by @sabernhardt.
4 months ago
#4
Updates 3 dependencies in Twenty Twenty-Two and Twenty Twenty-Five:
@wordpress/browserslist-configfrom6.34.0to6.52.0cssnanofrom7.1.2to8.0.2postcssfrom8.5.6to8.5.25
I ran the following commands in both src\wp-content\themes\twentytwentytwo and src\wp-content\themes\twentytwentyfive:
npm installnpm audit fixnpm dedupenpm run build
Props: aakashverma1
Use of AI Tools: none by me
This ticket was mentioned in PR #12861 on WordPress/wordpress-develop by @desrosj.
3 months ago
#5
Updates all devDependency-ies to their latest versions and runs npm audit fix.
Updates are as follows:
@playwright/testfrom1.61.1to1.62.1@types/codemirrorfrom5.60.17to5.60.18@wordpress/e2e-test-utils-playwrightfrom1.51.0to1.52.0@wordpress/prettier-configfrom4.51.0to4.52.0@wordpress/scriptsfrom33.0.0to34.0.0autoprefixerfrom10.5.3to10.5.4gruntfrom1.6.2to1.6.3postcssfrom8.5.19to8.5.25sassfrom1.101.0to1.102.0wait-onfrom9.0.10to9.1.0webpackfrom5.108.4to5.109.2
Trac ticket: Core-64968.
## Use of AI Tools
None
@desrosj commented on PR #12861:
3 months ago
#6
There's a few issues to look into before this can be committed.
- I've been seeing some
webpack-related failures locally. This needs to be properly investigated. - There are CSS changes that result in the built CSS files. They seem related to the changes in `1.101.4` for the `sass` dependency.
#7
@
3 months ago
I briefly chatted with @sabernhardt today in Slack and I think that it's desirable and acceptable for the dependency updates in the default themes to be committed after the RC1 point of the release cycle.
Since branching is delayed until RC2 next week, I've also opened one more PR to update devDependencies in trunk before branching.
#8
@
3 months ago
Thank you for your work on this. A final RC for 7.1 will be released tomorrow. Are there any tasks that need to be addressed before then?
@wildworks commented on PR #11954:
3 months ago
#9
Closing this in favor of #12861
@wildworks commented on PR #11523:
3 months ago
#10
@wildworks commented on PR #12826:
3 months ago
#11
Thanks for the PR. I have two concerns regarding this PR.
As Copilot pointed out, cssnano8 requires Node.js 22 or higher, so we need to decide how to address this.
We either need to require Node 22 or above, or downgrade the version of cssnano slightly. As far as I've researched, there are no default themes that require Node 22 or above yet.
@desrosj commented on PR #12826:
3 months ago
#12
Thanks for the PR. I have two concerns regarding this PR.
As Copilot pointed out, cssnano8 requires Node.js 22 or higher, so we need to decide how to address this.
We either need to require Node 22 or above, or downgrade the version of
cssnanoslightly. As far as I've researched, there are no default themes that require Node 22 or above yet.
The current plan is to update wordpress-develop/gutenberg to 24.x after the 7.1 release. See Core-65451, https://github.com/WordPress/gutenberg/issues/72973.
#13
@
3 months ago
- Resolution → fixed
- Status new → closed
While it would be nice to have packages as up to date as possible when each release is finished, we've run out of time to consider further changes.
I'm going to close this out.
I've created #65857 for the 7.2 release and will change the Trac ticket references on the remaining open PRs to point to that one.
@sabernhardt commented on PR #12826:
3 months ago
#14
In case these themes are updated sooner than WordPress 7.2, I accepted the change to cssnano 7.1.9 and reran the four commands to update package.lock.
However, if the next update is with WordPress 7.2 or later, this pull request probably should be closed and replaced with one that includes other themes.
@wildworks commented on PR #12826:
3 months ago
#15
I don't have a strong opinion, but if we are updating the Node version to 24.x in the 7.2 release, we could consider updating the default theme afterwards.
@mukesh27 commented on PR #12826:
2 months ago
#16
@sabernhardt Since WordPress set Node 24 in https://github.com/WordPress/wordpress-develop/commit/62439bbb0ae8dc2e73f32bd42372a356e8ea55c1, could you please rebase your PR and update the Trac ticket for 7.2?
@mukesh27 commented on PR #12861:
2 months ago
#17
@desrosj Can you make this ready for 7.2? As it's not committed in 7.1.
@sabernhardt commented on PR #12826:
7 weeks ago
#18
This PR was designed for the 7.1 branch, so I'll just close it. A new patch can be created in November, likely for more themes.
@desrosj commented on PR #12861:
15 hours ago
#19
Merged in r65557.
This updates the following
devDependenciesfor WP 7.1:@playwright/test@wordpress/e2e-test-utils-playwright@wordpress/prettier-config@wordpress/scriptsautoprefixercssnanodotenvgruntgrunt-legacy-utilphp-array-readerpostcssreact-refreshsassterser-webpack-pluginwait-onwebpackAdditionally,
npm audit fixandnpm dedupehave been run.