Opened 6 weeks ago
Closed 4 days ago
#64980 closed defect (bug) (fixed)
Notes needs gettext
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 7.0 | Priority: | normal |
| Severity: | normal | Version: | trunk |
| Component: | I18N | Keywords: | has-patch i18n-change dev-reviewed commit fixed-major |
| Focuses: | Cc: |
Description
Notes is used for 2 different functions. Link notes and notes in the editor.
"Notiz" and "Anmerkungen" in German
Change History (13)
#3
@
6 weeks ago
- Keywords needs-patch added
To be clear, what is needed here is a context for translators, using the _x() function.
See https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#disambiguation-by-context
This ticket was mentioned in PR #11402 on WordPress/wordpress-develop by @sanket.parmar.
6 weeks ago
#4
- Keywords has-patch added; needs-patch removed
## Summary
Fixes a translation ambiguity where the string "Notes" is used in two distinct UI contexts with different meanings, causing conflicts for translators (e.g. German requires "Anmerkungen" for the Link Manager field vs. "Notiz" for the editor collaborative Notes feature).
## Changes
src/wp-admin/includes/meta-boxes.php— Replaced_e( 'Notes' )with_ex( 'Notes', 'link manager notes field label' )and added a/* translators: */comment on the Notes textarea label in the Link Manager edit screen.
## Why
WordPress 6.9 introduced a collaborative "Notes" feature in the block editor. Both it and the pre-existing Link Manager "Notes" field share the same bare translation string, making it impossible for translators to supply different translations for each context. Using _ex() with a context string resolves this ambiguity per WordPress i18n best practices.
## Testing
No behavioral change — this is a translation context fix only. Verify by confirming the Link Manager edit screen still renders the "Notes" label correctly.
---
Trac ticket: https://core.trac.wordpress.org/ticket/64980
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
6 weeks ago
#6
@
6 weeks ago
- Keywords commit added
- Owner set to audrasjb
- Status changed from new to accepted
The PR looks good. Self assigning for commit.
#8
@
6 weeks ago
- Keywords dev-feedback added; commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backport.
#9
@
6 weeks ago
Note wrong props, should have been:
Props timse201, sanketparmar.
I'm fixing this manually on the Make/Core tool.
#11
@
5 days ago
- Keywords dev-reviewed commit added; dev-feedback removed
[62185] looks good for backporting.
#12
@
5 days ago
- Keywords fixed-major added
Adding fixed-major so the ticket is properly grouped by workflow reports.
https://translate.wordpress.org/projects/wp/dev/de/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=77690&filters%5Btranslation_id%5D=146109832