Make WordPress Core

Opened 13 days ago

Closed 9 days ago

#65001 closed defect (bug) (fixed)

Hover on Upload files media Library tabs and drop to upload file overlay color has still old color

Reported by: opurockey's profile opurockey Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: normal Version: trunk
Component: Media Keywords: has-patch commit dev-reviewed
Focuses: accessibility Cc:

Description

In Upload files media Library tabs and drop to upload file overlay section, It is still showing old color.

Attachments (2)

image-03-26-2026_11_38_AM.png (63.1 KB) - added by opurockey 13 days ago.
image-03-26-2026_11_37_AM.png (71.1 KB) - added by opurockey 13 days ago.

Download all attachments as: .zip

Change History (20)

This ticket was mentioned in PR #11409 on WordPress/wordpress-develop by @opurockey.


13 days ago
#1

  • Keywords has-patch added

Ticket: https://core.trac.wordpress.org/ticket/65001

## Description:

This PR updates the color usage in media-view.css to align with the modern WordPress admin color system by replacing hardcoded/legacy color values with standardized admin color variables.

As part of ongoing efforts in WordPress core to reduce color inconsistencies and adopt a unified color palette using CSS custom properties, admin styles are being refactored to use semantic color tokens instead of fixed values.

## Changes Made:

  • Replaced legacy color values used in: :hover :focus
  • interactive states and UI elements
  • Updated styles to use: WP admin color variables (e.g. --wp-admin-theme-color, --wp-admin-theme-color-darker-*, etc.)
  • Removed outdated or hardcoded hex values to ensure consistency with the admin color system

## Why This Change:

  • Ensures visual consistency across WordPress admin UI
  • Improves maintainability by centralizing color definitions
  • Aligns with WordPress core direction of using CSS custom properties for theming and extensibility
  • Improves compatibility with different admin color schemes and future design updates

## Impact:

  • No functional changes
  • Purely visual/style refactor
  • Affects only media-view components in admin
  • Better integration with admin color schemes-

## Testing Instructions:

  • Open Media Library (Grid and List view)
  • Hover and focus on: Media items Buttons and controls
  • Verify: Colors match WP admin theme, No regressions in hover/focus states
  • Test across different admin color schemes

## Screenshot:

https://github.com/user-attachments/assets/1dc6b763-2b83-4e38-bfd2-4f1f32d951e3
https://github.com/user-attachments/assets/3ae16d45-f508-4435-9287-81221ed4634e

#2 @audrasjb
13 days ago

  • Focuses accessibility added
  • Keywords changes-requested added
  • Milestone changed from Awaiting Review to 7.0
  • Version set to trunk

#3 @audrasjb
13 days ago

@opurockey thanks for the ticket and PR, however the above screenshot seems to have color contrast issues between text and background.

#4 @joedolson
12 days ago

@audrasjb I'm not seeing the color contrast change you're asking about. Can you be more specific? I'd also say that the uploaded screenshot doesn't reflect the current PR; the screenshot shows gray text on the new blue background, but the PR uses white text.

#5 @joedolson
12 days ago

  • Owner set to joedolson
  • Status changed from new to accepted

@wildworks commented on PR #11409:


12 days ago
#6

@OpuRockey, I believe you have already submitted PR #11375, which is similar to this one. However, let's prioritize this PR. Please apply this feedback from that PR to this one as well.

#7 follow-up: @manhar
11 days ago

As I see and confirm, This is still use old color on hover.

Refer the below image :

https://postimg.cc/jLmGRgY0

@opurockey commented on PR #11409:


11 days ago
#8

There's an additional color overlooked here, on .media-modal-close:focus, which should also be updated.

@joedolson , I’ve addressed the requested changes. Let me know if anything else is needed.

@opurockey commented on PR #11409:


11 days ago
#9

@OpuRockey, I believe you have already submitted PR #11375, which is similar to this one. However, let's prioritize this PR. Please apply this feedback from that PR to this one as well.

@t-hamano , All suggested changes have been incorporated. Kindly review again.

https://github.com/user-attachments/assets/c5e02e4f-2a03-4e7c-90e0-49d1d84bee24
https://github.com/user-attachments/assets/50f3992f-5157-43b1-8d49-cbbd22e5e257
https://github.com/user-attachments/assets/e3292cae-befe-4865-a9b7-26b08ec2533c
https://github.com/user-attachments/assets/4e349698-a4dd-4c75-9b31-662313ce849b

#10 in reply to: ↑ 7 ; follow-up: @opurockey
11 days ago

Replying to manhar:

As I see and confirm, This is still use old color on hover.

Refer the below image :

https://postimg.cc/jLmGRgY0

@manhar, Could you please pull and check that again after clearing the browser cache? Thanks.

#11 @wildworks
11 days ago

#65010 was marked as a duplicate.

@opurockey commented on PR #11409:


11 days ago
#12

@t-hamano, Thanks for the suggestions. I’ve applied the changes. Please review.

#13 in reply to: ↑ 10 @manhar
11 days ago

Replying to opurockey:

Replying to manhar:

As I see and confirm, This is still use old color on hover.

Refer the below image :

https://postimg.cc/jLmGRgY0

@manhar, Could you please pull and check that again after clearing the browser cache? Thanks.

@opurockey Yes, it is working properly .

Thanks for Information.

#14 @joedolson
10 days ago

  • Keywords commit added; changes-requested removed

#15 @joedolson
10 days ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 62199:

Media: Update upload file overlay colors.

Update the colors used for the file upload overlay mask to use the new admin theme colors.

Props opurockey, huzaifaalmesbah, wildworks, audrasjb, manhar, joedolson.
Fixes #65001.

#16 @joedolson
10 days ago

  • Component changed from Upload to Media
  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for review to merge to the 7.0 branch.

#17 @wildworks
10 days ago

  • Keywords dev-reviewed added; dev-feedback removed

Reviewed and approved for 7.0.

#18 @joedolson
9 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 62204:

Media: Update upload file overlay colors.

Update the colors used for the file upload overlay mask to use the new admin theme colors.

Reviewed by wildworks.
Merges 62199 to the 7.0 branch.

Props opurockey, huzaifaalmesbah, wildworks, audrasjb, manhar, joedolson.
Fixes #65001.

Note: See TracTickets for help on using tickets.