Opened 13 days ago
Closed 9 days ago
#65001 closed defect (bug) (fixed)
Hover on Upload files media Library tabs and drop to upload file overlay color has still old color
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 7.0 | Priority: | normal |
| Severity: | normal | Version: | trunk |
| Component: | Media | Keywords: | has-patch commit dev-reviewed |
| Focuses: | accessibility | Cc: |
Description
In Upload files media Library tabs and drop to upload file overlay section, It is still showing old color.
Attachments (2)
Change History (20)
This ticket was mentioned in PR #11409 on WordPress/wordpress-develop by @opurockey.
13 days ago
#1
- Keywords has-patch added
#2
@
13 days ago
- Focuses accessibility added
- Keywords changes-requested added
- Milestone changed from Awaiting Review to 7.0
- Version set to trunk
#3
@
13 days ago
@opurockey thanks for the ticket and PR, however the above screenshot seems to have color contrast issues between text and background.
#4
@
12 days ago
@audrasjb I'm not seeing the color contrast change you're asking about. Can you be more specific? I'd also say that the uploaded screenshot doesn't reflect the current PR; the screenshot shows gray text on the new blue background, but the PR uses white text.
@wildworks commented on PR #11409:
12 days ago
#6
@OpuRockey, I believe you have already submitted PR #11375, which is similar to this one. However, let's prioritize this PR. Please apply this feedback from that PR to this one as well.
#7
follow-up:
↓ 10
@
11 days ago
As I see and confirm, This is still use old color on hover.
Refer the below image :
@opurockey commented on PR #11409:
11 days ago
#8
There's an additional color overlooked here, on
.media-modal-close:focus, which should also be updated.
@joedolson , I’ve addressed the requested changes. Let me know if anything else is needed.
@opurockey commented on PR #11409:
11 days ago
#9
@OpuRockey, I believe you have already submitted PR #11375, which is similar to this one. However, let's prioritize this PR. Please apply this feedback from that PR to this one as well.
@t-hamano , All suggested changes have been incorporated. Kindly review again.
#10
in reply to:
↑ 7
;
follow-up:
↓ 13
@
11 days ago
Replying to manhar:
As I see and confirm, This is still use old color on hover.
Refer the below image :
@manhar, Could you please pull and check that again after clearing the browser cache? Thanks.
@opurockey commented on PR #11409:
11 days ago
#12
@t-hamano, Thanks for the suggestions. I’ve applied the changes. Please review.
Ticket: https://core.trac.wordpress.org/ticket/65001
## Description:
This PR updates the color usage in media-view.css to align with the modern WordPress admin color system by replacing hardcoded/legacy color values with standardized admin color variables.
As part of ongoing efforts in WordPress core to reduce color inconsistencies and adopt a unified color palette using CSS custom properties, admin styles are being refactored to use semantic color tokens instead of fixed values.
## Changes Made:
## Why This Change:
## Impact:
## Testing Instructions:
## Screenshot: