Opened 6 weeks ago
Last modified 3 weeks ago
#65014 new defect (bug)
Site Health: Error icon missing due to missing dashicons class
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 7.1 | Priority: | normal |
| Severity: | normal | Version: | 5.3 |
| Component: | Site Health | Keywords: | has-screenshots has-patch |
| Focuses: | ui, css, administration | Cc: |
Description (last modified by )
Tested on WordPress 7.0-RC2, the error icon is not displayed in:
Tools → Site Health → Status
Issue
The error indicator span is missing the required dashicons class.
Current markup:
<span class="error"></span>
Expected markup:
<span class="error dashicons"></span>
Because of the missing dashicons class, the icon is not rendered.
Steps to Reproduce
- Install WordPress 7.0-RC2
- Go to Tools → Site Health → Status
- Trigger an error (e.g., block external requests or simulate failure)
- Observe missing icon next to the error message
Expected Behavior
The error icon (dashicon) should be visible.
Actual Behavior
No icon is displayed.
Proposed Fix
Add the dashicons class to the error span element.
Additional Notes
I have verified that adding the dashicons class fixes the issue.
Screenshots attached:
- Before fix (icon missing)
- After fix (icon visible)
Attachments (4)
Change History (17)
#1
@
6 weeks ago
Thanks for the report.
Please note that this issue did not newly arise in 7.0.
Also, if someone wishes to test this problem, you can intentionally cause an error with code like the following:
add_filter( 'pre_http_request', function( $response, $parsed_args, $url ) {
if ( false !== strpos( $url, 'api.wordpress.org' ) ) {
return new WP_Error( 'http_request_failed', 'Intentional failure for testing.' );
}
return $response;
}, 10, 3 );
#2
@
6 weeks ago
- Component changed from Administration to Site Health
- Description modified (diff)
- Keywords needs-patch added; has-patch removed
- Milestone changed from Awaiting Review to 7.1
- Version changed from trunk to 5.3
[45309] removed lines of CSS in favor of adding the dashicons class, and it missed at least this one message.
@
6 weeks ago
Attaching patch for missing dashicons class on error span in Site Health status screen. Verified fix manually. Consistent with changes from #45309.
This ticket was mentioned in PR #11440 on WordPress/wordpress-develop by @valani9099.
6 weeks ago
#3
- Keywords has-patch added; needs-patch removed
## Problem
Error icon not showing in Tools → Site Health → Status
because dashicons class is missing from error span.
## Fix
Added missing dashicons class to the error span element.
Missed during cleanup in #45309.
## Testing
add_filter( 'pre_http_request', function( $response, $parsed_args, $url ) {
if ( false !== strpos( $url, 'api.wordpress.org' ) ) {
return new WP_Error( 'http_request_failed', 'Intentional failure.' );
}
return $response;
}, 10, 3 );
Then go to Tools → Site Health → Status and verify icon is visible.
Trac ticket: [](https://core.trac.wordpress.org/ticket/65014)
## Use of AI Tools
#4
@
6 weeks ago
https://github.com/WordPress/wordpress-develop/pull/11440
Patch attached and PR created for review.
This restores the missing dashicons class for the error icon in the Site Health screen.
As noted in changeset [45309], CSS was removed in favor of dashicons, but this instance was missed.
Tested using the pre_http_request filter method to simulate failure, and confirmed the icon now displays correctly.
#5
@
6 weeks ago
https://github.com/WordPress/wordpress-develop/pull/11440 looks good to me.
However, due to the coordination with the 7.0 release, it would be best not to commit to trunk yet.
#6
@
6 weeks ago
Thank you @wildworks for reviewing!
I understand the timing with the 7.0 release coordination. I'll wait for trunk to reopen and am happy to assist with any further testing needed.
@valani9099 commented on PR #11440:
6 weeks ago
#7
Thanks @sabernhardt! Updated the class order to put dashicons first for consistency as suggested.
@
6 weeks ago
Updated patch v2 — moved dashicons class before error class for consistency per @sabernhardt suggestion.
#8
@
6 weeks ago
@valani9099 Thanks for the update.
P.S. If you have already submitted a pull request, you do not need to submit a separate patch.
#9
@
6 weeks ago
Thank you for the clarification @wildworks! Sorry for the extra patch — I wasn't aware the PR was sufficient on its own. I've re-requested reviews on the PR from @sabernhardt and @t-hamano. I'll keep this in mind for future contributions and rely only on the PR going forward!
@wildworks commented on PR #11440:
4 weeks ago
#10
@Webizito, As mentioned in this comment, it is not necessary to regularly merge trnk into this PR.
#11
follow-up:
↓ 12
@
3 weeks ago
Thank you for the guidance @wildworks! Understood — I will stop merging trunk into the PR and leave it as is.
Just curious — since WordPress 7.0 release seems to be delayed, is there any chance this fix could still be included in 7.0, or will it be targeted for 7.1 once trunk reopens? Happy to wait and assist with any further testing if needed!
#12
in reply to:
↑ 11
@
3 weeks ago
Replying to valani9099:
Just curious — since WordPress 7.0 release seems to be delayed, is there any chance this fix could still be included in 7.0, or will it be targeted for 7.1 once trunk reopens? Happy to wait and assist with any further testing if needed!
This bug is not new to 7.0, so it probably doesn't need to be included.
Before fix – Site Health error icon missing in WordPress 7.0-RC2 admin panel