Make WordPress Core

Opened 5 months ago

Closed 3 months ago

#65026 closed defect (bug) (fixed)

Hide plugin search form on Favorites tab

Reported by: bor0 Owned by: westonruter
Priority: normal Milestone: 7.1
Component: Plugins Version:
Severity: normal Keywords: has-patch
Cc: Focuses: ui

Description

The plugin search form is currently displayed on the Favorites tab, where it is not applicable.

This patch prevents the search form from rendering when tab=favorites, aligning the UI with expected behavior and reducing confusion.

Attachments (1)

65026.patch (779 bytes ) - added by bor0 5 months ago.

Download all attachments as: .zip

Change History (17)

@bor0
5 months ago

#1 @bor0
5 months ago

cc @dd32, would be great to get your thoughts on this one as well

This ticket was mentioned in PR #11457 on WordPress/wordpress-develop by @manishxdp.


5 months ago
#2

The plugin search form should not be displayed on the Favorites tab where it is not applicable. This change prevents the search form from rendering when viewing favorite plugins, reducing UI confusion and aligning with expected behavior.

Fixes #65026

Ticket track -https://core.trac.wordpress.org/ticket/65026

Go to Plugins → Add New

Click Favorites tab

  1. Verify search form is hidden

Click Featured tab

  1. Verify search form is visible

Click Popular tab

3.Verify search form is visible
Click Recommended tab

4.Verify search form is visible

#3 @bor0
5 months ago

cc @SergeyBiryukov would also be great to get your opinion on it

@manishxdp commented on PR #11457:


5 months ago
#4

@SergeyBiryukov can you check this

1] Favourite tab after the fixes
https://github.com/user-attachments/assets/2ce49924-642d-435a-9a9b-a69459f078de

#5 @westonruter
5 months ago

  • Milestone Awaiting Review7.1
  • Owner set to westonruter
  • Status newreviewing

@manishxdp commented on PR #11457:


5 months ago
#6

@westonruter can you check now?

@manishxdp commented on PR #11457:


5 months ago
#7

@shail-mehta can you check now

#8 @sabbir1991
5 months ago

@bor0 Tested on playground and it's working.

Checked on Featured, Popular, and Recommended pages, the search form is showing.

Checked on the Favorites page, the search form is not showing.

@westonruter commented on PR #11457:


5 months ago
#9

It looks good to me. Once trunk is open for commit again, I'll follow up. (At least a week from now.)

@manishxdp commented on PR #11457:


4 months ago
#10

@westonruter any update on this

@westonruter commented on PR #11457:


4 months ago
#11

@manishdhorepatil-art The trunk branch is still frozen. Still waiting for business as usual. Probably will be another couple weeks.

@manishxdp commented on PR #11457:


4 months ago
#12

@westonruter any update is the trunk open now

@westonruter commented on PR #11457:


4 months ago
#13

Nope

@manishxdp commented on PR #11457:


4 months ago
#14

@westonruter pls look into this as trunk open now

@westonruter commented on PR #11457:


3 months ago
#15

# Favorites tab

✅ The search box is hidden.

The trunk branch:

https://github.com/user-attachments/assets/4ceecd15-7362-45e3-8fe1-481263f5aa83

This branch:

https://github.com/user-attachments/assets/512c2817-d437-4923-85d0-0d81044640f4

# Recommended tab

✅ As expected, no changes to this tab.

The trunk branch:

https://github.com/user-attachments/assets/df0eb925-2b78-48b8-aabb-2be68194b7fa

This branch:

https://github.com/user-attachments/assets/8d40cc14-7776-4547-9f75-5bf6b6b57ba3

#16 @westonruter
3 months ago

  • Resolutionfixed
  • Status reviewingclosed

In 62448:

Plugins: Hide the search form on the Favorites tab.

The plugin search form does not apply to the Favorites tab, which instead expects a WordPress.org username to look up a user's favorited plugins. Rendering the term-based search form there was misleading. Update WP_Plugin_Install_List_Table::views() to read the global $tab and skip install_search_form() when the favorites tab is active, while leaving the form in place on the Featured, Popular, and Recommended tabs.

Developed in https://github.com/WordPress/wordpress-develop/pull/11457.

Props manishxdp, bor0, westonruter, shailu25, sabbir1991.
Fixes #65026.

Note: See TracTickets for help on using tickets.