Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#65060 closed defect (bug) (fixed)

Formatting issue on expand/collapse meta box area focus

Reported by: brianhogg Owned by: wildworks
Priority: normal Milestone: 7.0
Component: Formatting Version: 7.0
Severity: normal Keywords: admin-reskin has-patch dev-reviewed
Cc: Focuses:

Description

When a meta box expand/collapse button has focus, the formatting looks off. The radius is a bit too big for the height available.

Attachments (2)

formatting-issue-meta-boxes.jpeg​ (399.4 KB ) - added by brianhogg 7 months ago.
metabox.png​ (21.1 KB ) - added by wildworks 7 months ago.

Download all attachments as: .zip

Change History (12)

#1 @wildworks
7 months ago

  • Keywords admin-reskin added
  • Milestone Awaiting Review → 7.0

Thanks for the report. I believe this problem was caused by #64644. This is because #64644 changed the focused state as follows:

From:

.postbox .handle-order-higher:focus,
.postbox .handle-order-lower:focus,
.postbox .handlediv:focus {
	box-shadow: inset 0 0 0 2px #2271b1;
}

To:

.postbox .handle-order-higher:focus,
.postbox .handle-order-lower:focus,
.postbox .handlediv:focus {
	box-shadow: 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color);
}

Note that the inset has been removed.

This ticket was mentioned in ​PR #11550 on ​WordPress/wordpress-develop by ​@wildworks.


7 months ago
#2

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/65060

## Before

https://github.com/user-attachments/assets/5494912b-0528-4f44-832f-f515d26d4e60

## After
https://github.com/user-attachments/assets/aeae1e66-21ce-4d4a-9480-5bad32ebb994

## Use of AI Tools

None

#3 @audrasjb
7 months ago

  • Keywords needs-testing added

#4 @poena
7 months ago

PR 11550 solves the issue for me (I only tested in Chrome on Windows).

​@darshitrajyaguru97 commented on ​PR #11550:


7 months ago
#5

I have tested the patch using WordPress Playground in Google Chrome on a Windows system, including areas such as editor metaboxes and dashboard widgets. Based on my testing, the issue appears to be resolved, and the patch is working as expected. 👍

#6 @abcd95
7 months ago

  • Keywords needs-testing removed

Test Report

Description

This report validates that the indicated patch works as expected.

Patch tested: ​https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/11550.diff

Environment

  • WordPress: 7.1-alpha-62161-src
  • PHP: 8.3.30
  • Server: nginx/1.29.8
  • Database: mysqli (Server: 8.4.8 / Client: mysqlnd 8.3.30)
  • Browser: Firefox 149.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.4
  • Plugins:
    • Classic Editor 1.6.7
    • Test Reports 1.2.0

Actual Results

✅ Issue resolved with the patch. The focus ring on the button now renders correctly, and the ring sits flush within the button boundary without overflowing.

Patch works correctly in the Classic Editor as well. Meta box expand/collapse focus styling renders properly in both the block editor and the Classic Editor plugin (v1.6.7).

Supplemental Artifacts

Block editor - before patch

https://i.ibb.co/5g9J7X2j/Screenshot-2026-04-13-at-16-51-11.png

Block editor - after patch

https://i.ibb.co/9Hcqv2p4/Screenshot-2026-04-13-at-16-50-30.png

Classic editor - before patch

https://i.ibb.co/PGt2CMvh/Screenshot-2026-04-13-at-16-54-28.png

Classic editor - after patch

https://i.ibb.co/fYtYtwSw/Screenshot-2026-04-13-at-16-53-09.png

#7 @wildworks
7 months ago

  • Owner set to wildworks
  • Resolution → fixed
  • Status new → closed

In 62232:

Administration: Fix focus outline being cut off for the metabox collapse and move buttons.

Fixes an issue where the focus outline on metabox collapse buttons and move handles was being clipped.

Props abcd95, audrasjb, brianhogg, darshitrajyaguru97, poena, wildworks.
Fixes #65060.

#8 @wildworks
7 months ago

  • Keywords dev-feedback added
  • Resolution fixed
  • Status closed → reopened

Reopening #65060 to request backporting [62232] to the 7.0 branch

#9 @audrasjb
7 months ago

  • Keywords dev-reviewed added; dev-feedback removed

Thanks. This is a second committer sign off.

#10 @audrasjb
7 months ago

  • Resolution → fixed
  • Status reopened → closed

In 62235:

Administration: Fix focus outline being cut off for the metabox collapse and move buttons.

Fixes an issue where the focus outline on metabox collapse buttons and move handles was being clipped.

Reviewed by audrasjb, wildworks.
Merges [62232] to the 7.0 branch.

Props abcd95, audrasjb, brianhogg, darshitrajyaguru97, poena, wildworks.
Fixes #65060.

Note: See TracTickets for help on using tickets.