Make WordPress Core

Opened 5 weeks ago

Closed 3 weeks ago

#65063 closed defect (bug) (fixed)

Classic Editor: slug editing field is too large

Reported by: wildworks's profile wildworks Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: normal Version: trunk
Component: Administration Keywords: admin-reskin has-patch fixed-major dev-reviewed
Focuses: Cc:

Description

Following a redesign of the form elements, the height of the slug editing field has changed from 30px to 40px.

Since this is very large, I propose changing it to 32px. Additionally, the slug input field, OK button, and Cancel button should be properly aligned.

Attachments (3)

post-slug-input-field-comparison.png (29.9 KB) - added by wildworks 5 weeks ago.
65063_before.png (59.6 KB) - added by khushdoms 4 weeks ago.
before patch apply
65063_after.png (58.5 KB) - added by khushdoms 4 weeks ago.
after patch apply

Download all attachments as: .zip

Change History (25)

This ticket was mentioned in PR #11551 on WordPress/wordpress-develop by @wildworks.


5 weeks ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/65063

## Use of AI Tools

None

## Screenshots

Before After
https://github.com/user-attachments/assets/b85c4476-707d-4df9-b967-31c68673cb93 https://github.com/user-attachments/assets/24112f08-7bef-4fbd-a45b-c7e6e6c99cd6

@wildworks commented on PR #11551:


5 weeks ago
#2

Note that this PR contains minimal changes for 7.0. Ideally, we should refactor using the flex layout. Appropriate spacing should also be added, for example, like this.

1200px width:

https://github.com/user-attachments/assets/fe5569f2-6f46-4e80-974d-356955910a96

700px width:

https://github.com/user-attachments/assets/36699474-a7d8-4eda-8bbc-6528df7f0010

360px width:

https://github.com/user-attachments/assets/5a452735-554f-45d1-b21e-ca439760aca3

#3 @joedolson
5 weeks ago

  • Owner set to joedolson
  • Status changed from new to accepted

@sabernhardt commented on PR #11551:


5 weeks ago
#4

Consider changing the OK button from button-small to button-compact. It would have the same height as the input on smaller screens when combined with the buttons.css change in #11549.

Then the Cancel button might have a larger font size than 11px, too (by removing that rule).

@audrasjb commented on PR #11551:


5 weeks ago
#5

Honestly I would decrease the height of that specific input rather than increasing the height of the button. I know it would be an exception for that specific area but with the provided screenshots, we can see that there is a hierarchy issue: the permalink/slug area should not be displayed with the same visual hierarchy we have for the post title. The text in this section is smaller for this reason.

@wildworks commented on PR #11551:


5 weeks ago
#6

Thanks for the feedback!

Consider changing the OK button from button-small to button-compact. It would have the same height as the input on smaller screens when combined with the buttons.css change in #11549.

The height of the OK button and the slug input field is 32px.

https://github.com/user-attachments/assets/63f6fcba-e097-4543-8e91-e3a97795f720

Honestly I would decrease the height of that specific input rather than increasing the height of the button.

The height of the OK button and the slug input field is 24px.

https://github.com/user-attachments/assets/e5da4981-21e7-4015-8b63-7d252afe9b77

The 24px high input field feels too cramped. I'll try the former approach.

Dhruvang2001 commented on PR #11551:


5 weeks ago
#7

@t-hamano while testing the PR in the playground found focus issue

https://github.com/user-attachments/assets/64b3b63c-bf07-4127-a19e-3ba610d08a63

@wildworks commented on PR #11551:


5 weeks ago
#8

@Dhruvang2001 Thanks for the report. In fact, the issue has existed for a while, but it became more prominent with the design changes in version 7.0. This is a screenshot from 6.9.

https://github.com/user-attachments/assets/65a7021c-5b70-4e3e-8838-cb79f2027527

I would appreciate it if you could report this issue in a new ticket.

Dhruvang2001 commented on PR #11551:


5 weeks ago
#9

@t-hamano while testing the PR in the playground found focus issue

https://github.com/user-attachments/assets/64b3b63c-bf07-4127-a19e-3ba610d08a63

@dhruvang21 commented on PR #11551:


5 weeks ago
#10

I had previously commented from the wrong account and removed it. Sharing it again here from my correct account:

https://github.com/user-attachments/assets/cba934c5-6574-436b-8233-71f748f4f1df

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


5 weeks ago

This ticket was mentioned in Slack in #core-test by gaisma22. View the logs.


5 weeks ago

@shailu25 commented on PR #11551:


4 weeks ago
#13

The button and input field are now set to a height of 32px ✅

BeforeAfter
https://github.com/user-attachments/assets/729d9e4a-6228-4176-80f6-d8a0059b323fhttps://github.com/user-attachments/assets/07c9712d-8993-41ac-b45e-7e8cd6613bfe

#14 @tusharaddweb
4 weeks ago

Tested and confirmed that the slug input field height is currently too large compared to surrounding elements.

Refer below images for confirm.

Before Patch:
https://postimg.cc/PCcGHqfK

After Patch:
https://postimg.cc/wyM0jXWs

This ticket was mentioned in Slack in #core-test by ozgur_sar. View the logs.


4 weeks ago

@khushdoms
4 weeks ago

before patch apply

@khushdoms
4 weeks ago

after patch apply

#16 @khushdoms
4 weeks ago

Tested the patch and confirmed the issue is resolved.

Test Report

Tested patch : https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/11551.diff

Tested PR : https://github.com/WordPress/wordpress-develop/pull/11551

Description

This report validates whether the indicated patch works as expected.

Patch tested: (add patch link here)

Environment

  • WordPress: 7.1-alpha-62161-src
  • PHP: 8.3.30
  • Server: nginx/1.29.7
  • Database: mysqli (Server: 8.4.8 / Client: mysqlnd 8.3.30)
  • Browser: Chrome 147.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins: None
  • Plugins:
    • Disable Gutenberg 3.3.1
    • Test Reports 1.2.1

Steps to Reproduce

  1. Open Add New Post screen
  2. Edit the permalink (slug)
  3. Observe input field height and alignment

Before Patch

  • Slug input field height is larger than surrounding elements
  • Buttons (OK/Cancel) are not properly aligned ❌

before patch apply

After Patch

  • Input field height is consistent (32px)
  • Buttons are properly aligned
  • UI appears clean and consistent ✅

after patch apply

Actual Results

  • Issue resolved successfully with the patch
  • No regressions observed

Additional Notes

  • Tested at standard zoom (100%)
  • UI remains consistent during interaction

Conclusion:
Patch works as expected 👍

Last edited 4 weeks ago by khushdoms (previous) (diff)

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 weeks ago

#18 @audrasjb
3 weeks ago

  • Keywords commit added
  • Version set to trunk

@wildworks thanks for updating the PR. @joedolson I think we're good to go now!

#19 @peterwilsoncc
3 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 62263:

Administration: Resize classic editor slug field for new theme.

Reduces the size and improves the alignment of the post slug field following the re-design of form elements as part of the new admin theme.

Props wildworks, sabernhardt, audrasjb, dhruvang21, shailu25, joedolson, khushdoms, tusharaddweb.
Fixes #65063.

#20 @peterwilsoncc
3 weeks ago

  • Keywords dev-feedback fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merge to the 7.0 branch pending another committers sign off.

#21 @wildworks
3 weeks ago

  • Keywords dev-reviewed added; commit dev-feedback removed

Approving [62263] for 7.0 backport.

#22 @peterwilsoncc
3 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 62270:

Administration: Resize classic editor slug field for new theme.

Reduces the size and improves the alignment of the post slug field following the re-design of form elements as part of the new admin theme.

Reviewed by wildworks.
Merges r62263 to the 7.0 branch.

Props wildworks, sabernhardt, audrasjb, dhruvang21, shailu25, joedolson, khushdoms, tusharaddweb.
Fixes #65063.

Note: See TracTickets for help on using tickets.