Make WordPress Core

Opened 4 weeks ago

Last modified 13 days ago

#65084 new enhancement

Update error message for disallowed username characters

Reported by: marc4's profile Marc4 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch reporter-feedback has-unit-tests needs-refresh
Focuses: ui-copy Cc:

Description

I suggest replacing “illegal characters” with “unallowed characters” to avoid unnecessarily alarming the user and to be more specific.

This error message appears when you try to create a username that contains “special characters.”

This is the PR: https://github.com/WordPress/wordpress-develop/pull/11590

Attachments (1)

illegal-characters.png (33.6 KB) - added by Marc4 4 weeks ago.

Download all attachments as: .zip

Change History (15)

#1 @Marc4
4 weeks ago

Typo error, sorry. I suggest replacing illegal characters with disallowed characters.

#2 @nikunj8866
4 weeks ago

@Marc4, please add this ticket link to the PR.

This ticket was mentioned in PR #11590 on WordPress/wordpress-develop by @Marc4.


4 weeks ago
#3

This PR replaces illegal characters with disallowed characters, removing unnecessarily alarmist language for the user.

https://core.trac.wordpress.org/ticket/65084

#4 @Marc4
4 weeks ago

Done. Thank's for your follow-up @nikunj8866

#5 @jigarkahar
4 weeks ago

Test Report

Description

❌ This report validates whether the indicated patch not works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/11590

Environment

  • WordPress: 7.1-alpha-20260416.170638
  • PHP: 7.4.33
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
  • Browser: Chrome 147.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1

Steps to Test

1: Go to WordPress admin panel (/wp-admin)
2: Navigate to Users → Add New
3: Enter username:MarÇ
4: Fill required fields
5: Click Add New User

Actual Results

  1. ❌ Issue notresolved with patch.
  2. Still this is same message. not changed.

Supplemental Artifacts

https://tinyurl.com/29vhvnfl

#6 @jigarkahar
4 weeks ago

  • Keywords reporter-feedback added

@dhruvang21 commented on PR #11590:


4 weeks ago
#7

Tested in WP playground issue is not resolved
https://github.com/user-attachments/assets/4311e56f-f412-4229-8108-4f9b27832852

This ticket was mentioned in PR #11668 on WordPress/wordpress-develop by @shreyasikhar26.


3 weeks ago
#8

  • Keywords has-unit-tests added

#### Trac ticket: https://core.trac.wordpress.org/ticket/65084

---

### Summary

This PR replaces the "illegal characters" with "unallowed characters" across all the occurences for consistency.

@shreyasikhar26 commented on PR #11590:


3 weeks ago
#9

@dhruvang21 I have created a new PR for this issue, it replaces all the occurrences of illegal characters with disallowed characters
PR link: https://github.com/WordPress/wordpress-develop/pull/11668

#10 @shreyasikhar26
3 weeks ago

Created another PR here: https://github.com/WordPress/wordpress-develop/pull/11668

Since earlier PR was missing some cases, my PR will be covering it.

#11 @shreyasikhar26
3 weeks ago

  • Keywords needs-refresh added

@dhruvang21 commented on PR #11590:


2 weeks ago
#12

@shreyasikhar you have used unallowed keyword instead of disallowed in the message

#13 @shreyasikhar26
2 weeks ago

Thanks @dhruvang21, I have updated the same PR by replacing unallowed with disallowed.

#14 @yusufmudagal
13 days ago

Tested PR https://github.com/WordPress/wordpress-develop/pull/11668

Before the patch, invalid username messages used "illegal characters" in both register_new_user() and WP_REST_Users_Controller::check_username().
After the patch, both now say "disallowed characters".

Patch tests well for me.

Note: See TracTickets for help on using tickets.