Make WordPress Core

Opened 3 weeks ago

Last modified 3 weeks ago

#65107 new defect (bug)

Twenty Sixteen: italics lost in 'blockquote cite'

Reported by: gaelbonithon's profile gaelbonithon Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.4
Component: Bundled Theme Keywords: has-patch 2nd-opinion
Focuses: css Cc:

Description

Whether you use italics or not in blockquote cite, the result is the same, both in the editor and in the final output. There should be a difference, one way or another (italics or regular text, depending on the overall font style).

Change History (5)

This ticket was mentioned in PR #11622 on WordPress/wordpress-develop by Tamaranch.


3 weeks ago
#1

  • Keywords has-patch added

This is a way to fix the bug mentioned below. Note that the change for the editor doesn't seem to be enough: italics aren't being applied for me, unlike in the final result. That said, I suppose this change needs to be made regardless.

Trac ticket: https://core.trac.wordpress.org/ticket/65107

## Use of AI Tools

#2 @westonruter
3 weeks ago

  • Component changed from Themes to Bundled Theme
  • Focuses css added

#3 @manhar
3 weeks ago

Tested and patch is working as expected.

Refer the below image:

Before Patch:
https://postimg.cc/XpfbjS1n

After Patch:
https://postimg.cc/NKFpNRHZ

#4 follow-up: @sabernhardt
3 weeks ago

  • Keywords 2nd-opinion added
  • Version changed from trunk to 4.4

Hi and welcome to WordPress Core Trac!

The theme's initial commit used font-style: normal in front-end and editor styles to reverse the italics of the blockquote in em and cite elements. The default styling should remain as it has been for ten years.

In 2018, Twenty Sixteen styles for the block editor reinforced the normal font-style within the Quote block.

The theme probably could add italics again for em elements within citations.

blockquote :where(cite) em {
	font-style: italic;
}

and in editor-blocks.css

.wp-block-quote__citation em {
	font-style: italic;
}

The additional style would be inappropriate for anyone who made the citations italic, but using :where() to match the specificity should reduce the possibility of unexpected changes.

#5 in reply to: ↑ 4 @gaelbonithon
3 weeks ago

Replying to sabernhardt:

Hi and welcome to WordPress Core Trac!

The theme's initial commit used font-style: normal in front-end and editor styles to reverse the italics of the blockquote in em and cite elements. The default styling should remain as it has been for ten years.

In 2018, Twenty Sixteen styles for the block editor reinforced the normal font-style within the Quote block.

The theme probably could add italics again for em elements within citations.

blockquote :where(cite) em {
	font-style: italic;
}

and in editor-blocks.css

.wp-block-quote__citation em {
	font-style: italic;
}

The additional style would be inappropriate for anyone who made the citations italic, but using :where() to match the specificity should reduce the possibility of unexpected changes.

Thank you, patch updated.

Note: See TracTickets for help on using tickets.