Make WordPress Core

Opened 5 months ago

Last modified 2 months ago

#65108 new enhancement

Twenty Sixteen: barely visible bold text in 'blockquote'

Reported by: gaelbonithon Owned by:
Priority: normal Milestone: Future Release
Component: Bundled Theme Version: 4.4
Severity: normal Keywords: has-patch has-test-info has-screenshots needs-design-feedback
Cc: Focuses: css

Description

The current code is

blockquote strong,
blockquote b {
  font-weight: 400;
}

, which makes very little difference. It seems to me that this would be better:

blockquote strong,
blockquote b {
  font-weight: bold;
}

Attachments (1)

T16-quote-em-strong.png (39.3 KB ) - added by sabernhardt 5 months ago.
Quote blocks with em and strong elements within both the paragraph and the citation

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in PR #11623 on WordPress/wordpress-develop by @gaelbonithon.


5 months ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/65108

## Use of AI Tools

#2 @gaelbonithon
5 months ago

  • Summary Twenty Sixteen: barely visible bold text in a blockquoteTwenty Sixteen: barely visible bold text in 'blockquote'

#3 @westonruter
5 months ago

  • Component ThemesBundled Theme
  • Focuses css added

#4 @JayDeep Nimavat
5 months ago

  • Keywords has-test-info has-screenshots added

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/11623

Environment

  • WordPress: 7.0-RC2-62242
  • PHP: 8.3.30
  • Server: nginx/1.26.1
  • Database: mysqli (Server: 8.0.35 / Client: mysqlnd 8.3.30)
  • Browser: Chrome 146.0.0.0
  • OS: macOS
  • Theme: Twenty Sixteen 3.7
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1
    • WordPress Beta Tester 4.0.0

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • Any additional details worth mentioning.

Supplemental Artifacts

Before: https://ibb.co/qL9zhk4P
After: https://ibb.co/1fr8tsyJ

Last edited 5 months ago by JayDeep Nimavat (previous) (diff)

#5 follow-up: @sabernhardt
5 months ago

  • Version trunk4.4

Like the normal font-style for em (#65107), the normal font-weight has been part of Twenty Sixteen since initial commit.

However, I do not understand the reason for reducing the font-weight for strong elements inside a blockquote.

If a change is appropriate now, I would prefer removing the ruleset instead of editing the value.

@sabernhardt
5 months ago

Quote blocks with em and strong elements within both the paragraph and the citation

#6 in reply to: ↑ 5 @gaelbonithon
5 months ago

Replying to sabernhardt:

Like the normal font-style for em (#65107), the normal font-weight has been part of Twenty Sixteen since initial commit.

However, I do not understand the reason for reducing the font-weight for strong elements inside a blockquote.

If a change is appropriate now, I would prefer removing the ruleset instead of editing the value.

Patch updated. For the editor, I took inspiration from your recommendations in #65107: I'm not sure if this is the best way to do it, but it works…

#7 @darshitrajyaguru97
5 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch Tested

https://github.com/WordPress/wordpress-develop/pull/11623

Environment

  • WordPress: 7.0-RC2-62242
  • PHP: 8.3.30
  • Server: nginx
  • Database: mysqli
  • Browser: Chrome
  • OS: Windows
  • Theme: Twenty Sixteen
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1
    • WordPress Beta Tester 4.0.0

Steps to Reproduce

  1. Install and set up WordPress with the above environment.
  2. Attempt to reproduce the reported issue on the unpatched version.
  3. Apply the patch from the PR.
  4. Re-test the same scenario.

Actual Results

  • ✅ Issue resolved with patch.
  • No unexpected errors or regressions observed.

Expected Results

  • The issue should be resolved after applying the patch. ✅

#8 @poena
4 months ago

  • Milestone Awaiting Review7.1

Hi
I don't feel strongly either way, pinging @iamtakashi @karmatosed as it is their theme, in case they have any opinions about the design of the quotes.

This ticket was mentioned in Slack in #core by adrianduffell. View the logs.


2 months ago

#10 @adrianduffell
2 months ago

  • Milestone 7.1Future Release

Moving this ticket to a future release, as it looks unlikely to be completed before the upcoming 7.1 beta.

#11 @sabernhardt
2 months ago

  • Keywords needs-design-feedback added

This probably should have agreement from one of the theme authors.

Note: See TracTickets for help on using tickets.