WordPress.org
Get WordPress

Make WordPress Core

Opened 8 weeks ago

Last modified 4 weeks ago

#65114 reviewing defect (bug)

Correct formatting of `$locked_text` in posts list table

Reported by: ankitkumarshah's profile ankitkumarshah Owned by: westonruter's profile westonruter
Milestone: 7.1 Priority: normal
Severity: normal Version: 7.0
Component: Posts, Post Types Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

The column_title() method in WP_Posts_List_Table has variable alignment
issues in locked_text that do not follow WordPress coding standards.

Steps to reproduce:

  1. Run PHPCS against src/wp-admin/includes/class-wp-posts-list-table.php
  2. Observe coding standards violations around line 1125. 
1125 | WARNING | [x] Equals sign not aligned correctly; expected 1 space but found 3 spaces
      |         |     (Generic.Formatting.MultipleStatementAlignment.IncorrectWarning)

Change History (3)

This ticket was mentioned in ​PR #11628 on ​WordPress/wordpress-develop by ​@ankitkumarshah.
8 weeks ago #1

  • Keywords has-patch added

#2 @westonruter
8 weeks ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 7.1
  • Owner set to westonruter
  • Status changed from new to reviewing
  • Version set to trunk

Introduced in r62074 (​25f2e83) for #64622.

The trunk branch is currently frozen for new commits due to 7.0. This can be committed once unfrozen.

#3 @audrasjb
4 weeks ago

Removing trunk version as this is not going to be shipped with WP 7.0 but in the next releases.

Note: See TracTickets for help on using tickets.