WordPress.org
Get WordPress

Make WordPress Core

Opened 6 months ago

Closed 3 months ago

#65114 closed defect (bug) (fixed)

Correct formatting of `$locked_text` in posts list table

Reported by: ankitkumarshah Owned by: westonruter
Priority: normal Milestone: 7.1
Component: Posts, Post Types Version: 7.0
Severity: normal Keywords: has-patch commit
Cc: Focuses: coding-standards

Description

The column_title() method in WP_Posts_List_Table has variable alignment
issues in locked_text that do not follow WordPress coding standards.

Steps to reproduce:

  1. Run PHPCS against src/wp-admin/includes/class-wp-posts-list-table.php
  2. Observe coding standards violations around line 1125. 
1125 | WARNING | [x] Equals sign not aligned correctly; expected 1 space but found 3 spaces
      |         |     (Generic.Formatting.MultipleStatementAlignment.IncorrectWarning)

Change History (5)

This ticket was mentioned in ​PR #11628 on ​WordPress/wordpress-develop by ​@ankitkumarshah.
6 months ago #1

  • Keywords has-patch added

#2 @westonruter
6 months ago

  • Keywords commit added
  • Milestone Awaiting Review → 7.1
  • Owner set to westonruter
  • Status new → reviewing
  • Version → trunk

Introduced in r62074 (​25f2e83) for #64622.

The trunk branch is currently frozen for new commits due to 7.0. This can be committed once unfrozen.

#3 @audrasjb
5 months ago

Removing trunk version as this is not going to be shipped with WP 7.0 but in the next releases.

#5 @wildworks
3 months ago

  • Resolution → fixed
  • Status reviewing → closed

I's like to close this as the incorrect format has already been fixed in trunk.

See: ​https://github.com/WordPress/wordpress-develop/pull/11628#issuecomment-5101559300

Note: See TracTickets for help on using tickets.