Opened 5 months ago
Last modified 11 days ago
#65122 new defect (bug)
Accessibility issues in Visual History
| Reported by: | joedolson | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.2 |
| Component: | Revisions | Version: | |
| Severity: | normal | Keywords: | needs-patch |
| Cc: | Focuses: | accessibility |
Description
Adding this ticket for aid in tracking progress, but the relevant work is in the Gutenberg repository.
See https://github.com/WordPress/gutenberg/issues/77530 for progress and sub-issues.
Change History (19)
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
5 months ago
This ticket was mentioned in Slack in #core by jorbin. View the logs.
4 months ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
4 months ago
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
4 months ago
This ticket was mentioned in Slack in #core by juanmaguitar. View the logs.
4 months ago
This ticket was mentioned in Slack in #core by jorbin. View the logs.
3 months ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
3 months ago
#9
@
3 months ago
@joedolson Are there specific PRs on the gutenberg side you are hoping to see land in 7.0.1 or should this get bumped to 7.1?
#10
follow-up:
↓ 11
@
2 months ago
@jorbin There are two I'd like to get in 7.0.1:
https://github.com/WordPress/gutenberg/pull/77779
and
https://github.com/WordPress/gutenberg/pull/79691
The latter is ready to merge, the former is pending some additional feedback from @ellatrix.
#11
in reply to: ↑ 10
@
2 months ago
Replying to joedolson:
@jorbin There are two I'd like to get in 7.0.1:
https://github.com/WordPress/gutenberg/pull/77779
and
https://github.com/WordPress/gutenberg/pull/79691
The latter is ready to merge, the former is pending some additional feedback from @ellatrix.
I just merged https://github.com/WordPress/gutenberg/pull/79691 for 7.0.1.
#12
@
2 months ago
If https://github.com/WordPress/gutenberg/pull/77779 doesn't make it for 7.0.1, I'll move this ticket to 7.0.2 to try and push it forward. If it does make it, then the rest of this can move to 7.1.
But it is a major accessibility issue for screen reader users.
This ticket was mentioned in Slack in #core by jorbin. View the logs.
2 months ago
#14
@
2 months ago
- Milestone 7.0.1 → 7.1
With the limited time before 7.0.1, only about one month remaining before 7.1, https://github.com/WordPress/gutenberg/pull/77779 involving substantial changes to core functionality, no 7.0.2 planned, and no Gutenberg release including this code for testing, the decision has been made to bump this to 7.1
#15
@
2 months ago
The "inline edits use the title attribute" item from the audit now has a PR on the Gutenberg side: https://github.com/WordPress/gutenberg/pull/80207
It adds aria-describedby to the del/ins/format-change formats, pointing at visually hidden description elements rendered into the canvas document, with title retained for the pointer tooltip. Unit-tested; I flagged in the PR that a live AT confirmation during review would be welcome.
#16
@
7 weeks ago
See also: https://github.com/WordPress/gutenberg/pull/80440, an alternate PR for the same fix.
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
7 weeks ago
#18
@
7 weeks ago
- Milestone 7.1 → 7.2
With both PR80440 and PR77779 merged and backported, I'm going to move this issue to 7.2 for the remaining concerns. There are still issues outstanding on the related Gutenberg issue, but it's largely resolved.
#19
@
11 days ago
PR https://github.com/WordPress/gutenberg/pull/82258 is open for the "Color contrast of marked del" item on the Gutenberg tracking issue.
It stops routing inline removed text through the #revision-removed-filtercolour matrix, which desaturated the text, added a red offset and dropped alpha to 0.8 - so the rendered contrast depended on the theme's own colours and couldn't be guaranteed by the rule. Inline <del> now keeps the body text colour with a red-tinted background and a red strike, matching how inline <ins> already renders. The filter is unchanged for removed blocks and images.
Not yet reviewed. Four items remain open on #77530.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
This is currently being addressed in https://github.com/WordPress/gutenberg/issues/77530 so this ticket is only a tracking ticket for this issue. Moving to 7.0.1.