Make WordPress Core

Opened 7 weeks ago

Closed 6 weeks ago

#65131 closed defect (bug) (fixed)

Administration: Spinners are misaligned

Reported by: wildworks's profile wildworks Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: admin-reskin has-patch commit dev-reviewed
Focuses: ui Cc:

Description

Spinners may appear to the left of buttons during certain actions. Many of these spinners are aligned with the buttons by applying top margin. However, due to a change in button size to 40px in accordance with the new design system, the alignment between the buttons and spinners is no longer correct.

Upon investigating the entire UI, misalignment has been observed in at least the following locations:

  • Classic Editor > Publish Sidebar > Update or Publish button
  • Classic Widget Editor > Save button
  • Posts > Tags > Add Tag button
  • Menus > Add to Menu button
  • Customize > Menus > Menu > Add Imtes > Custom Links > Add to Menu
  • Media (List view) > Edit > Edit Image button
  • Media (List view) > Edit > Update button
  • Media (List view) > Attach > Search input field

It seems that the positions of these two locations have been misaligned for some time.

  • Theme File Editor > Update File button
  • Plugin File Editor > Update File button

You can also force the spinner to be displayed by adding the following CSS:

.spinner {
  visibility: visible;
}

Attachments (1)

spinner.png (293.6 KB) - added by wildworks 7 weeks ago.
Compare the areas where issues are occurring between WP7.0 and 6.9

Download all attachments as: .zip

Change History (14)

@wildworks
7 weeks ago

Compare the areas where issues are occurring between WP7.0 and 6.9

#1 @wildworks
7 weeks ago

  • Summary changed from Editor: Spinners are misaligned to Administration: Spinners are misaligned

#2 @wildworks
7 weeks ago

  • Keywords needs-patch added

This ticket was mentioned in PR #11648 on WordPress/wordpress-develop by @anupkankale.


7 weeks ago
#3

  • Keywords has-patch added; needs-patch removed

Vertically centers the 20px spinner relative to the 40px button height introduced by the new admin design system. Formula: (40 - 20) / 2 = 10px.

  • Base .spinner: margin-top 4px → 10px
  • #publishing-action .spinner: remove stale 5px margin-top override
  • #addtag .spinner: vertical-align top → middle
  • .quick-search-wrap .spinner: margin-top -3px → 10px
  • .find-box-search .spinner: add explicit top: 10px for absolute position
  • widgets.css: split shared rule, update .remove-inactive-widgets margin

Fixes: https://core.trac.wordpress.org/ticket/65131

Trac ticket:

## Use of AI Tools

This ticket was mentioned in PR #11649 on WordPress/wordpress-develop by @wildworks.


7 weeks ago
#4

Trac ticket: <!-- insert a link to the WordPress Trac ticket here -->

### How to Test

Register the following code as a browser bookmark. This will make it easier to test by visualizing the .spinner element.

javascript:(()=>{document.querySelectorAll('.spinner').forEach(e=>e.style.visibility='visible')})();

### Screenshots

Classic Editor > Publish Sidebar > Update or Publish button

https://github.com/user-attachments/assets/07ce4e90-5668-4ee9-8b75-ba593f10ef5e

---

Classic Widget Editor > Save button

https://github.com/user-attachments/assets/ecfd77bf-0623-41e2-a225-b13a0acd6b89

---

Posts > Tags > Add Tag button

https://github.com/user-attachments/assets/768f4ed3-19eb-4dfd-beb9-ab06d90cb661

---

Menus > Add to Menu button

https://github.com/user-attachments/assets/ef1e0b04-d018-4b9d-afc9-dd0071b2bba7

---

Customize > Menus > Menu > Add Items > Custom Links > Add to Menu

https://github.com/user-attachments/assets/05e21b9c-d52f-40e9-a7f6-aa014701aa0c

---

Media (List view) > Edit > Edit Image button

https://github.com/user-attachments/assets/d6db1af2-865d-44d4-b4bd-ef9ab5d5a07e

---

Media (List view) > Edit > Update button

https://github.com/user-attachments/assets/7d4e1cf9-c93e-4705-81a1-c6d2bf2c3e6a

---

Media (List view) > Attach > Search input field

https://github.com/user-attachments/assets/42ffe0f2-6fae-4c17-ac9f-ae84ff2988a4

---

Theme File Editor > Update File button

https://github.com/user-attachments/assets/2e341dec-e99d-48d0-ab2c-f7082d5de441

---

Plugin File Editor > Update File button

https://github.com/user-attachments/assets/74367dee-8c3e-4b5d-a080-9bee0cf44395

## Use of AI Tools

#5 @gaurangsondagar
7 weeks ago

Patch Testing Report

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/11649

Environment:

  • PHP: 8.2.29
  • WordPress: 7.0-RC2-62242
  • Web server: Apache
  • Database: MySQL
  • Browser: Chrome
  • OS: Ubuntu 22.04.5 LTS

Active Plugins:

  • AI
  • AI Provider for Google
  • AI Provider for OpenAI

Steps performed:

  • Before applying the patch, I tested the admin screens and found that the button spinners were misaligned. After applying the patch, I retested and confirmed that the button spinners are now correctly aligned in the required areas.

Result:
The patch is working as expected and has resolved the issue of misaligned button spinners.

Screenshots for reference:

Before Applying the patch:
https://snipboard.io/a49jmM.jpg
https://snipboard.io/IThVWq.jpg
https://snipboard.io/jBEYCX.jpg
https://snipboard.io/wj2kgB.jpg
https://snipboard.io/qPXpmz.jpg

After Applying the patch:
https://snipboard.io/Z1BVeO.jpg
https://snipboard.io/0FYWLx.jpg
https://snipboard.io/YXE8Gn.jpg

Last edited 7 weeks ago by gaurangsondagar (previous) (diff)

@shailu25 commented on PR #11649:


7 weeks ago
#6

Spinners Alignment Issue is Resolved ✅

Classic Editor Add / Edit Post:

BeforeAfter
https://github.com/user-attachments/assets/58560bc3-a3f3-465c-a967-fa6f01792d6fhttps://github.com/user-attachments/assets/28d16536-5a0d-4d2a-976f-46da1c713439

Classic Widget Editor: Save Button:

BeforeAfter
https://github.com/user-attachments/assets/0c87d4e2-4180-4500-9178-00454f5eccd3https://github.com/user-attachments/assets/9c599fd9-193a-452a-93d7-1fbf1dfb8f18

Add Tag Button:

BeforeAfter
https://github.com/user-attachments/assets/937e7b82-f0ac-489e-be6f-502e137964b6https://github.com/user-attachments/assets/6cfd7eee-776a-4b2b-baa2-ca3225b63fb3

Add Menu Item:

BeforeAfter
https://github.com/user-attachments/assets/aba509a8-bf37-4da9-9ec6-077361c84f17https://github.com/user-attachments/assets/8a1eda71-e988-4967-87ee-2d5fc2e515eb

Customizer: Add Custom Link Menu Item:

BeforeAfter
https://github.com/user-attachments/assets/0d910e29-c12f-43ee-869d-af7cc0d55b8chttps://github.com/user-attachments/assets/855afeeb-8aa1-4718-bad5-bc3455d931b2

Media: Edit Image button

BeforeAfter
https://github.com/user-attachments/assets/448b14e0-14ea-4fb4-bad8-5807b960e616https://github.com/user-attachments/assets/aee39e4e-e218-4431-9b44-b25ddac53c9c

Media: Update button

BeforeAfter
https://github.com/user-attachments/assets/3d81bac2-51d7-4095-a620-285202b1a385https://github.com/user-attachments/assets/2e7c8f7b-5d01-46b6-9dbb-3c0d04fab5b3

Theme File Editor - Update File button

BeforeAfter
https://github.com/user-attachments/assets/a7cc25a0-7a9d-4510-bbb6-fa7e72b67a26https://github.com/user-attachments/assets/e3c89299-1875-4c2c-a636-8fe713e785ae

Plugin File Editor - Update File button

BeforeAfter
https://github.com/user-attachments/assets/ce13cd2b-876a-4f67-9f8e-fcf5e656ce57https://github.com/user-attachments/assets/ca10b164-75df-4d36-ab03-a0a1e2d5ff11

This ticket was mentioned in Slack in #core-test by nikunj8866. View the logs.


7 weeks ago

#9 @jadavsanjay
7 weeks ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Patch tested: https://core.trac.wordpress.org/ticket/65131

Environment

  • WordPress: 7.1-alpha-20260427.042324
  • PHP: 7.4.33
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
  • Browser: Chrome 147.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins: None activated
  • Plugins:
    • Classic Editor and Classic Widgets 1.5.1
    • Test Reports 1.2.1

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • Button spinners are now correctly aligned in the required areas after applying the patch.

Supplemental Artifacts

https://i.postimg.cc/2SmBK20j/1.png
https://i.postimg.cc/htg75p2h/2.png
https://i.postimg.cc/P5h8R2SC/3.png
https://i.postimg.cc/W1nJLgy1/4.png

#10 @SergeyBiryukov
6 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 62291:

Admin Reskin: Correct alignment for spinners across the admin.

Follow-up to [61646].

Props wildworks, anupkankale, shailu25, gaurangsondagar, jadavsanjay, SergeyBiryukov.
Fixes #65131.

@SergeyBiryukov commented on PR #11649:


6 weeks ago
#11

Thanks for the PR! Merged in r62291.

#12 @SergeyBiryukov
6 weeks ago

  • Keywords commit dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 7.0 consideration.

#13 @peterwilsoncc
6 weeks ago

  • Keywords dev-reviewed added; dev-feedback removed

r62291 approved for merge to the 7.0 brnahc.

#14 @peterwilsoncc
6 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 62303:

Admin Reskin: Correct alignment for spinners across the admin.

Follow-up to [61646].

Reviewed by peterwilsoncc.
Merges r62291 to the 7.0 branch.

Props wildworks, anupkankale, shailu25, gaurangsondagar, jadavsanjay, SergeyBiryukov.
Fixes #65131.

Note: See TracTickets for help on using tickets.