Fix alignment for sortable metabox on post and page edit screen with classic editor

[umesh.nevase]

When the Classic Editor is selected as the default editor in the Writing Settings, the sortable metabox container on the post/page edit screen includes an extra 4px of padding. This results in a 4px misalignment of the metabox container with Classic Editor and other UI elements on the page.

Debugging confirms that this padding is only applied when the Classic Editor is active. Since it serves no identifiable purpose other than for these metaboxes, it can be safely removed to restore alignment. This change was originally introduced in Changeset [61646].

[umesh.nevase]

screenshot for extra padding and misalignment

This PR fixes alignment issue for meta-box-sortables with the editor.
In this PR I've remove extra 4px padding added to metabox container.

[sabernhardt]

[61646] added the 4-pixel padding to sortable metaboxes in the dashboard, classic post editor, and media editor.

Then [61759] set the dashboard widgets' padding to 0, which does not seem necessary if the padding is removed from all of them.

[SergeyBiryukov]

In 62284:

Administration: Correct alignment of meta boxes on the Edit screen with classic editor.

Follow-up to [61646], [61759].

Props umeshnevase, sabernhardt, SergeyBiryukov.
Fixes #65141.

Thanks for the PR! Merged in r62284.

[SergeyBiryukov]

Reopening for 7.0 consideration.

[peterwilsoncc]

r62284 approved for merging to the 7.0 branch.

[peterwilsoncc]

In 62285:

Administration: Correct alignment of meta boxes on the Edit screen with classic editor.

Follow-up to [61646], [61759].

Reviewed by peterwilsoncc.
Merges r62284 to the 7.0 branch.

Props umeshnevase, sabernhardt, SergeyBiryukov.
Fixes #65141.

[TobiasBg]

Replying to sabernhardt:

[61646] added the 4-pixel padding to sortable metaboxes in the dashboard, classic post editor, and media editor.

So, the padding was now removed again, but [61646] also added a negative -4px margin on #poststuff #post-body. I think this should be reverted as well, as it otherwise pulls the editor to the left a bit (with Classic Editor).

​@TobiasBg has suggested to remove negative -4px margin on #poststuff #post-body that pulling post-body to left. This margin is not required.Here

This margin was added in changeset for admin reskin https://core.trac.wordpress.org/changeset/61646

[umesh.nevase]

Yes, we can revert negative -4px margin on #poststuff #post-body which is not required. [PR]​https://github.com/WordPress/wordpress-develop/pull/11689

Thanks for creating a PR! I think the margin declaration can be removed in full, as it was only added via https://core.trac.wordpress.org/changeset/61646/trunk/src/wp-admin/css/edit.css and did not exist before.

[peterwilsoncc]

Doing some keyword management to tidy up the workflow report.

[jorbin]

As noted, the patch needs an update. @umeshnevase - Are you able to handle that?

Thanks for creating a PR! I think the margin declaration can be removed in full, as it was only added via https://core.trac.wordpress.org/changeset/61646/trunk/src/wp-admin/css/edit.css and did not exist before.

Thanks for pointing out that margin declaration, I've removed unwanted margin declaration.