canonical redirect doesn't redirect ?name=slug

[Denis-de-Bernardy]

domain.com?name=test doesn't seem to be redirecting to domain.com/2008/03/31/test/

[Denis-de-Bernardy]

same goes for pagename, and presumable others

[DD32]

I believe that'd be the expected result, at least with the 2.5 branch.

If you were to try domain.com/test it would indeed redirect as expected.

AFAIK, It ignores query vars which it doesnt know about. If you were to access domain.com?p=<post id> then it'd also redirect.

[Denis-de-Bernardy]

mm, aren't name and pagename (and several others) built-in query vars for WP? If WP cannot reliably redirect things other than ?p=ID, it's really not worth calling this a canonical permalink feature (or whatever it's called). I'd hate to have to reinstall permalink redirect... :-|

[DD32]

attachment 6516.diff added.

• Redirects ?name and ?pagename to their permalinks
• WP_Query changes:
  • supports querying based on 'pagename' for pages which are not a static front page
  • if ( !empty($reqpage) ) was added to prevent querying for page_id == 0, which happens when pagename is a slug & a the page is a subpage (in that case, get_page_by_path() will fail)
  • if ('' != $q['name']) block was moved after page/attachment code to reduce duplicate code

[DD32]

Hmm.. Those changes to WP_Query may've been in the wrong thinking, Page slugs are not unique (as is with attachments/posts)

[Denis-de-Bernardy]

true, but isn't redirecting to something plausible better than outputting a 404?

[ryan]

is_single() and is_page() mean we requested a single object. Can we not use get_queried_object_id() and pass that to get_permalink()?

[Denis-de-Bernardy]

Imo, we should close this one, and open a grand ticket: Enforce permalink history across the board.

[DD32]

Can we not use get_queried_object_id() and pass that to get_permalink()?

Yes, Yes we can. (Except that i'm not aware of the usage of function such as those :))

[Denis-de-Bernardy]

Replying to DD32:

Can we not use get_queried_object_id() and pass that to get_permalink()?

Yes, Yes we can. (Except that i'm not aware of the usage of function such as those :))

Like this:

get_permalink($wp_query->get_queried_object_id());

[Denis-de-Bernardy]

Bumping to Future

[ryan]

(In [11745]) Canonical redirects for post name queries. Props DD32. see #6516