Make WordPress Core

Opened 5 weeks ago

Closed 4 weeks ago

#65187 closed enhancement (fixed)

Tests: Add unit tests for wp_admin_viewport_meta()

Reported by: pbearne's profile pbearne Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 7.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch has-unit-tests
Focuses: tests Cc:

Description

This ticket adds comprehensive unit tests for the wp_admin_viewport_meta() function in wp-admin/includes/misc.php. The tests will cover the default meta tag generation, the admin_viewport_meta filter, and proper attribute escaping.

Change History (4)

This ticket was mentioned in PR #11744 on WordPress/wordpress-develop by @pbearne.


5 weeks ago
#1

  • Keywords has-patch has-unit-tests added

….php
Description:
This PR adds unit tests for the wp_admin_viewport_meta() function in wp-admin/includes/misc.php. These tests ensure that the function correctly outputs the viewport meta tag, handles the admin_viewport_meta filter, and properly escapes the content attribute.

The tests cover:

  • Default viewport meta output.
  • Custom viewport meta via the admin_viewport_meta filter.
  • Ensuring no output is generated when the filtered value is empty.
  • Security verification of attribute escaping in the output.

Trac ticket: https://core.trac.wordpress.org/ticket/65187

AI Disclosure:

  • AI assistance: Yes
  • Tool(s): Junie (JetBrains)
  • Model(s): gemini-3-flash-preview
  • Used for: Code analysis, test implementation, and workflow management.

#2 @desrosj
5 weeks ago

  • Focuses tests added

Adding the tests focus, which is used to indicate a ticket is solely focused on adding tests.

#3 @SergeyBiryukov
4 weeks ago

  • Milestone changed from Awaiting Review to 7.1

#4 @SergeyBiryukov
4 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 62366:

Tests: Add unit tests for wp_admin_viewport_meta().

Follow-up to [48412].

Props pbearne.
Fixes #65187.

Note: See TracTickets for help on using tickets.