WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#6521 closed enhancement (fixed)

Highlight the http:// in the Link pop-up in TinyMCE

Reported by: azaozz Owned by: westi
Milestone: 2.5.1 Priority: normal
Severity: minor Version: 2.5
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

Highlights the pre-filled http:// in the href field in the Link pop-up in TinyMCE, silenced on error.

Attachments (1)

highlight-http.patch (801 bytes) - added by azaozz 6 years ago.

Download all attachments as: .zip

Change History (6)

azaozz6 years ago

comment:1 westi6 years ago

  • Owner changed from anonymous to westi
  • Status changed from new to assigned

If this a significantly better way to do this than the old way highlighyed by andy on wp-testers:

http://trac.wordpress.org/browser/tags/2.3.2/wp-includes/js/tinymce/themes/advanced/jscripts/link.js#L28

Changes to TinyMCE in prior versions were flagged with "WordPress". A
search of the codebase should find any others that might have been
lost in the update.

comment:2 azaozz6 years ago

Better? No, it's about the same. However the file /tinymce/themes/advanced/js/link.js is completely changed in 3.0, so the select() is moved to inline js (where it would probably need less maintenance).

Also some of the enhancements made to TinyMCE 2.x in WordPress are now part of TinyMCE 3.0, like the auto-selecting of the first text field in a popup, closing of the popup when pressing Esc, etc.

comment:3 westi6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7597]) Select the link in the link popup again. Fixes #6521 for trunk props azaozz.

comment:4 westi6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 2.5.1

comment:5 westi6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [7598]) Select the link in the link popup again. Fixes #6521 for 2.5.1 props azaozz.

Note: See TracTickets for help on using tickets.