Make WordPress Core

Opened 5 months ago

Closed 2 months ago

#65246 closed defect (bug) (fixed)

Add Data Export Request: Confirmation email checkbox is not properly aligned

Reported by: soyebsalar01 Owned by: joedolson
Priority: normal Milestone: 7.1
Component: Privacy Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: ui, accessibility, css

Description

The checkbox on the "Add Data Export Request" page is not
properly vertically aligned with the "Send personal data
export confirmation email." label text.

Steps To Reproduce

  1. Go to Tools > Export Personal Data.
  2. Observe the "Confirmation email" field.
  3. Check the alignment of the checkbox with the label text.

Refer Bolow Image :

​https://postimg.cc/xkmS4pz9

Change History (13)

#1 @soyebsalar01
5 months ago

  • Version → trunk

This ticket was mentioned in ​PR #11840 on ​WordPress/wordpress-develop by ​@suryakantupadhyay.


5 months ago
#2

  • Keywords has-patch added; needs-patch removed

## Summary

Adds missing checkbox alignment styling for the personal data export / erase request form.

The RTL stylesheet already contains this rule, but it was missing from the standard forms stylesheet, causing the confirmation email checkbox to appear vertically misaligned on the "Export Personal Data" and "Erase Personal Data" screens.

Trac ticket: https://core.trac.wordpress.org/ticket/65246

## Use of AI Tools

AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5
Used for: Verifying existing RTL stylesheet rules and contribution workflow guidance.

This ticket was mentioned in ​PR #11841 on ​WordPress/wordpress-develop by ​@deepakprajapati.


5 months ago
#3

## What?

Fixes the alignment of the confirmation email checkbox on the Add Data Export Request form.

## Why?

The privacy request form was resetting margins for all inputs in src/wp-admin/css/forms.css around line 1578:

.wp-privacy-request-form input {
        margin: 0;
}

This overrode the default checkbox/radio margin declared in the same file around line 126:

input[type="checkbox"],
input[type="radio"] {
        margin: -0.25rem 0.25rem 0 0;
}

As a result, the checkbox in src/wp-admin/export-personal-data.php around line 130 appeared vertically misaligned with its label.

## How?

Narrows the privacy request form selector so checkbox and radio inputs keep the default admin form control spacing, while other inputs continue to have their margins reset.

## Screenshots

Before After
https://github.com/user-attachments/assets/f341e119-f00c-43c7-a5ae-10725ad35419 https://github.com/user-attachments/assets/06dd9698-7663-4eb4-9ab4-717b435ddfbe

## Testing Instructions

  1. Go to Tools > Export Personal Data.
  2. Check the Confirmation email field.
  3. Confirm the checkbox is vertically aligned with the “Send personal data export confirmation email.” label.
  4. Go to Tools > Erase Personal Data.
  5. Confirm the same checkbox alignment still looks correct there.

## Trac

https://core.trac.wordpress.org/ticket/65246

## Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5
Used for: Testing guidance, CSS fix suggestion. Final changes were reviewed and edited by me.

#4 @audrasjb
5 months ago

Removing trunk version as this is not going to be shipped with WP 7.0 but in the next releases.

#5 @audrasjb
5 months ago

  • Milestone Awaiting Review → 7.1
  • Version trunk

#6 @joedolson
3 months ago

  • Component General → Privacy

This ticket was mentioned in ​Slack in #core by adrianduffell. ​View the logs.


2 months ago

#8 @adrianduffell
2 months ago

This looks close with a simple PR. Does anyone have the bandwidth to shepherd it through before the 7.1 RC 1 release?

#9 @joedolson
2 months ago

  • Owner set to joedolson
  • Status new → accepted

#10 @joedolson
2 months ago

  • Keywords commit added

#11 @joedolson
2 months ago

  • Focuses accessibility added

I'm adding the accessibility focus, as well, as I'm noticing that these checkboxes use implicit labeling, and WordPress generally prefers to use explicit labeling when possible. In this case, there are no back compat concerns about switching the labeling type, so I'm adding it in.

​@masteradhoc commented on ​PR #11841:


2 months ago
#12

Thank you @deepakpra for the PR and to all the reviewers!

This looks good and is good to go
https://github.com/user-attachments/assets/51ad7e83-d416-4a4a-9b0f-1f4591147805
https://github.com/user-attachments/assets/2878122a-bb47-43a5-9801-978d46a72fa5

#13 @joedolson
2 months ago

  • Resolution → fixed
  • Status accepted → closed

In 63011:

Privacy: Fix checkbox alignment in request form.

The margins were set to 0 for all inputs in the request form, breaking the alignment for the checkbox.

Limit margin resetting to inputs of type text. Change labeling from implicit to explicit labelling, to better support voice control users.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/11841

Props soyebsalar01, suryakantupadhyay, deepakprajapati, audrasjb, joedolson, adrianduffell, mukesh27, wildworks, masteradhoc.
Fixes #65246.

Note: See TracTickets for help on using tickets.