WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #6531, comment 51


Ignore:
Timestamp:
10/02/2017 07:33:00 PM (7 years ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6531, comment 51

    initial v1  
    1 I've applied some fixes to PHP code style which were identified by [https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards PHPCS].
     1I've applied some fixes to PHP code style which were identified by [https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards PHPCS]. See [attachment:6531.7.diff] (and [https://github.com/xwp/wordpress-develop/pull/271/commits/f80a849 delta]).
    22
    33In addition to @schlessera's great feedback, one thing that became clear to me in testing the patch is that we should absolutely ignore certain directories from being traversed. I'm thinking `node_modules`, `vendor`, and `bower_components` to start. The list of files can get so incredibly long that it just becomes impossible to navigate. I don't think we can safely throw this on users if we don't also tackle #41729.