Context Navigation

← Previous Ticket
Next Ticket →

#65389 closed defect (bug) (fixed)

Block Visibility: Keep hide-everywhere working after a block opts out of visibility support

Reported by:	wildworks	Owned by:	wildworks
Priority:	normal	Milestone:	7.0.1
Component:	Editor	Version:
Severity:	normal	Keywords:	gutenberg-merge has-patch has-unit-tests dev-feedback
Cc:		Focuses:

Description

Gutenberg Issue: https://github.com/WordPress/gutenberg/issues/78701
Gutenberg PR: https://github.com/WordPress/gutenberg/pull/78780
Block Visibility in WordPress 7.0

The block content is not displayed on the front end when the block supports visibility and metadata.blockVisibility is true.

Previously, the Shortcode block and the HTML block supported visibility. However, this support was removed because it was found that the responsive hiding feature introduced in WordPress 7.1 did not work with these blocks.

As a result, even if these blocks were already hidden in WordPress 6.9, their content would unintentionally be displayed upon updating to WordPress 7.0.

Since this clearly goes against the user's intent, I propose that we do not display the block content on the front end whenever metadata.blockVisibility is true, regardless of whether the visibility block supports.

Change History (6)

This ticket was mentioned in PR #12053 on WordPress/wordpress-develop by @wildworks.

7 weeks ago #1

Keywords has-patch has-unit-tests added

Gutenberg PR: https://github.com/WordPress/gutenberg/pull/78780
Trac ticket: https://core.trac.wordpress.org/ticket/65389

## Use of AI Tools
None

#2 @tusharaddweb
6 weeks ago

Tested with an existing post containing a Shortcode/HTML block that had metadata.blockVisibility = true set before the visibility support was removed.

After applying the patch, the block remained hidden on the frontend as expected. Without the patch, the content became visible. The fix addresses the backward-compatibility issue described in the ticket.

@masteradhoc commented on PR #12053:

3 weeks ago #3

Thanks @t-hamano for this PR! This works well for me now applying both the newest GB Version and this core fix.
Waiting for a commiter review to get this into WP 7.0.1

#4 @wildworks
3 weeks ago

Owner set to wildworks
Resolution → fixed
Status new → closed

In 62586:

Editor: Always hide blocks with visibility set to false.

After a block stopped supporting visibility, a block that had been set to hide everywhere would show up again on the front end.

The check is now reordered, so a block set to hide everywhere stays hidden, whether or not the block still supports visibility.

Props masteradhoc, ramonopoly, tusharaddweb wildworks.
Fixes #65389.

#5 @wildworks
3 weeks ago

Keywords dev-feedback added
Resolution fixed
Status closed → reopened

Reopening #65389 to request backporting [62586] to 7.0 branch

#6 @cbravobernal
3 weeks ago

Resolution → fixed
Status reopened → closed

In 62608:

Editor: Always hide blocks with visibility set to false.

After a block stopped supporting visibility, a block that had been set to hide everywhere would show up again on the front end.

The check is now reordered, so a block set to hide everywhere stays hidden, whether or not the block still supports visibility.

Reviewed by cbravobernal.
Merges [62586] to the 7.0 branch.

Props masteradhoc, ramonopoly, tusharaddweb wildworks.
Fixes #65389.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#65389 closed defect (bug) (fixed)

Block Visibility: Keep hide-everywhere working after a block opts out of visibility support

Description

Change History (6)

This ticket was mentioned in ​PR #12053 on ​WordPress/wordpress-develop by ​@wildworks. 7 weeks ago #1

#2 @tusharaddweb 6 weeks ago

​@masteradhoc commented on ​PR #12053: 3 weeks ago #3

#4 @wildworks 3 weeks ago

#5 @wildworks 3 weeks ago

#6 @cbravobernal 3 weeks ago