Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#6539 closed defect (bug) (fixed)

404 page does not appear when using static home page

Reported by: natecook's profile natecook Owned by: ryan's profile ryan
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: has-patch tested
Focuses: Cc:

Description

If an installation is configured to have the home page set to a static page, with the "Front page" set but the "Posts page" unset, instead of the 404 template showing up when necessary, all pages are loaded and displayed.

Attachments (3)

query-404.diff (597 bytes) - added by natecook 16 years ago.
Patch for fix
6539.patch (646 bytes) - added by tenpura 16 years ago.
Patch for 2.5 branch. Typecasts $reqpage to string to make the conditional work properly.
6539-modified.patch (647 bytes) - added by azmeen 16 years ago.
Patch 6539.patch didn't work for me. Merged the additional equal sign fix from the query-404.diff patch and tested working on WordPress 2.5.1.

Download all attachments as: .zip

Change History (23)

@natecook
16 years ago

Patch for fix

#1 @mtekk
16 years ago

  • Keywords has-patch added

On r7591 I'm not seeing a error, if I enter garbage in the browser's navigation bar I get the 404 page as expected. Is there anything in particular that it should be doing?

#2 @zoombody
16 years ago

I encountered this after upgrading from 2.3.3, and reproduced it on a clean 2.5 installation. The patch corrected the issue.

#3 @zoombody
16 years ago

  • Keywords tested added

#4 @lloydbudd
16 years ago

  • Milestone changed from 2.7 to 2.6

#5 @zoombody
16 years ago

  • Milestone changed from 2.6 to 2.5.1

I'm not sure whether it's cool for a non-developer to change milestones, but here goes.

#6 @Nazgul
16 years ago

  • Milestone changed from 2.5.1 to 2.6

Usually we milestone for the current development version (or the next one if no patch is attached) and once it's comitted and deemed important enough it will be backported for a maintenance release.

#7 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7605]) Explicit ID check so we don't fall through for empties. Props natecook. fixes #6539 for 2.6

#8 @ryan
16 years ago

(In [7606]) Explicit ID check so we don't fall through for empties. Props natecook. fixes #6539 for 2.5

#9 @ryan
16 years ago

  • Milestone changed from 2.6 to 2.5.1

This is one looked safe for 2.5.1, committed.

#10 @ryan
16 years ago

(In [7622]) Revert [7605]. It breaks setting posts page. see #6539

#11 @ryan
16 years ago

(In [7623]) Revert [7606]. It breaks setting posts page. see #6539

#12 @ryan
16 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#13 follow-up: @tenpura
16 years ago

The patch typecasts $reqpage to integer temporarily only when 404. This way it won't break setting posts page.

#14 in reply to: ↑ 13 @tenpura
16 years ago

The patch typecasts $reqpage to integer temporarily only when 404. This way it won't break setting posts page.

The patch typecasts $reqpage to string.

#15 @tenpura
16 years ago

I updated 6539.patch. It does almost the same thing, but less code.

@tenpura
16 years ago

Patch for 2.5 branch. Typecasts $reqpage to string to make the conditional work properly.

@azmeen
16 years ago

Patch 6539.patch didn't work for me. Merged the additional equal sign fix from the query-404.diff patch and tested working on WordPress 2.5.1.

#16 @ryan
16 years ago

  • Owner changed from anonymous to ryan
  • Status changed from reopened to new

#17 @ryan
16 years ago

(In [7905]) Fix page 404 when page_for_posts is empty. see #6539

#18 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [8099]) Fix page 404 when page_for_posts is empty. fixes #6539

#19 @ryan
16 years ago

  • Milestone changed from 2.5.2 to 2.9

Milestone 2.5.2 deleted

#20 @westi
16 years ago

  • Milestone changed from 2.9 to 2.6
Note: See TracTickets for help on using tickets.