Make WordPress Core

Opened 18 years ago

Closed 18 years ago

Last modified 4 months ago

#6544 closed defect (bug) (fixed)

TinyMCE HTTPS handling

Reported by: blenjee's profile blenjee Owned by: azaozz's profile azaozz
Milestone: 2.5.1 Priority: normal
Severity: normal Version: 2.5
Component: TinyMCE Keywords: tinymce https has-patch
Focuses: Cc:

Description

In /wp-includes/js/tiny_mce/tiny_mce_config.php, line 52 should read:

if ( $https ) $baseurl = str_replace('http://', 'https://', $baseurl);

and line 56 should read:

if ( $https ) $mce_css = str_replace('http://', 'https://', $mce_css);

At present (2.5) the replaced string is not being assigned, so when using HTTPS (with, for example, the admin-ssl plugin) the TinyMCE CSS files are being called using HTTP.

Attachments (2)

6544.diff (898 bytes) - added by Nazgul 18 years ago.
6544.2.diff (1.0 KB) - added by azaozz 18 years ago.
Includes the above patch plus one more place that needed fixing.

Download all attachments as: .zip

Change History (14)

#1 @blenjee
18 years ago

  • Severity changed from normal to blocker

#2 @Nazgul
18 years ago

  • Keywords has-patch added
  • Milestone set to 2.6
  • Severity changed from blocker to normal

Patch attached, based on the given code snippets.

Also a candidate for 2.5.1.

@Nazgul
18 years ago

#3 @lloydbudd
18 years ago

  • Owner changed from anonymous to azaozz

@azaozz
18 years ago

Includes the above patch plus one more place that needed fixing.

#4 @azaozz
18 years ago

  • Milestone changed from 2.6 to 2.5.1

#5 @matt
18 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7602]) Allow TinyMCE to work under SSL. Fixes #6544. Hat tip: blenjee, azaozz.

#6 @Nazgul
18 years ago

  • Milestone changed from 2.5.1 to 2.6

It was fixed in trunk.

Maybe backport it to 2.5.1?

#7 @craigandrews
18 years ago

  • Milestone changed from 2.6 to 2.5.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Yes - please backport to 2.5.1. My company requires the use of HTTPS for sites requiring login, so this a maintenance hassle for me as the admin :-/

(not sure if I'm breaking protocol by changing the milestone and re-opening - if so, my apologies!)

Thanks!

#8 @ryan
18 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [7675]) Allow TinyMCE to work under SSL. Fixes #6544 for 2.5. Hat tip: blenjee, azaozz.

This ticket was mentioned in PR #6558 on WordPress/wordpress-develop by @szepe.viktor.


2 years ago
#9

  • Keywords changed from tinymce, https has-patch to tinymce https has-patch

@szepe.viktor commented on PR #6558:


8 months ago
#10

@SergeyBiryukov Hello 👋🏻
Could you help me decide the faith of this PR?

@westonruter commented on PR #6558:


4 months ago
#11

There are theme CSS files generated from SASS which would also benefit from linguist-generated as well.

@westonruter commented on PR #6558:


4 months ago
#12

There are theme CSS files generated from SASS which would also benefit from linguist-generated as well.

Namely, these files I believe:

  • src/wp-content/themes/twentynineteen/style-editor.css
  • src/wp-content/themes/twentynineteen/style-rtl.css
  • src/wp-content/themes/twentynineteen/style.css
  • src/wp-content/themes/twentytwentyone/style-rtl.css
  • src/wp-content/themes/twentytwentyone/style.css
  • src/wp-content/themes/twentytwentyone/assets/css/style-editor.css
  • src/wp-content/themes/twentytwentyone/assets/css/ie-editor.css
  • src/wp-content/themes/twentytwentyone/assets/css/ie.css

However, it would be better if they were .gitignore'd in the first place like minified CSS files in Twenty Twenty-Two and Twenty Twenty-Five as of 6.9. See Core-63012. But this would probably be done as part of Core-64109.

Note: See TracTickets for help on using tickets.