WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#6544 closed defect (bug) (fixed)

TinyMCE HTTPS handling

Reported by: blenjee Owned by: azaozz
Milestone: 2.5.1 Priority: normal
Severity: normal Version: 2.5
Component: TinyMCE Keywords: tinymce, https has-patch
Focuses: Cc:

Description

In /wp-includes/js/tiny_mce/tiny_mce_config.php, line 52 should read:

if ( $https ) $baseurl = str_replace('http://', 'https://', $baseurl);

and line 56 should read:

if ( $https ) $mce_css = str_replace('http://', 'https://', $mce_css);

At present (2.5) the replaced string is not being assigned, so when using HTTPS (with, for example, the admin-ssl plugin) the TinyMCE CSS files are being called using HTTP.

Attachments (2)

6544.diff (898 bytes) - added by Nazgul 7 years ago.
6544.2.diff (1.0 KB) - added by azaozz 7 years ago.
Includes the above patch plus one more place that needed fixing.

Download all attachments as: .zip

Change History (10)

comment:1 @blenjee7 years ago

  • Severity changed from normal to blocker

comment:2 @Nazgul7 years ago

  • Keywords has-patch added
  • Milestone set to 2.6
  • Severity changed from blocker to normal

Patch attached, based on the given code snippets.

Also a candidate for 2.5.1.

@Nazgul7 years ago

comment:3 @lloydbudd7 years ago

  • Owner changed from anonymous to azaozz

@azaozz7 years ago

Includes the above patch plus one more place that needed fixing.

comment:4 @azaozz7 years ago

  • Milestone changed from 2.6 to 2.5.1

comment:5 @matt7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7602]) Allow TinyMCE to work under SSL. Fixes #6544. Hat tip: blenjee, azaozz.

comment:6 @Nazgul7 years ago

  • Milestone changed from 2.5.1 to 2.6

It was fixed in trunk.

Maybe backport it to 2.5.1?

comment:7 @craigandrews7 years ago

  • Milestone changed from 2.6 to 2.5.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Yes - please backport to 2.5.1. My company requires the use of HTTPS for sites requiring login, so this a maintenance hassle for me as the admin :-/

(not sure if I'm breaking protocol by changing the milestone and re-opening - if so, my apologies!)

Thanks!

comment:8 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [7675]) Allow TinyMCE to work under SSL. Fixes #6544 for 2.5. Hat tip: blenjee, azaozz.

Note: See TracTickets for help on using tickets.