Make WordPress Core

Opened 6 weeks ago

Last modified 6 weeks ago

#65704 new defect (bug)

Some plugins which use a menu icon that is too large are breaking the admin side menu.

Reported by: damndealdone Owned by:
Priority: normal Milestone: Awaiting Review
Component: Menus Version:
Severity: normal Keywords: reporter-feedback close
Cc: Focuses:

Description

Hello.

Some plugins which use a menu icon that is too large are breaking the admin side menu.

Please add overflow:hidden to...

#adminmenu div.wp-menu-image {

float: left;
width: 36px;
height: 34px;
margin: 0;
text-align: center;

}

See attachments.

Attachments (4)

plugin icon break code.png (11.6 KB ) - added by damndealdone 6 weeks ago.
Shows the before code.
plugin icon fix code.png (10.9 KB ) - added by damndealdone 6 weeks ago.
Shows the fixed code.
plugin icon fix.png (13.3 KB ) - added by damndealdone 6 weeks ago.
Shows the fixed admin side menu.
plugin icon break.png (19.7 KB ) - added by damndealdone 6 weeks ago.
Shows the broken admin side menu.

Download all attachments as: .zip

Change History (9)

@damndealdone
6 weeks ago

Shows the before code.

@damndealdone
6 weeks ago

Shows the fixed code.

@damndealdone
6 weeks ago

Shows the fixed admin side menu.

@damndealdone
6 weeks ago

Shows the broken admin side menu.

#1 @damndealdone
6 weeks ago

Or restrict image size to show the image.

Before...

#adminmenu .wp-menu-image img {

padding: 9px 0 0;
opacity: .6;

}

After...

#adminmenu .wp-menu-image img {

padding: 9px 0 0;
opacity: .6;
max-width: 20px;

}

#2 follow-up: @joedolson
6 weeks ago

Can you share what plugin is generating this problem? It seems very plausible that this is something that can be dealt with in core, but we would benefit a lot from being able to test the example case that creates the problem.

#3 @joedolson
6 weeks ago

  • Keywords reporter-feedback added

#4 in reply to: ↑ 2 @damndealdone
6 weeks ago

Replying to joedolson:

Can you share what plugin is generating this problem? It seems very plausible that this is something that can be dealt with in core, but we would benefit a lot from being able to test the example case that creates the problem.

Hi.

It's "WooCommerce AJAX Products Filter" by BeRocket.

Cheers

#5 @zodiac1978
6 weeks ago

  • Keywords close added

In the past, all my tickets/issues which try to get images in this place fixed or regulated in some way, are either ignored or closed immediately.
https://github.com/WordPress/wporg-plugin-guidelines/issues/71
https://github.com/WordPress/plugin-check/issues/788

To paraphrase the outcome of the discussion:
If a plugin dev wants to shoot in their foot, it is their decision. We are not here to fix this.

Therefore, I recommend closing this ticket as wontfix.

@damndealdone I know you just want to help fix an issue and I don't want to be unwelcoming (the opposite would be true!), but my experience of the past discussion leads me to this conclusion ...

Note: See TracTickets for help on using tickets.