Make WordPress Core

Opened 2 weeks ago

Last modified 2 weeks ago

#65737 reviewing defect (bug)

mediaelementplayer-legacy - the Flash message is no longer needed.

Reported by: edent Owned by:
Priority: low Milestone: Future Release
Component: Media Version: trunk
Severity: minor Keywords: good-first-bug has-patch has-unit-tests
Cc: Focuses: javascript, ui-copy

Description

I don't think this message is still needed in 2026:

'mejs.install-flash' => __( 'You are using a browser that does not have Flash player enabled or installed. Please turn on your Flash player plugin or download the latest version from https://get.adobe.com/flashplayer/' ),

From: https://github.com/WordPress/wordpress-develop/blob/940e7a357729f7683a11658fc841a42711321a5e/src/wp-includes/script-loader.php#L1102

It is injected into my sites as part of <script id=mediaelement-core-js-before>

Following that link eventually goes to Adobe's FAQ about Flash which says:

Since Adobe no longer supports Flash Player after December 31, 2020 and blocked Flash content from running in Flash Player beginning January 12, 2021, Adobe strongly recommends all users immediately uninstall Flash Player to help protect their systems.

As far as I can tell, WordPress's MediaElement will never produce a SWF file for playback - so this error message will never be seen by users.

All occurrences should probably be removed https://github.com/search?q=repo%3AWordPress%2Fwordpress-develop+install-flash&type=code

Change History (6)

#1 @sc0ttkclark
2 weeks ago

  • Keywords good-first-bug added

This ticket was mentioned in PR #12727 on WordPress/wordpress-develop by @irozum.


2 weeks ago
#2

  • Keywords has-patch has-unit-tests added

Removes the obsolete mejs.install-flash localized string from the MediaElement.js mejsL10n object registered in wp_default_scripts(). This message told users to install/enable Adobe Flash Player, but Adobe ended support for Flash Player on December 31, 2020 and WordPress's MediaElement configuration never produces the SWF-based renderer that would trigger this message, so it can never actually be shown to a visitor. Removing it drops dead translated content from every page that enqueues mediaelement-core.

Added a PHPUnit test (Tests_Dependencies_Scripts::test_mediaelement_l10n_does_not_include_flash_message) asserting the inline mejsL10n script data registered for mediaelement-core no longer includes the mejs.install-flash key, while confirming sibling strings such as mejs.play are still present.

## Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Implementation, tests, and PR description. Reviewed by Igor Rozum.

#3 @westonruter
2 weeks ago

  • Milestone Awaiting Review7.1
  • Owner set to westonruter
  • Status newreviewing

Makes sense to me. This reduces the burden on translators

#4 @mirmpro
2 weeks ago

This sounds like a good Core cleanup.

#5 @mirmpro
2 weeks ago

Do we anticipate any regression risk from removing this string? As far as I can tell, the Flash fallback is no longer used, but I wanted to check if there are any remaining code paths or legacy integrations that might still depend on mejs.install-flash.

#6 @westonruter
2 weeks ago

  • Milestone 7.1Future Release
  • Owner westonruter removed

The string is only used here:

https://github.com/WordPress/wordpress-develop/blob/c5690fd7e8721f60f7c40db81debbbf149e87d68/src/js/_enqueues/vendor/mediaelement/mediaelement.js#L1751-L1765

So only on IE and Edge. I'm not sure if this refers to the legacy Edge or the Chromium Edge.

This may end up being made obsolete by upgrading ME.js to the latest version: #56320

So let's actually revisit this change later.

Note: See TracTickets for help on using tickets.