Change History (13)
#3
@
4 weeks ago
Quoting from Slack: https://wordpress.slack.com/archives/C0B4Q0RJVAT/p1786546686314159
The exception is the $_old_files one (which still needs to confirm that the sync.js file should actually be re-introduced in the release)
I've identified the cause. The reintroduction of sync.js was unintentional. Once https://github.com/WordPress/gutenberg/pull/81683 is synced to the core, both sync.js and sync.min.js should be removable.
This ticket was mentioned in PR #13061 on WordPress/wordpress-develop by @wildworks.
4 weeks ago
#4
- Keywords has-patch added
wp-includes/js/dist/sync.js and sync.min.js were removed in 7.0.2, but came back in 7.1. This was not intentional: the sync package is only needed for real-time collaboration, which is not shipping in 7.1, and core has no server-side counterpart for it.
The two paths are currently commented out in $_old_files with a "Restored in WordPress 7.1." note. This PR restores them as active entries so that upgrading to 7.1 deletes the leftover files.
## Order of operations
These steps must be done in this order. Otherwise $_old_files will not match what is actually shipped, and grunt verify:build will fail because the files still exist in the build directory.
- Merge https://github.com/WordPress/gutenberg/pull/81683. The sync package is then no longer exposed as a separate script on Gutenberg's
wp/7.1branch. - On the
7.1branch of wordpress-develop, update the pinned Gutenberg hash to the latest commit of thewp/7.1branch.sync.jsandsync.min.jsthen disappear from core, andwp.syncis no longer exposed. - Finally, commit this PR.
Note that the stale src/wp-includes/js/dist/sync*.js files are not removed automatically by the build, since that directory is ignored by version control. They need to be deleted manually after step 2.
## Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Investigating when and why the files were reintroduced, and drafting this description. The change itself is a two-line edit that I reviewed and take responsibility for.
@wildworks commented on PR #13061:
3 weeks ago
#5
- On the
7.1branch of wordpress-develop, update the pinned Gutenberg hash to the latest commit of thewp/7.1branch.sync.jsandsync.min.jsthen disappear from core, andwp.syncis no longer exposed.- Finally, commit this PR.
Perhaps these two should be executed in a single commit.
This ticket was mentioned in PR #13067 on WordPress/wordpress-develop by @desrosj.
3 weeks ago
#6
This adds a temporary Grunt task to delete the remaining RTC-related files after building.
This is a temporary alternative approach to #13061/https://github.com/WordPress/gutenberg/pull/81683.
Trac ticket: Core-65813
## Use of AI Tools
@wildworks commented on PR #13067:
3 weeks ago
#7
I don't have time to review this PR right now, but if https://github.com/WordPress/wordpress-develop/pull/13061 and https://github.com/WordPress/wordpress-develop/pull/13061 are not ready by the commit freeze, I think it's okay to proceed with this PR.
cc @ellatrix
@desrosj commented on PR #13061:
3 weeks ago
#8
I've updated the gutenberg.sha value to include the change from https://github.com/WordPress/gutenberg/pull/81683. After running the build script, the two files in question are now missing from the results.
@lancewillett commented on PR #13061:
3 weeks ago
#9
Reviewed and tested ✅.
No defects found; the change looks safe to commit to the 7.1 branch.
@wildworks commented on PR #13061:
3 weeks ago
#10
Thank you all for your reviews! I'm glad we could address this issue before the commit freeze. I plan to update the GB Hash one more time before the commit freeze, as there are still a few PRs that need to be backported to 7.1.
@wildworks commented on PR #13067:
3 weeks ago
#11
Closing this in favor of #13061
#13
@
3 weeks ago
Just confirmed that the two files were deleted from the build server as expected: https://build.trac.wordpress.org/changeset/62509.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
In 63031: