Opened 5 weeks ago
Closed 5 weeks ago
#65840 closed enhancement (fixed)
Fonts and Connectors: remove no-JS notices
| Reported by: | wildworks | Owned by: | wildworks |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.2 |
| Component: | Administration | Version: | |
| Severity: | normal | Keywords: | has-patch gutenberg-merge |
| Cc: | Focuses: | accessibility |
Description
Follow-up to #65690.
[62954] added the no-JS heading and notice to src/wp-admin/font-library.php and src/wp-admin/options-connectors.php. Gutenberg PR https://github.com/WordPress/gutenberg/pull/81365 moves that markup into the generated page template, so every wp-build page gets it automatically.
The per-page heading and notice should therefore be removed.
Change History (5)
This ticket was mentioned in PR #12946 on WordPress/wordpress-develop by @wildworks.
5 weeks ago
#1
- Keywords has-patch added
#3
@
5 weeks ago
Thanks @wildworks on followup for the ticket. My only question regarding this is the template would show the same message across all the pages that are build, while it would good to have some way where we can show the no-js message based on the context, how other pages show to be consistent? Could be a better UX. wdyt?
Update: This is cleared in - https://github.com/WordPress/wordpress-develop/pull/12946#issuecomment-5249412972
@wildworks commented on PR #12946:
5 weeks ago
#4
@hbhalodia Thanks for the review!
Do we need to show the context based message for UX?
I don't think so, as the H1 heading already indicates what the page is about.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Removes the per-page no-JS heading and notice added in [62954], since the generated
wp-buildpage template now renders them for every route-based page.Depends on https://github.com/WordPress/gutenberg/pull/81365.
## Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Removing the markup per the ticket; reviewed and verified by me.