WordPress.org
Get WordPress

Make WordPress Core

Opened 3 weeks ago

Last modified 11 hours ago

#65898 assigned task (blessed)

Lint the admin CSS files

Reported by: afercia Owned by: afercia
Priority: normal Milestone: 7.2
Component: Administration Version:
Severity: normal Keywords: has-patch
Cc: Focuses: css

Description

As part of the ongoing work to add a Stylelint configuration to Core in #29792 / ​https://github.com/WordPress/wordpress-develop/pull/12934 I would like to start actually linting the admin CSS files.

This task needs to be completed before merging the related Stylelint NPM scripts and Grunt task. Otherwise, grunt precommit and the related job on the GitHub actions will fail.

To keep things easy to review, I'd like to submit a series of PRs, where each PR lints one file at a time.

As such, I'm going to mark this ticket as a task.

Change History (82)

#1 @afercia
3 weeks ago

  • Type defect (bug) → task (blessed)

This ticket was mentioned in ​PR #13114 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #2

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13115 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #3

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13116 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #4

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13117 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #5

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13118 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #6

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13127 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #7

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13129 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #8

  • Keywords has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

Also fixes a mismatch between visual order and DOM order for the 'Reorder' and 'Add Items' buttons in the Customizer > Menus. Thanks to Stylelint that detected the usage of the row-reverse value.

## Use of AI Tools

None

This ticket was mentioned in ​PR #13130 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #9

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13132 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #10

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13133 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #11

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13137 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #12

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13138 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #13

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13139 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #14

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13140 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #15

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13141 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #16

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13142 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #17

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13143 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #18

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13144 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #19

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13145 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #20

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13146 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #21

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13147 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #22

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13148 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #23

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13149 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #24

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13150 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #25

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13158 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #26

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13159 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #27

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13160 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #28

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13161 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #29

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13162 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #30

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

Also removes the DO NOT EDIT THIS FILE DIRECTLY ... comment block at the top of the file. This file is now no longer built using a build process and it's part of Core.

## Use of AI Tools

None

​@mukesh27 commented on ​PR #13162:
3 weeks ago #31

Also removes the DO NOT EDIT THIS FILE DIRECTLY ... comment block at the top of the file. This file is now no longer built using a build process and it's part of Core.

Do you know from when it was removed from build process?

This ticket was mentioned in ​PR #13164 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #32

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13165 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #33

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13166 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #34

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13167 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #35

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13169 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #36

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13170 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #37

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13171 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #38

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13172 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #39

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13173 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #40

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13174 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #41

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13175 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #42

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

This ticket was mentioned in ​PR #13176 on ​WordPress/wordpress-develop by ​@afercia.
3 weeks ago #43

Trac ticket: https://core.trac.wordpress.org/ticket/65898

Part of the ongoing CSS linting work for https://core.trac.wordpress.org/ticket/65898

## Use of AI Tools

None

#44 @afercia
9 days ago

A ​series of PRs to lint the admin CSS files is ready.

If no objections, I'm going to start from the smaller and simpler ones.

#45 @afercia
9 days ago

  • Keywords has-unit-tests removed
  • Owner set to afercia
  • Status new → assigned

#46 @afercia
9 days ago

In 63370:

Administration: Fix the CSS Coding Standards in color-picker.css.

Lints the src/wp-admin/css/color-picker.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13117

See #65898.

#47 @afercia
9 days ago

In 63371:

Administration: Fix the CSS Coding Standards in farbtastic.css.

Lints the src/wp-admin/css/farbtastic.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13138

See #65898.

#48 @afercia
9 days ago

In 63372:

Administration: Fix the CSS Coding Standards in site-icon.css.

Lints the src/wp-admin/css/site-icon.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13148

See #65898.

#49 @afercia
9 days ago

In 63373:

Administration: Fix the CSS Coding Standards in classic-themes.css.

Lints the src/wp-includes/css/classic-themes.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13160

See #65898.

#50 @afercia
9 days ago

In 63374:

Administration: Fix the CSS Coding Standards in wp-auth-check.css.

Lints the src/wp-includes/css/wp-auth-check.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13167

See #65898.

#51 @afercia
9 days ago

In 63375:

Administration: Fix the CSS Coding Standards in wp-embed-template.css.

Lints the src/wp-includes/css/wp-embed-template.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13169

See #65898.

#52 @afercia
9 days ago

In 63376:

Administration: Fix the CSS Coding Standards in wp-empty-template-alert.css.

Lints the src/wp-includes/css/wp-empty-template-alert.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13170

See #65898.

#53 @afercia
9 days ago

In 63377:

Administration: Fix the CSS Coding Standards in wp-pointer.css.

Lints the src/wp-includes/css/wp-pointer.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13171

See #65898.

#62 @afercia
9 days ago

In 63386:

Administration: Fix the CSS Coding Standards in buttons.css.

Lints the src/wp-includes/css/buttons.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13159

See #65898.

#63 @afercia
9 days ago

In 63387:

Administration: Fix the CSS Coding Standards in l10n.css.

Lints the src/wp-admin/css/l10n.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13141

See #65898.

#64 @afercia
9 days ago

In 63388:

Administration: Fix the CSS Coding Standards in sunrise colors.scss.

Lints the src/wp-admin/css/colors/sunrise/colors.scss file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13176

See #65898.

#65 @afercia
9 days ago

In 63389:

Administration: Fix the CSS Coding Standards in _variables.scss.

Lints the src/wp-admin/css/colors/_variables.scss file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13175

See #65898.

#66 @afercia
9 days ago

In 63390:

Administration: Fix the CSS Coding Standards in _mixins.scss.

Lints the src/wp-admin/css/colors/_mixins.scss file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13173

See #65898.

#72 @afercia
13 hours ago

In 63499:

Administration: Fix the CSS Coding Standards in _tokens.scss.

Lints the src/wp-admin/css/colors/_tokens.scss file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13174

See #65898.

#74 @afercia
12 hours ago

In 63502:

Administration: Fix the CSS Coding Standards in jquery-ui-dialog.css.

Lints the src/wp-includes/css/jquery-ui-dialog.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13165

See #65898.

#76 @afercia
12 hours ago

In 63503:

Administration: Fix the CSS Coding Standards in revisions.css.

Lints the src/wp-admin/css/revisions.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13146

See #65898.

#78 @afercia
11 hours ago

In 63504:

Administration: Fix the CSS Coding Standards in admin-bar.css.

Lints the src/wp-includes/css/admin-bar.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13158

See #65898.

#79 @afercia
11 hours ago

In 63505:

Administration: Remove unnecessary empty line in buttons.css.

Amends [63386].
Part of the ongoing effort to lint all the admin CSS files.

See #65898.

#81 @afercia
11 hours ago

In 63506:

Administration: Fix the CSS Coding Standards in admin-menu.css.

Lints the src/wp-admin/css/admin-menu.css file.
Part of the ongoing effort to lint all the admin CSS files.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13115

See #65898.

Note: See TracTickets for help on using tickets.