Make WordPress Core

Opened 4 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#65903 closed defect (bug) (fixed)

Update Sodium Compat to 1.24.1

Reported by: paragoninitiativeenterprises Owned by: SergeyBiryukov
Priority: normal Milestone: 7.2
Component: External Libraries Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Change History (5)

#1 @mukesh27
4 weeks ago

  • Version trunk

This ticket was mentioned in PR #13290 on WordPress/wordpress-develop by @wprashed.


3 weeks ago
#2

### Ticket

### Description

Updates sodium_compat from v1.24.0 to v1.24.1.

This release fixes Ed25519 main subgroup validation and ensures public key validation correctly rejects points not on the main prime order subgroup across 64-bit and 32-bit implementations.

References:

### Testing Instructions

Verify that sodium_compat loads and functions as expected without errors.

#3 @SergeyBiryukov
2 weeks ago

  • Milestone Awaiting Review7.2

#4 @SergeyBiryukov
2 weeks ago

  • Owner set to SergeyBiryukov
  • Resolutionfixed
  • Status newclosed

In 63397:

Upgrade/Install: Update sodium_compat to v1.24.1.

The latest version includes a fix for Ed25519 main subgroup validation.

References:

Developed in https://github.com/WordPress/wordpress-develop/pull/13290.

Follow-up to r55699, r58752, r58753, r60787, r60905, r61419.

Props paragoninitiativeenterprises, wprashed, SergeyBiryukov.
Fixes #65903.

#5 @raxxor
2 weeks ago

Two follow-ups:

  1. Bump straight to 1.24.2. The 1.24.1 fix corrects ge_mul_l and the subgroup predicate, but the global 64-bit path in Compat::verify_detached() still skips the small-order check on the public key. Upstream added that check in v1.24.2: https://github.com/paragonie/sodium_compat/compare/v1.24.1...v1.24.2

This is a hardening gap rather than a new advisory. ext-sodium rejects the affected inputs, so it only matters where the polyfill runs without the extension. Taking 1.24.2 directly would close it.

  1. Backports to the 6.x/7.x branches. The affected polyfill versions ship in every release from 6.6 through 7.1.0, and 7.1.0 was tagged one day after the GHSA-733q-f2wq-9c8w advisory with 1.24.0 still bundled. A backport of the bump to the branches in their support window, ideally straight to 1.24.2, would cover installs without ext-sodium.
Note: See TracTickets for help on using tickets.