WordPress.org
Get WordPress

Make WordPress Core

Opened 18 years ago

Closed 17 years ago

Last modified 17 years ago

#6602 closed defect (bug) (fixed)

kses Should Prevent Duplicate Attributes

Reported by: schiller Owned by:
Priority: normal Milestone: 2.6.1
Component: General Version: 2.6
Severity: normal Keywords: has-patch 2nd-opinion
Cc: Focuses:

Description

The following is allowed, which would break a blog using strict XHTML:

<a href='foo' href='foo'>blah</a>

Attachments (1)

bug6602.patch​ (3.0 KB ) - added by schiller 18 years ago.
Updated patch to take first attribute and ignore later duplicate attributes (per Sam Ruby's comment)

Download all attachments as: .zip

Change History (12)

#1 @schiller
18 years ago

  • Cc rubys@… added

@schiller
18 years ago

Updated patch to take first attribute and ignore later duplicate attributes (per Sam Ruby's comment)

#2 @schiller
18 years ago

  • Keywords has-patch 2nd-opinion added; xhtml kses removed

#3 @schiller
18 years ago

  • Milestone 2.7 → 2.5.1

#4 @lloydbudd
18 years ago

  • Milestone 2.5.2 → 2.6
  • Version → 2.5.1

#5 @azaozz
18 years ago

  • Milestone 2.9 → 2.7

#6 @azaozz
18 years ago

  • Resolution → fixed
  • Status new → closed

(In [8384]) Take first attribute and ignore later duplicate attributes. Fixes #6602 for trunk. Props schiller.

#7 @azaozz
18 years ago

  • Milestone 2.7 → 2.6.1
  • Resolution fixed
  • Status closed → reopened

Re-open for 2.6.1

#8 @azaozz
18 years ago

  • Resolution → fixed
  • Status reopened → closed

(In [8385]) Take first attribute and ignore later duplicate attributes. Fixes #6602 for 2.6.1. Props schiller.

#9 @codedread
17 years ago

  • Resolution fixed
  • Status closed → reopened
  • Version 2.5.1 → 2.9.1

Bug appears to still be valid in WP 2.9.1, despite my patch being in kses.php

#10 @nacin
17 years ago

  • Resolution → fixed
  • Status reopened → closed
  • Version 2.9.1 → 2.6

Re-closing (see #6642:comment:15)

#11 @rubys
17 years ago

  • Cc rubys@… removed
Note: See TracTickets for help on using tickets.